View GitHub Repository core

Schedule Inspection
Subscribe
Failed Conditions
Pull Request — master (#2171)
by Janko
29:13 queued 17:22
created

20,738 +17 Covered Lines

56,130 +69 Total Lines

36.9 % -0.015% Code Coverage

PHP Classes Changes

 
 ⇢
0%
GetTargetWrapperTrait added
 
 ⇢
0%
SpacecraftStorageTorpedoLogic added
 
 ⇢
2.22%
AlertStateManager added
 
 ⇢
2.67%
ActivatorDeactivatorHelper added
 
 ⇢
2.74%
SpacecraftStorageCommodityLogic added
 
 ⇢
4.44%
SystemActivation added
 
 ⇢
9.35%
SpacecraftStorageCrewLogic added
 
 ⇢
11.11%
SystemDeactivation added
 
 ⇢
30.76%
ColonyChangeable added
8.04%
 ↗
31.82%
 SpacecraftStorageEntityWrapper improved
58.54%
 ↘
46.15%
 CommodityTransferStrategy got worse
46.7%
 ↗
58.1%
 Colony improved
3.7%
 ↗
7.14%
 PlanetColonization improved
16.66%
 ↗
18.18%
 SpacecraftConfiguratorFactory improved
41.38%
 ↘
40%
 ColonyShieldingManager got worse
70.97%
 ↗
72.31%
 ColonyResetter improved
20%
 ↗
21.05%
 TrumfieldStorageEntityWrapper improved
10.19%
 ↗
11.24%
 ColonyStorageEntityWrapper improved
96.3%
 ↘
95.45%
 StorageEntityWrapperFactory got worse
⋮ view more  
0.92%
 ↛
 
 ActivatorDeactivatorHelper removed

CRAP Changes

 
 ⇢
342
SpacecraftStorageCommodityLogic::transferPerSpacec... added
 
 ⇢
272
SpacecraftStorageCrewLogic::postCrewTransfer() added
 
 ⇢
156
SystemActivation::activateIntern() added
 
 ⇢
132
SpacecraftStorageCrewLogic::acceptsCrewFrom() added
 
 ⇢
110
AlertStateManager::setAlertStateShip() added
 
 ⇢
90
SpacecraftStorageCommodityLogic::transfer() added
 
 ⇢
72
AlertStateManager::setAlertStateFleet() added
 
 ⇢
56
SpacecraftStorageCrewLogic::checkCrewStorage() added
 
 ⇢
56
SpacecraftStorageTorpedoLogic::canStoreTorpedoType... added
 
 ⇢
42
CommodityTransferStrategy::shieldsAreBlocking() added
⋮ view more  
4.001
 ↗
4.002
 StorageEntityWrapperFactory::wrapStorageEntity() got worse
5.1158
 ↘
5.0984
 EpsBarProvider::getEpsBarTitleString() improved
9.2312
 ↘
8.8142
 ColonyPopulationCalculator::getGrowth() improved
6.9849
 ↘
1
 SpacecraftStorageEntityWrapper::getFreeCrewSpace() improved
342
 ↛
 
 SpacecraftStorageEntityWrapper::transferPerSpacecr... removed
156
 ↛
 
 ActivatorDeactivatorHelper::activateIntern() removed
110
 ↛
 
 ActivatorDeactivatorHelper::setAlertStateShip() removed
72
 ↛
 
 ActivatorDeactivatorHelper::setAlertStateFleet() removed
30
 ↛
 
 ActivatorDeactivatorHelper::deactivateFleetIntern(... removed
30
 ↛
 
 ActivatorDeactivatorHelper::setAlertState() removed
30
 ↛
 
 ActivatorDeactivatorHelper::deactivateIntern() removed
30
 ↛
 
 SpacecraftStorageEntityWrapper::sendUplinkMessage(... removed
30
 ↛
 
 ActivatorDeactivatorHelper::activateFleet() removed
30
 ↛
 
 ColonyStorageEntityWrapper::canPenetrateShields() removed
⋮ view more