SpacecraftCrewTrait::getNeededCrewCount() - Code Metrics - Inspection of "extract business logic from spacecraft entity" - st-universe/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — dev ( c12b3a...6ad196 )

by Janko

created 2025-06-01 16:59 UTC

SpacecraftCrewTrait::getNeededCrewCount() A

↳ Parent: SpacecraftCrewTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2.032

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	4
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	8
ccs	4
cts	5
cp	0.8
crap	2.032
rs	10

<?php

namespace Stu\Component\Spacecraft\Trait;

use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
use Stu\Module\Control\GameControllerInterface;

trait SpacecraftCrewTrait
{
    use SpacecraftTrait;
    use HasSpacecraftSystemTrait;

    public function getNeededCrewCount(): int
    {
        $buildplan = $this->getThis()->getBuildplan();
        if ($buildplan === null) {
            return 0;
        }

        return $buildplan->getCrew();
    }

    public function getCrewCount(): int
    {
        return $this->getThis()->getCrewAssignments()->count();
    }

    public function getExcessCrewCount(): int
    {
        return $this->getCrewCount() - $this->getNeededCrewCount();
    }

    public function hasEnoughCrew(?GameControllerInterface $game = null): bool
    {
        $buildplan = $this->getThis()->getBuildplan();

        if ($buildplan === null) {
            if ($game !== null) {
                $game->addInformation(_("Keine Crew vorhanden"));
            }
            return false;
        }

        $result = $buildplan->getCrew() <= 0
            || $this->getCrewCount() >= $buildplan->getCrew();

        if (!$result && $game !== null) {
            $game->addInformationf(
                _("Es werden %d Crewmitglieder benötigt"),
                $buildplan->getCrew()
            );
        }

        return $result;
    }

    public function canMan(): bool
    {
        $buildplan = $this->getThis()->getBuildplan();

        return $buildplan !== null
            && $buildplan->getCrew() > 0
            && $this->hasSpacecraftSystem(SpacecraftSystemTypeEnum::LIFE_SUPPORT);
    }
}


1		<?php
2
3		namespace Stu\Component\Spacecraft\Trait;
4
5		use Stu\Component\Spacecraft\System\SpacecraftSystemTypeEnum;
6		use Stu\Module\Control\GameControllerInterface;
7
8		trait SpacecraftCrewTrait
9		{
10		use SpacecraftTrait;
11		use HasSpacecraftSystemTrait;
12
13	7	public function getNeededCrewCount(): int
14		{
15	7	$buildplan = $this->getThis()->getBuildplan();
16	7	if ($buildplan === null) {
17		return 0;
18		}
19
20	7	return $buildplan->getCrew();
21		}
22
23	12	public function getCrewCount(): int
24		{
25	12	return $this->getThis()->getCrewAssignments()->count();
26		}
27
28	6	public function getExcessCrewCount(): int
29		{
30	6	return $this->getCrewCount() - $this->getNeededCrewCount();
31		}
32
33	3	public function hasEnoughCrew(?GameControllerInterface $game = null): bool
34		{
35	3	$buildplan = $this->getThis()->getBuildplan();
36
37	3	if ($buildplan === null) {
38		if ($game !== null) {
39		$game->addInformation(_("Keine Crew vorhanden"));
40		}
41		return false;
42		}
43
44	3	$result = $buildplan->getCrew() <= 0
45	3	\|\| $this->getCrewCount() >= $buildplan->getCrew();
46
47	3	if (!$result && $game !== null) {
48		$game->addInformationf(
49		_("Es werden %d Crewmitglieder benötigt"),
50		$buildplan->getCrew()
51		);
52		}
53
54	3	return $result;
55		}
56
57		public function canMan(): bool
58		{
59		$buildplan = $this->getThis()->getBuildplan();
60
61		return $buildplan !== null
62		&& $buildplan->getCrew() > 0
63		&& $this->hasSpacecraftSystem(SpacecraftSystemTypeEnum::LIFE_SUPPORT);
64		}
65		}
66

st-universe / core

Push — dev ( c12b3a...6ad196 )

SpacecraftCrewTrait::getNeededCrewCount() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like