YamlStandards\Command\Service\YamlFilesPathService

Complexity

Total Complexity

4

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getPathToYamlFiles()	0	11	2
A	globRecursive()	0	9	2

<?php

declare(strict_types=1);

namespace YamlStandards\Command\Service;

class YamlFilesPathService
{
    /**
     * @param string[] $patterns
     * @return string[]
     */
    public static function getPathToYamlFiles(array $patterns): array
    {
        $pathToFiles = [[]];
        foreach ($patterns as $pattern) {
            $pathToFiles[] = self::globRecursive($pattern);
        }

        $pathToFiles = array_merge(...$pathToFiles);
        $pathToFiles = str_replace('\\', '/', $pathToFiles);

        return array_unique($pathToFiles);
    }

    /**
     * @param string $pattern
     * @return string[]
     *
     * @link https://www.php.net/manual/en/function.glob.php#106595
     */
    private static function globRecursive(string $pattern): array
    {
        $files = glob($pattern);

        foreach (glob(dirname($pattern) . '/*', GLOB_ONLYDIR | GLOB_NOSORT) as $dir) {
            $files = array_merge($files, self::globRecursive($dir . '/' . basename($pattern)));

It seems like $files can also be of type false; however, parameter $array1 of array_merge() does only seem to accept array, maybe add an additional type check?

        }

        return $files;

The expression return $files could return the type false which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }
}