YamlStandards\Command\Service\YamlFilesPathService::globRecursive()

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

0

<?php
    private static function globRecursive(string $pattern): array
    {
        $files = glob($pattern);

        foreach (glob(dirname($pattern) . '/*', GLOB_ONLYDIR | GLOB_NOSORT) as $dir) {
            $files = array_merge($files, self::globRecursive($dir . '/' . basename($pattern)));

It seems like $files can also be of type false; however, parameter $array1 of array_merge() does only seem to accept array, maybe add an additional type check?

        }

        return $files;

The expression return $files could return the type false which is incompatible with the type-hinted return array. Consider adding an additional type-check to rule them out.

    }