sportarchive / CloudTranscode

src/activities/transcoders/AudioTranscoder.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-require_once __DIR__ . '/BasicTranscoder.php';
+require_once __DIR__.'/BasicTranscoder.php';
 
 class AudioTranscoder extends BasicTranscoder
 {

src/scripts/getFromS3.php

Spacing +9 added lines, -9 removed lines

@@ -4,13 +4,13 @@ 
  * Script used to get a file in AWS S3
  **/
 
-require __DIR__ . "/../../vendor/autoload.php";
+require __DIR__."/../../vendor/autoload.php";
 
 use Aws\S3\S3Client;
 
 function usage()
 {
-    echo("Usage: php ". basename(__FILE__) . " [-h] [--force] --bucket <s3 bucket> --file <filename> --to <filepath>\n");
+    echo("Usage: php ".basename(__FILE__)." [-h] [--force] --bucket <s3 bucket> --file <filename> --to <filepath>\n");
     echo("--help, -h: Print this help\n");
     echo("--bucket <s3 bucket>: Name of the S3 bucket\n");
     echo("--file <filename>: Name of the file in the S3 bucket\n");
@@ -41,8 +41,8 @@ 
     file_exists($options['to']) &&
     filesize($options['to']))
 {
-    print json_encode([ "status" => "SUCCESS",
-            "msg" => "[".__FILE__."] Using local copy: '" . $options['to']  . "'" ]);
+    print json_encode(["status" => "SUCCESS",
+            "msg" => "[".__FILE__."] Using local copy: '".$options['to']."'"]);
     exit(0);
 }
 
@@ -58,14 +58,14 @@ 
         ));
 
     // Print JSON error output
-    print json_encode([ "status" => "SUCCESS",
-            "msg" => "[".__FILE__."] Download '" . $options['bucket'] . "/" . $options['file'] . "' successful !" ]);
+    print json_encode(["status" => "SUCCESS",
+            "msg" => "[".__FILE__."] Download '".$options['bucket']."/".$options['file']."' successful !"]);
 } 
 catch (Exception $e) {
-    $err = "Unable to get '" . $options['bucket'] . "/" . $options['file'] . "' file from S3 ! " . $e->getMessage();
+    $err = "Unable to get '".$options['bucket']."/".$options['file']."' file from S3 ! ".$e->getMessage();
     // Print JSON error output
-    print json_encode([ "status" => "ERROR",
-            "msg" => "[".__FILE__."] $err" ]);
+    print json_encode(["status" => "ERROR",
+            "msg" => "[".__FILE__."] $err"]);
     
     die("[".__FILE__."] $err");
 }

Braces +4 added lines, -4 removed lines

@@ -22,8 +22,9 @@ 
 function check_input_parameters($options)
 {
     if (!count($options) || isset($options['h']) ||
-        isset($options['help']))
-        usage();
+        isset($options['help'])) {
+            usage();
+    }
     
     if (!isset($options['bucket']) || !isset($options['file']) ||
         !isset($options['to']))
@@ -60,8 +61,7 @@ 
     // Print JSON error output
     print json_encode([ "status" => "SUCCESS",
             "msg" => "[".__FILE__."] Download '" . $options['bucket'] . "/" . $options['file'] . "' successful !" ]);
-} 
-catch (Exception $e) {
+} catch (Exception $e) {
     $err = "Unable to get '" . $options['bucket'] . "/" . $options['file'] . "' file from S3 ! " . $e->getMessage();
     // Print JSON error output
     print json_encode([ "status" => "ERROR",

src/scripts/putInS3.php

Spacing +8 added lines, -8 removed lines

@@ -4,13 +4,13 @@ 
  * Script used to put a file in AWS S3
  **/
 
-require __DIR__ . "/../../vendor/autoload.php";
+require __DIR__."/../../vendor/autoload.php";
 
 use Aws\S3\S3Client;
 
 function usage()
 {
-    echo("Usage: php ". basename(__FILE__) . " [-h] [--rrs::] [--encrypt::] --bucket <s3 bucket> --file <filename> --from <filepath>\n");
+    echo("Usage: php ".basename(__FILE__)." [-h] [--rrs::] [--encrypt::] --bucket <s3 bucket> --file <filename> --from <filepath>\n");
     echo("--help, -h: Print this help\n");
     echo("--bucket <s3 bucket>: Name of the S3 bucket\n");
     echo("--file <filename>: Name of the file to create in bucket. You can override local filename.\n");
@@ -33,7 +33,7 @@ 
         usage();
     }
 
-    $options['bucket'] = rtrim( $options['bucket'], "/");
+    $options['bucket'] = rtrim($options['bucket'], "/");
 }
 
 $options = getopt("h", [
@@ -66,15 +66,15 @@ 
     $s3->putObject($params); 
     
     // Print JSON error output
-    print json_encode([ "status" => "SUCCESS",
-            "msg" => "[".__FILE__."] Upload '" . $options['from'] . "' to '" . $options['bucket'] . "/" . $options['file']  . "' successful !" ]);
+    print json_encode(["status" => "SUCCESS",
+            "msg" => "[".__FILE__."] Upload '".$options['from']."' to '".$options['bucket']."/".$options['file']."' successful !"]);
 } 
 catch (Exception $e) {
-    $err = "Unable to put file '" . $options['from']  . "' into S3: '" . $options['bucket'] . "/" . $options['file']  . "'! " . $e->getMessage();
+    $err = "Unable to put file '".$options['from']."' into S3: '".$options['bucket']."/".$options['file']."'! ".$e->getMessage();
     
     // Print JSON error output
-    print json_encode([ "status" => "ERROR",
-            "msg" => "[".__FILE__."] $err" ]);
+    print json_encode(["status" => "ERROR",
+            "msg" => "[".__FILE__."] $err"]);
 
     die("[".__FILE__."] $err");
 }

Braces +10 added lines, -8 removed lines

@@ -23,8 +23,9 @@ 
 function check_input_parameters(&$options)
 {
     if (!count($options) || isset($options['h']) ||
-        isset($options['help']))
-        usage();
+        isset($options['help'])) {
+            usage();
+    }
     
     if (!isset($options['bucket']) || !isset($options['file']) ||
         !isset($options['from']))
@@ -57,10 +58,12 @@ 
     );
 
     // StorageClass and Encryption ?
-    if (isset($options['rrs']))
-        $params['StorageClass'] = 'REDUCED_REDUNDANCY';
-    if (isset($options['encrypt']))
-        $params['ServerSideEncryption'] = 'AES256';
+    if (isset($options['rrs'])) {
+            $params['StorageClass'] = 'REDUCED_REDUNDANCY';
+    }
+    if (isset($options['encrypt'])) {
+            $params['ServerSideEncryption'] = 'AES256';
+    }
     
     // Upload and Save file to S3
     $s3->putObject($params); 
@@ -68,8 +71,7 @@ 
     // Print JSON error output
     print json_encode([ "status" => "SUCCESS",
             "msg" => "[".__FILE__."] Upload '" . $options['from'] . "' to '" . $options['bucket'] . "/" . $options['file']  . "' successful !" ]);
-} 
-catch (Exception $e) {
+} catch (Exception $e) {
     $err = "Unable to put file '" . $options['from']  . "' into S3: '" . $options['bucket'] . "/" . $options['file']  . "'! " . $e->getMessage();
     
     // Print JSON error output

src/utils/CommandExecuter.php

Braces +9 added lines, -6 removed lines

@@ -17,8 +17,9 @@ 
     
     public function __construct($cpeLogger = null)
     {
-        if (!$cpeLogger)
-            $this->cpeLogger = new CpeSdk\CpeLogger(null, 'CommandExecuter');
+        if (!$cpeLogger) {
+                    $this->cpeLogger = new CpeSdk\CpeLogger(null, 'CommandExecuter');
+        }
         $this->cpeLogger = $cpeLogger;
     }
     
@@ -112,10 +113,12 @@ 
         if ($procStatus['exitcode'] > 0)
         {
             $this->cpeLogger->log_out("ERROR", basename(__FILE__), "Can't execute: $cmd. Exit Code: ".$procStatus['exitcode']);
-            if ($allOut)
-                $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDOUT: ".$allOut);
-            if ($allOutErr)
-                $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDERR: ".$allOutErr);
+            if ($allOut) {
+                            $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDOUT: ".$allOut);
+            }
+            if ($allOutErr) {
+                            $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDERR: ".$allOutErr);
+            }
         }
         
         if ($showProgress) {

Indentation +3 added lines, -3 removed lines

@@ -61,7 +61,7 @@ 
         
         // Check process status at every turn
         do {
-	    sleep($sleep);	    
+        sleep($sleep);	    
 
             // Read prog output
             if (isset($descriptors[1]) &&
@@ -109,8 +109,8 @@ 
             $i++;
         } while ($procStatus['running']);
 
-	fclose($pipes[1]);
-	fclose($pipes[2]);
+    fclose($pipes[1]);
+    fclose($pipes[2]);
 
         if ($procStatus['exitcode'] > 0)
         {

Spacing +1 added lines, -1 removed lines

@@ -80,7 +80,7 @@
             }
 
             // If callback only after N turns
-            if ( !$callbackTurns || in_array($i, array(0, $callbackTurns)) ) 
+            if (!$callbackTurns || in_array($i, array(0, $callbackTurns))) 
             {
                 if ($showProgress) {
                     echo ".\n";

src/utils/S3Utils.php

Spacing +3 added lines, -3 removed lines

@@ -5,7 +5,7 @@ 
  * The scripts are executed using the CommandExecuter
   */
 
-require_once __DIR__ . '/CommandExecuter.php';
+require_once __DIR__.'/CommandExecuter.php';
 
 use SA\CpeSdk;
 
@@ -35,7 +35,7 @@ 
         $callback = null, 
         $callbackParams = null)
     {   
-        $cmd = "php " . __DIR__ . self::GET_FROM_S3;
+        $cmd = "php ".__DIR__.self::GET_FROM_S3;
         $cmd .= " --bucket $bucket";
         $cmd .= " --file $filename";
         $cmd .= " --to $saveFileTo";
@@ -57,7 +57,7 @@ 
         $callback = null, 
         $callbackParams = null)
     {
-        $cmd  = "php " . __DIR__ . self::PUT_IN_S3;
+        $cmd  = "php ".__DIR__.self::PUT_IN_S3;
         $cmd .= " --bucket $bucket";
         $cmd .= " --file $filename";
         $cmd .= " --from $pathToFileToSend";

Braces +21 added lines, -14 removed lines

@@ -22,8 +22,9 @@ 
     
     public function __construct($cpeLogger = null)
     {
-        if (!$cpeLogger)
-            $this->cpeLogger = new CpeSdk\CpeLogger(null, 'S3Utils');
+        if (!$cpeLogger) {
+                    $this->cpeLogger = new CpeSdk\CpeLogger(null, 'S3Utils');
+        }
         $this->cpeLogger = $cpeLogger;
     }
 
@@ -61,10 +62,12 @@ 
         $cmd .= " --bucket $bucket";
         $cmd .= " --file $filename";
         $cmd .= " --from $pathToFileToSend";
-        if ($options['rrs'])
-            $cmd .= " --rrs";
-        if ($options['encrypt'])
-            $cmd .= " --encrypt";
+        if ($options['rrs']) {
+                    $cmd .= " --rrs";
+        }
+        if ($options['encrypt']) {
+                    $cmd .= " --encrypt";
+        }
     
         // HAndle execution
         return ($this->handle_s3_ops(
@@ -91,21 +94,25 @@ 
             true,
             5);
         
-        if ($out['outErr'])
-            throw new CpeSdk\CpeException($out['outErr'],
+        if ($out['outErr']) {
+                    throw new CpeSdk\CpeException($out['outErr'],
                 self::S3_OPS_FAILED);
+        }
 
-        if (!$out['out'])
-            throw new CpeSdk\CpeException("Script '$caller' didn't return any data !",
+        if (!$out['out']) {
+                    throw new CpeSdk\CpeException("Script '$caller' didn't return any data !",
                 self::NO_OUTPUT_DATA);
+        }
     
-        if (!($decoded = json_decode($out['out'], true)))
-            throw new CpeSdk\CpeException($out['out'],
+        if (!($decoded = json_decode($out['out'], true))) {
+                    throw new CpeSdk\CpeException($out['out'],
                 self::S3_OPS_FAILED);
+        }
     
-        if ($decoded["status"] == "ERROR")
-            throw new CpeSdk\CpeException($decoded["msg"],
+        if ($decoded["status"] == "ERROR") {
+                    throw new CpeSdk\CpeException($decoded["msg"],
                 self::S3_OPS_FAILED);
+        }
 
         return ($decoded);
     }

Indentation +2 added lines, -2 removed lines

@@ -3,7 +3,7 @@ 
  * This class allows you to call the two S3 scripts
  * to download and upload files.
  * The scripts are executed using the CommandExecuter
-  */
+ */
 
 require_once __DIR__ . '/CommandExecuter.php';
 
@@ -85,7 +85,7 @@ 
             $cmd,
             2,
             array(1 => array("pipe", "w"),
-                  2 => array("pipe", "w")),
+                    2 => array("pipe", "w")),
             $callback,
             $callbackParams, 
             true,

src/activities/transcoders/VideoTranscoder.php

Doc Comments +6 added lines

@@ -40,6 +40,12 @@
     // $metadata should contain the ffprobe video stream array.
 
     // Start FFmpeg for output transcoding
+
+    /**
+     * @param string $tmpPathInput
+     * @param null|string $pathToInputFile
+     * @param string $pathToOutputFiles
+     */
     public function transcode_asset(
         $tmpPathInput,
         $pathToInputFile, 

Braces +7 added lines, -10 removed lines

@@ -65,13 +65,14 @@ 
             $this->activityLogKey
         );
         
-        if ($metadata)
-            $this->cpeLogger->log_out(
+        if ($metadata) {
+                    $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
                 "Input Video metadata: " . print_r($metadata, true),
                 $this->activityLogKey
             );
+        }
         
         try {
             $ffmpegCmd = "";
@@ -138,8 +139,7 @@ 
             // FFProbe the output file and return its information
             $output_info =
                 $this->get_asset_info($pathToOutputFiles."/".$outputWanted->{'output_file_info'}['basename']);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
@@ -289,8 +289,7 @@ 
             $time = gmdate("H:i:s", $snapshot_sec) . ".000";
             $pathToOutputFiles .= "/" . $outputFileInfo['basename'];
             $frameOptions = " -ss $time -vframes 1";
-        }
-        else if ($outputWanted->{'mode'} == 'intervals')
+        } else if ($outputWanted->{'mode'} == 'intervals')
         {
             $intervals = self::INTERVALS_DEFAULT;
             if (isset($outputWanted->{'intervals'}) &&
@@ -343,8 +342,7 @@ 
                 array(1 => array("pipe", "w"), 2 => array("pipe", "w")),
                 false, false, 
                 false, 1);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
@@ -604,8 +602,7 @@ 
         foreach ($metadata->streams as $key => $value) {
             if ($value->codec_type === 'video') {
                 $videoStreams = $value;
-            }
-            else if ($value->codec_type === 'audio') {
+            } else if ($value->codec_type === 'audio') {
                 $audioStreams = $value;
             }
         }

Spacing +25 added lines, -25 removed lines

@@ -7,7 +7,7 @@ 
  * We use ffprobe, ffmpeg and convert to analyse, transcode and manipulate videos and images (watermark)
  */
 
-require_once __DIR__ . '/BasicTranscoder.php';
+require_once __DIR__.'/BasicTranscoder.php';
 
 use SA\CpeSdk;
 
@@ -69,7 +69,7 @@ 
             $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
-                "Input Video metadata: " . print_r($metadata, true),
+                "Input Video metadata: ".print_r($metadata, true),
                 $this->activityLogKey
             );
         
@@ -143,7 +143,7 @@ 
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
-                "Execution of command '".$ffmpegCmd."' failed: " . print_r($metadata, true). ". ".$e->getMessage(),
+                "Execution of command '".$ffmpegCmd."' failed: ".print_r($metadata, true).". ".$e->getMessage(),
                 $this->activityLogKey
             );
             return false;
@@ -186,7 +186,7 @@ 
         }
         
         // Append output filename to path
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
         // Replace ${output_file} by output filename and path to local disk
         $ffmpegCmd = preg_replace('/\$\{output_file\}/', $pathToOutputFiles, $ffmpegCmd);
 
@@ -246,7 +246,7 @@ 
         }
         
         // Create FFMpeg arguments
-        $ffmpegArgs =  " -i $pathToInputFile -y -threads 0";
+        $ffmpegArgs = " -i $pathToInputFile -y -threads 0";
         $ffmpegArgs .= " -vf scale=$size";
         $ffmpegArgs .= " -vcodec $videoCodec";
         $ffmpegArgs .= " -acodec $audioCodec";
@@ -257,9 +257,9 @@ 
         $ffmpegArgs .= " $watermarkOptions";
         
         // Append output filename to path
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
         // Final command
-        $ffmpegCmd  = "ffmpeg $ffmpegArgs $pathToOutputFiles";
+        $ffmpegCmd = "ffmpeg $ffmpegArgs $pathToOutputFiles";
             
         return ($ffmpegCmd);
     }
@@ -286,8 +286,8 @@ 
                 $snapshot_sec = $outputWanted->{'snapshot_sec'};
             }
                 
-            $time = gmdate("H:i:s", $snapshot_sec) . ".000";
-            $pathToOutputFiles .= "/" . $outputFileInfo['basename'];
+            $time = gmdate("H:i:s", $snapshot_sec).".000";
+            $pathToOutputFiles .= "/".$outputFileInfo['basename'];
             $frameOptions = " -ss $time -vframes 1";
         }
         else if ($outputWanted->{'mode'} == 'intervals')
@@ -298,14 +298,14 @@ 
                 $intervals = $outputWanted->{'intervals'};
             }
             
-            $pathToOutputFiles .= "/" . $outputFileInfo['filename'] . "%06d." 
+            $pathToOutputFiles .= "/".$outputFileInfo['filename']."%06d." 
                 . $outputFileInfo['extension'];
             $frameOptions = " -vf fps=fps=1/$intervals";
         }
 
         // Create FFMpeg arguments
-        $ffmpegArgs  =  " -i $pathToInputFile -y -threads 0";
-        $ffmpegArgs .= " -vf scale=" . $outputWanted->{'size'};
+        $ffmpegArgs  = " -i $pathToInputFile -y -threads 0";
+        $ffmpegArgs .= " -vf scale=".$outputWanted->{'size'};
         $ffmpegArgs .= " $frameOptions -f image2 -q:v 8";
 
         // Final command
@@ -336,7 +336,7 @@ 
             $this->activityLogKey);
 
         // Transform watermark for opacity
-        $convertCmd = "convert $watermarkPath -alpha on -channel A -evaluate Multiply " . $watermarkOptions->{'opacity'} . " +channel $newWatermarkPath";
+        $convertCmd = "convert $watermarkPath -alpha on -channel A -evaluate Multiply ".$watermarkOptions->{'opacity'}." +channel $newWatermarkPath";
 
         try {
             $out = $this->executer->execute($convertCmd, 1, 
@@ -365,7 +365,7 @@ 
         // Format options for FFMpeg
         $size      = $watermarkOptions->{'size'};
         $positions = $this->get_watermark_position($watermarkOptions);
-        $formattedOptions = "-vf \"movie=$newWatermarkPath, scale=$size [wm]; [in][wm] overlay=" . $positions['x'] . ':' . $positions['y'] . " [out]\"";
+        $formattedOptions = "-vf \"movie=$newWatermarkPath, scale=$size [wm]; [in][wm] overlay=".$positions['x'].':'.$positions['y']." [out]\"";
         
         return ($formattedOptions);
     }
@@ -382,10 +382,10 @@ 
             $positions['y'] = $watermarkOptions->{'y'};
         }
         if ($watermarkOptions->{'x'} < 0) {
-            $positions['x'] = 'main_w-overlay_w' . $watermarkOptions->{'x'};
+            $positions['x'] = 'main_w-overlay_w'.$watermarkOptions->{'x'};
         }
         if ($watermarkOptions->{'y'} < 0) {
-            $positions['y'] = 'main_h-overlay_h' . $watermarkOptions->{'y'};
+            $positions['y'] = 'main_h-overlay_h'.$watermarkOptions->{'y'};
         }
 
         return ($positions);
@@ -460,7 +460,7 @@ 
             }
         }
 
-        return (str_replace("x",":", $size));
+        return (str_replace("x", ":", $size));
     }
     
     // REad ffmpeg output and calculate % progress
@@ -496,7 +496,7 @@ 
 
         // # finally, progress is easy
         if ($done && $duration) {
-            $progress = round(($done/$duration)*100);
+            $progress = round(($done / $duration) * 100);
         }
         
         $this->cpeLogger->log_out(
@@ -531,7 +531,7 @@ 
         }
         
         $preset     = $output_wanted->{"preset"};
-        $presetPath = __DIR__ . '/../../../presets/';
+        $presetPath = __DIR__.'/../../../presets/';
 
         if (!($presetContent = file_get_contents($presetPath.$preset.".json"))) {
             throw new CpeSdk\CpeException("Can't open preset file !",
@@ -555,7 +555,7 @@ 
         }
 
         $preset     = $output->{"preset"};
-        $presetPath = __DIR__ . '/../../../presets/';
+        $presetPath = __DIR__.'/../../../presets/';
         
         if (!($files = scandir($presetPath))) {
             throw new CpeSdk\CpeException("Unable to open preset directory '$presetPath' !",
@@ -611,22 +611,22 @@ 
         }
 
         $analyse = [
-            'duration' => isset($metadata->format->duration) ? (float)$metadata->format->duration : 0,
+            'duration' => isset($metadata->format->duration) ? (float) $metadata->format->duration : 0,
             'video' => empty($videoStreams) ? null : [
                 'codec' => $videoStreams->codec_name,
                 'color' => $videoStreams->color_space,
-                'resolution' => $videoStreams->width . 'x' . $videoStreams->height,
+                'resolution' => $videoStreams->width.'x'.$videoStreams->height,
                 'sar' => $videoStreams->sample_aspect_ratio,
                 'dar' => $videoStreams->display_aspect_ratio,
                 'framerate' => $videoStreams->r_frame_rate,
-                'bitrate' => isset($videoStreams->bit_rate) ? (int)$videoStreams->bit_rate : null
+                'bitrate' => isset($videoStreams->bit_rate) ? (int) $videoStreams->bit_rate : null
             ],
             'audio' => empty($audioStreams) ? null : [
                 'codec' => $audioStreams->codec_name,
                 'frequency' => $audioStreams->sample_rate,
-                'channels' => (int)$audioStreams->channels,
+                'channels' => (int) $audioStreams->channels,
                 'depth' => $audioStreams->bits_per_sample,
-                'bitrate' => (int)$audioStreams->bit_rate
+                'bitrate' => (int) $audioStreams->bit_rate
             ]
         ];
 

src/activities/TranscodeAssetActivity.php

Braces +12 added lines, -8 removed lines

@@ -67,8 +67,9 @@ 
 
             # If we have metadata, we expect the output of ffprobe
             $metadata = null;
-            if (isset($this->input->{'input_asset_metadata'})) 
-                $metadata = $this->input->{'input_asset_metadata'};
+            if (isset($this->input->{'input_asset_metadata'})) {
+                            $metadata = $this->input->{'input_asset_metadata'};
+            }
                 
             // Perform transcoding
             $result = $videoTranscoder->transcode_asset(
@@ -90,8 +91,9 @@ 
 
             # If we have metadata, we expect the output of ffprobe
             $metadata = null;
-            if (isset($this->input->{'input_asset_metadata'})) 
-                $metadata = $this->input->{'input_asset_metadata'};
+            if (isset($this->input->{'input_asset_metadata'})) {
+                            $metadata = $this->input->{'input_asset_metadata'};
+            }
             
             // Perform transcoding
             $result = $imageTranscoder->transcode_asset(
@@ -194,16 +196,18 @@ 
         
         if (!file_exists($this->pathToOutputFiles)) 
         {
-            if ($this->debug)
-                $this->cpeLogger->log_out("INFO", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("INFO", basename(__FILE__), 
                     "Creating TMP output folder '".$this->pathToOutputFiles."'",
                     $this->activityLogKey);
+            }
 
-            if (!mkdir($this->pathToOutputFiles, 0750, true))
-                throw new CpeSdk\CpeException(
+            if (!mkdir($this->pathToOutputFiles, 0750, true)) {
+                            throw new CpeSdk\CpeException(
                     "Unable to create temporary folder '$this->pathToOutputFiles' !",
                     self::TMP_FOLDER_FAIL
                 );
+            }
         }
     }
     

src/activities/transcoders/BasicTranscoder.php

Braces +4 added lines, -3 removed lines

@@ -48,7 +48,9 @@ 
 
     public function is_dir_empty($dir)
     {
-        if (!is_readable($dir)) return null; 
+        if (!is_readable($dir)) {
+            return null;
+        }
         $handle = opendir($dir);
         while (false !== ($entry = readdir($handle))) {
             if ($entry !== '.' && $entry !== '..') { 
@@ -83,8 +85,7 @@ 
                 false, false, 
                 false, 1
             );
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 

src/activities/transcoders/ImageTranscoder.php

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
             $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
-                "Input Video metadata: " . print_r($metadata, true),
+                "Input Video metadata: ".print_r($metadata, true),
                 $this->activityLogKey
             );
 
@@ -117,7 +117,7 @@ 
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
-                "Execution of command '".$convertCmd."' failed: " . print_r($metadata, true). ". ".$e->getMessage(),
+                "Execution of command '".$convertCmd."' failed: ".print_r($metadata, true).". ".$e->getMessage(),
                 $this->activityLogKey
             );
             return false;
@@ -161,7 +161,7 @@ 
         
         // Append output filename to path
         $pathToOutputFiles .=
-            "/" . $outputWanted->{'output_file_info'}['basename'];
+            "/".$outputWanted->{'output_file_info'}['basename'];
         
         $convertCmd = "convert $convertArgs $pathToOutputFiles";
 
@@ -184,7 +184,7 @@ 
             $pathToInputFile, $convertCmd);
 
         // Append output filename to path
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
         // Replace ${output_file} by output filename and path to local disk
         $convertCmd = preg_replace('/\$\{output_file\}/',
             $pathToOutputFiles, $convertCmd);

Braces +5 added lines, -6 removed lines

@@ -40,13 +40,14 @@ 
             $this->activityLogKey
         );
 
-        if ($metadata)
-            $this->cpeLogger->log_out(
+        if ($metadata) {
+                    $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
                 "Input Video metadata: " . print_r($metadata, true),
                 $this->activityLogKey
             );
+        }
 
         try {
             $convertCmd = "";
@@ -67,8 +68,7 @@ 
                     $metadata, 
                     $outputWanted
                 );
-            }
-            else {
+            } else {
                 $convertCmd = $this->craft_convert_cmd(
                     $tmpPathInput,
                     $pathToInputFile,
@@ -112,8 +112,7 @@ 
             // FFProbe the output file and return its information
             $output_info =
                 $this->get_asset_info($pathToOutputFiles."/".$outputWanted->{'output_file_info'}['basename']);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 

Doc Comments +6 added lines

@@ -40,6 +40,12 @@
     // $metadata should contain the ffprobe video stream array.
 
     // Start FFmpeg for output transcoding
+
+    /**
+     * @param string $tmpPathInput
+     * @param null|string $pathToInputFile
+     * @param string $pathToOutputFiles
+     */
     public function transcode_asset(
         $tmpPathInput,
         $pathToInputFile,