sportarchive / CloudTranscode

src/activities/transcoders/ImageTranscoder.php

Doc Comments +6 added lines

@@ -21,6 +21,12 @@
     // $metadata should contain the ffprobe video stream array.
 
     // Start FFmpeg for output transcoding
+
+    /**
+     * @param string $tmpPathInput
+     * @param null|string $pathToInputFile
+     * @param string $pathToOutputFiles
+     */
     public function transcode_asset(
         $tmpPathInput,
         $pathToInputFile, 

Spacing +4 added lines, -4 removed lines

@@ -44,7 +44,7 @@ 
             $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
-                "Input Video metadata: " . print_r($metadata, true),
+                "Input Video metadata: ".print_r($metadata, true),
                 $this->activityLogKey
             );
 
@@ -117,7 +117,7 @@ 
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
-                "Execution of command '".$convertCmd."' failed: " . print_r($metadata, true). ". ".$e->getMessage(),
+                "Execution of command '".$convertCmd."' failed: ".print_r($metadata, true).". ".$e->getMessage(),
                 $this->activityLogKey
             );
             return false;
@@ -161,7 +161,7 @@ 
         
         // Append output filename to path
         $pathToOutputFiles .=
-            "/" . $outputWanted->{'output_file_info'}['basename'];
+            "/".$outputWanted->{'output_file_info'}['basename'];
         
         $convertCmd = "convert $convertArgs $pathToOutputFiles";
 
@@ -184,7 +184,7 @@ 
             $pathToInputFile, $convertCmd);
 
         // Append output filename to path
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
         // Replace ${output_file} by output filename and path to local disk
         $convertCmd = preg_replace('/\$\{output_file\}/',
             $pathToOutputFiles, $convertCmd);

Braces +5 added lines, -6 removed lines

@@ -40,13 +40,14 @@ 
             $this->activityLogKey
         );
 
-        if ($metadata)
-            $this->cpeLogger->log_out(
+        if ($metadata) {
+                    $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
                 "Input Video metadata: " . print_r($metadata, true),
                 $this->activityLogKey
             );
+        }
 
         try {
             $convertCmd = "";
@@ -67,8 +68,7 @@ 
                     $metadata, 
                     $outputWanted
                 );
-            }
-            else {
+            } else {
                 $convertCmd = $this->craft_convert_cmd(
                     $tmpPathInput,
                     $pathToInputFile,
@@ -112,8 +112,7 @@ 
             // FFProbe the output file and return its information
             $output_info =
                 $this->get_asset_info($pathToOutputFiles."/".$outputWanted->{'output_file_info'}['basename']);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 

src/activities/transcoders/VideoTranscoder.php

Doc Comments +6 added lines

@@ -40,6 +40,12 @@
     // $metadata should contain the ffprobe video stream array.
 
     // Start FFmpeg for output transcoding
+
+    /**
+     * @param string $tmpPathInput
+     * @param null|string $pathToInputFile
+     * @param string $pathToOutputFiles
+     */
     public function transcode_asset(
         $tmpPathInput,
         $pathToInputFile, 

Braces +7 added lines, -10 removed lines

@@ -65,13 +65,14 @@ 
             $this->activityLogKey
         );
         
-        if ($metadata)
-            $this->cpeLogger->log_out(
+        if ($metadata) {
+                    $this->cpeLogger->log_out(
                 "INFO", 
                 basename(__FILE__), 
                 "Input Video metadata: " . print_r($metadata, true),
                 $this->activityLogKey
             );
+        }
         
         try {
             $ffmpegCmd = "";
@@ -138,8 +139,7 @@ 
             // FFProbe the output file and return its information
             $output_info =
                 $this->get_asset_info($pathToOutputFiles."/".$outputWanted->{'output_file_info'}['basename']);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
@@ -289,8 +289,7 @@ 
             $time = gmdate("H:i:s", $snapshot_sec) . ".000";
             $pathToOutputFiles .= "/" . $outputFileInfo['basename'];
             $frameOptions = " -ss $time -vframes 1";
-        }
-        else if ($outputWanted->{'mode'} == 'intervals')
+        } else if ($outputWanted->{'mode'} == 'intervals')
         {
             $intervals = self::INTERVALS_DEFAULT;
             if (isset($outputWanted->{'intervals'}) &&
@@ -343,8 +342,7 @@ 
                 array(1 => array("pipe", "w"), 2 => array("pipe", "w")),
                 false, false, 
                 false, 1);
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 
@@ -604,8 +602,7 @@ 
         foreach ($metadata->streams as $key => $value) {
             if ($value->codec_type === 'video') {
                 $videoStreams = $value;
-            }
-            else if ($value->codec_type === 'audio') {
+            } else if ($value->codec_type === 'audio') {
                 $audioStreams = $value;
             }
         }

src/activities/TranscodeAssetActivity.php

Braces +12 added lines, -8 removed lines

@@ -67,8 +67,9 @@ 
 
             # If we have metadata, we expect the output of ffprobe
             $metadata = null;
-            if (isset($this->input->{'input_asset_metadata'})) 
-                $metadata = $this->input->{'input_asset_metadata'};
+            if (isset($this->input->{'input_asset_metadata'})) {
+                            $metadata = $this->input->{'input_asset_metadata'};
+            }
                 
             // Perform transcoding
             $result = $videoTranscoder->transcode_asset(
@@ -90,8 +91,9 @@ 
 
             # If we have metadata, we expect the output of ffprobe
             $metadata = null;
-            if (isset($this->input->{'input_asset_metadata'})) 
-                $metadata = $this->input->{'input_asset_metadata'};
+            if (isset($this->input->{'input_asset_metadata'})) {
+                            $metadata = $this->input->{'input_asset_metadata'};
+            }
             
             // Perform transcoding
             $result = $imageTranscoder->transcode_asset(
@@ -194,16 +196,18 @@ 
         
         if (!file_exists($this->pathToOutputFiles)) 
         {
-            if ($this->debug)
-                $this->cpeLogger->log_out("INFO", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("INFO", basename(__FILE__), 
                     "Creating TMP output folder '".$this->pathToOutputFiles."'",
                     $this->activityLogKey);
+            }
 
-            if (!mkdir($this->pathToOutputFiles, 0750, true))
-                throw new CpeSdk\CpeException(
+            if (!mkdir($this->pathToOutputFiles, 0750, true)) {
+                            throw new CpeSdk\CpeException(
                     "Unable to create temporary folder '$this->pathToOutputFiles' !",
                     self::TMP_FOLDER_FAIL
                 );
+            }
         }
     }
     

src/activities/transcoders/BasicTranscoder.php

Braces +4 added lines, -3 removed lines

@@ -48,7 +48,9 @@ 
 
     public function is_dir_empty($dir)
     {
-        if (!is_readable($dir)) return null; 
+        if (!is_readable($dir)) {
+            return null;
+        }
         $handle = opendir($dir);
         while (false !== ($entry = readdir($handle))) {
             if ($entry !== '.' && $entry !== '..') { 
@@ -83,8 +85,7 @@ 
                 false, false, 
                 false, 1
             );
-        }
-        catch (\Exception $e) {
+        } catch (\Exception $e) {
             $this->cpeLogger->log_out(
                 "ERROR", 
                 basename(__FILE__), 

src/activities/BasicActivity.php

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
         else if (isset($this->input->{'input_asset'}->{'http'}))
         {
             // Pad HTTP input so it is cached in case of full encodes
-            $this->pathToInputFile = 'cache:' . $this->input->{'input_asset'}->{'http'};
+            $this->pathToInputFile = 'cache:'.$this->input->{'input_asset'}->{'http'};
         }
     }
     

Braces +10 added lines, -8 removed lines

@@ -74,22 +74,25 @@ 
         
         $inputFileInfo = null;
         // Create TMP storage to store input file to transcode
-        if (isset($this->input->{'input_asset'}->{'file'}))
-            $inputFileInfo = pathinfo($this->input->{'input_asset'}->{'file'});
+        if (isset($this->input->{'input_asset'}->{'file'})) {
+                    $inputFileInfo = pathinfo($this->input->{'input_asset'}->{'file'});
+        }
         
         // Create the tmp folder if doesn't exist
         if (!file_exists($this->tmpPathInput)) 
         {
-            if ($this->debug)
-                $this->cpeLogger->log_out("INFO", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("INFO", basename(__FILE__), 
                     "Creating TMP input folder '".$this->tmpPathInput."'",
                     $this->activityLogKey);
+            }
             
-            if (!mkdir($this->tmpPathInput, 0750, true))
-                throw new CpeSdk\CpeException(
+            if (!mkdir($this->tmpPathInput, 0750, true)) {
+                            throw new CpeSdk\CpeException(
                     "Unable to create temporary folder '$this->tmpPathInput' !",
                     self::TMP_FOLDER_FAIL
                 );
+            }
         }
             
         $this->pathToInputFile = null;
@@ -105,8 +108,7 @@ 
                     $this->input->{'input_asset'}->{'file'},
                     $saveFileTo
                 );
-        }
-        else if (isset($this->input->{'input_asset'}->{'http'}))
+        } else if (isset($this->input->{'input_asset'}->{'http'}))
         {
             // Pad HTTP input so it is cached in case of full encodes
             $this->pathToInputFile = 'cache:' . $this->input->{'input_asset'}->{'http'};