Completed
Push — master ( 378b85...99ade0 )
by Nicolas
02:36
created
src/activities/transcoders/VideoTranscoder.php 3 patches
Doc Comments   +10 added lines patch added patch discarded remove patch
@@ -40,6 +40,12 @@  discard block
 block discarded – undo
40 40
      **********************/
41 41
 
42 42
     // Start FFmpeg for output transcoding
43
+
44
+    /**
45
+     * @param string $tmpPathInput
46
+     * @param null|string $pathToInputFile
47
+     * @param string $pathToOutputFiles
48
+     */
43 49
     public function transcode_asset(
44 50
         $tmpPathInput,
45 51
         $pathToInputFile, 
@@ -594,6 +600,10 @@  discard block
 block discarded – undo
594 600
      */
595 601
 
596 602
     // Execute FFMpeg to get video information
603
+
604
+    /**
605
+     * @param string|null $pathToInputFile
606
+     */
597 607
     public function get_asset_info($pathToInputFile)
598 608
     {
599 609
         $pathToInputFile = escapeshellarg($pathToInputFile);
Please login to merge, or discard this patch.
Spacing   +24 added lines, -24 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
  * We use ffprobe, ffmpeg and convert to analyse, transcode and manipulate videos and images (watermark)
8 8
  */
9 9
 
10
-require_once __DIR__ . '/BasicTranscoder.php';
10
+require_once __DIR__.'/BasicTranscoder.php';
11 11
 
12 12
 use SA\CpeSdk;
13 13
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
             $this->cpeLogger->log_out(
106 106
                 "INFO", 
107 107
                 basename(__FILE__), 
108
-                "Input Video metadata: " . print_r($metadata, true),
108
+                "Input Video metadata: ".print_r($metadata, true),
109 109
                 $this->activityLogKey
110 110
             );
111 111
         
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
             $this->cpeLogger->log_out(
143 143
                 "ERROR", 
144 144
                 basename(__FILE__), 
145
-                "Execution of command '".$ffmpegCmd."' failed: " . print_r($metadata, true). ". ".$e->getMessage(),
145
+                "Execution of command '".$ffmpegCmd."' failed: ".print_r($metadata, true).". ".$e->getMessage(),
146 146
                 $this->activityLogKey
147 147
             );
148 148
             return false;
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
         }
186 186
         
187 187
         // Append output filename to path
188
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
188
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
189 189
         // Replace ${output_file} by output filename and path to local disk
190 190
         $ffmpegCmd = preg_replace('/\$\{output_file\}/', $pathToOutputFiles, $ffmpegCmd);
191 191
 
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
         }
246 246
         
247 247
         // Create FFMpeg arguments
248
-        $ffmpegArgs =  " -i $pathToInputFile -y -threads 0";
248
+        $ffmpegArgs = " -i $pathToInputFile -y -threads 0";
249 249
         $ffmpegArgs .= " -s $size";
250 250
         $ffmpegArgs .= " -vcodec $videoCodec";
251 251
         $ffmpegArgs .= " -acodec $audioCodec";
@@ -256,9 +256,9 @@  discard block
 block discarded – undo
256 256
         $ffmpegArgs .= " $watermarkOptions";
257 257
         
258 258
         // Append output filename to path
259
-        $pathToOutputFiles .= "/" . $outputWanted->{'output_file_info'}['basename'];
259
+        $pathToOutputFiles .= "/".$outputWanted->{'output_file_info'}['basename'];
260 260
         // Final command
261
-        $ffmpegCmd  = "ffmpeg $ffmpegArgs $pathToOutputFiles";
261
+        $ffmpegCmd = "ffmpeg $ffmpegArgs $pathToOutputFiles";
262 262
             
263 263
         return ($ffmpegCmd);
264 264
     }
@@ -285,8 +285,8 @@  discard block
 block discarded – undo
285 285
                 $snapshot_sec = $outputWanted->{'snapshot_sec'};
286 286
             }
287 287
                 
288
-            $time = gmdate("H:i:s", $snapshot_sec) . ".000";
289
-            $pathToOutputFiles .= "/" . $outputFileInfo['basename'];
288
+            $time = gmdate("H:i:s", $snapshot_sec).".000";
289
+            $pathToOutputFiles .= "/".$outputFileInfo['basename'];
290 290
             $frameOptions = " -ss $time -vframes 1";
291 291
         }
292 292
         else if ($outputWanted->{'mode'} == 'intervals')
@@ -297,14 +297,14 @@  discard block
 block discarded – undo
297 297
                 $intervals = $outputWanted->{'intervals'};
298 298
             }
299 299
             
300
-            $pathToOutputFiles .= "/" . $outputFileInfo['filename'] . "%06d." 
300
+            $pathToOutputFiles .= "/".$outputFileInfo['filename']."%06d." 
301 301
                 . $outputFileInfo['extension'];
302 302
             $frameOptions = " -vf fps=fps=1/$intervals";
303 303
         }
304 304
 
305 305
         // Create FFMpeg arguments
306
-        $ffmpegArgs  =  " -i $pathToInputFile -y -threads 0";
307
-        $ffmpegArgs .= " -vf scale=" . $outputWanted->{'size'};
306
+        $ffmpegArgs  = " -i $pathToInputFile -y -threads 0";
307
+        $ffmpegArgs .= " -vf scale=".$outputWanted->{'size'};
308 308
         $ffmpegArgs .= " $frameOptions -f image2 -q:v 8";
309 309
 
310 310
         // Final command
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
             $this->activityLogKey);
336 336
 
337 337
         // Transform watermark for opacity
338
-        $convertCmd = "convert $watermarkPath -alpha on -channel A -evaluate Multiply " . $watermarkOptions->{'opacity'} . " +channel $newWatermarkPath";
338
+        $convertCmd = "convert $watermarkPath -alpha on -channel A -evaluate Multiply ".$watermarkOptions->{'opacity'}." +channel $newWatermarkPath";
339 339
 
340 340
         try {
341 341
             $out = $this->executer->execute($convertCmd, 1, 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         // Format options for FFMpeg
365 365
         $size      = $watermarkOptions->{'size'};
366 366
         $positions = $this->get_watermark_position($watermarkOptions);
367
-        $formattedOptions = "-vf \"movie=$newWatermarkPath, scale=$size [wm]; [in][wm] overlay=" . $positions['x'] . ':' . $positions['y'] . " [out]\"";
367
+        $formattedOptions = "-vf \"movie=$newWatermarkPath, scale=$size [wm]; [in][wm] overlay=".$positions['x'].':'.$positions['y']." [out]\"";
368 368
         
369 369
         return ($formattedOptions);
370 370
     }
@@ -381,10 +381,10 @@  discard block
 block discarded – undo
381 381
             $positions['y'] = $watermarkOptions->{'y'};
382 382
         }
383 383
         if ($watermarkOptions->{'x'} < 0) {
384
-            $positions['x'] = 'main_w-overlay_w' . $watermarkOptions->{'x'};
384
+            $positions['x'] = 'main_w-overlay_w'.$watermarkOptions->{'x'};
385 385
         }
386 386
         if ($watermarkOptions->{'y'} < 0) {
387
-            $positions['y'] = 'main_h-overlay_h' . $watermarkOptions->{'y'};
387
+            $positions['y'] = 'main_h-overlay_h'.$watermarkOptions->{'y'};
388 388
         }
389 389
 
390 390
         return ($positions);
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
         // # finally, progress is easy
494 494
         $progress = 0;
495 495
         if ($done) {
496
-            $progress = round(($done/$duration)*100);
496
+            $progress = round(($done / $duration) * 100);
497 497
         }
498 498
         
499 499
         $this->cpeLogger->log_out(
@@ -528,7 +528,7 @@  discard block
 block discarded – undo
528 528
         }
529 529
         
530 530
         $preset     = $output_wanted->{"preset"};
531
-        $presetPath = __DIR__ . '/../../../presets/';
531
+        $presetPath = __DIR__.'/../../../presets/';
532 532
 
533 533
         if (!($presetContent = file_get_contents($presetPath.$preset.".json"))) {
534 534
             throw new CpeSdk\CpeException("Can't open preset file !",
@@ -552,7 +552,7 @@  discard block
 block discarded – undo
552 552
         }
553 553
 
554 554
         $preset     = $output->{"preset"};
555
-        $presetPath = __DIR__ . '/../../../presets/';
555
+        $presetPath = __DIR__.'/../../../presets/';
556 556
         
557 557
         if (!($files = scandir($presetPath))) {
558 558
             throw new CpeSdk\CpeException("Unable to open preset directory '$presetPath' !",
@@ -608,22 +608,22 @@  discard block
 block discarded – undo
608 608
         }
609 609
 
610 610
         $analyse = [
611
-            'duration' => isset($metadata->format->duration) ? (float)$metadata->format->duration : 0,
611
+            'duration' => isset($metadata->format->duration) ? (float) $metadata->format->duration : 0,
612 612
             'video' => empty($videoStreams) ? null : [
613 613
                 'codec' => $videoStreams->codec_name,
614 614
                 'color' => $videoStreams->color_space,
615
-                'resolution' => $videoStreams->width . 'x' . $videoStreams->height,
615
+                'resolution' => $videoStreams->width.'x'.$videoStreams->height,
616 616
                 'sar' => $videoStreams->sample_aspect_ratio,
617 617
                 'dar' => $videoStreams->display_aspect_ratio,
618 618
                 'framerate' => $videoStreams->r_frame_rate,
619
-                'bitrate' => isset($videoStreams->bit_rate) ? (int)$videoStreams->bit_rate : null
619
+                'bitrate' => isset($videoStreams->bit_rate) ? (int) $videoStreams->bit_rate : null
620 620
             ],
621 621
             'audio' => empty($audioStreams) ? null : [
622 622
                 'codec' => $audioStreams->codec_name,
623 623
                 'frequency' => $audioStreams->sample_rate,
624
-                'channels' => (int)$audioStreams->channels,
624
+                'channels' => (int) $audioStreams->channels,
625 625
                 'depth' => $audioStreams->bits_per_sample,
626
-                'bitrate' => (int)$audioStreams->bit_rate
626
+                'bitrate' => (int) $audioStreams->bit_rate
627 627
             ]
628 628
         ];
629 629
 
Please login to merge, or discard this patch.
Braces   +11 added lines, -14 removed lines patch added patch discarded remove patch
@@ -49,11 +49,12 @@  discard block
 block discarded – undo
49 49
         $metadata = null, 
50 50
         $outputWanted)
51 51
     {
52
-        if (!$metadata)
53
-            throw new CpeSdk\CpeException(
52
+        if (!$metadata) {
53
+                    throw new CpeSdk\CpeException(
54 54
                 "NO Input Video metadata! We can't transcode an asset without probing it first. Use ValidateAsset activity to probe it and pass a 'metadata' field containing the input metadata to this TranscodeAsset activity.",
55 55
                 self::TRANSCODE_FAIL
56 56
             );
57
+        }
57 58
         // Extract an sanitize metadata
58 59
         $metadata = $this->_extractFileInfo($metadata);
59 60
 
@@ -101,13 +102,14 @@  discard block
 block discarded – undo
101 102
             $this->activityLogKey
102 103
         );
103 104
         
104
-        if ($metadata)
105
-            $this->cpeLogger->log_out(
105
+        if ($metadata) {
106
+                    $this->cpeLogger->log_out(
106 107
                 "INFO", 
107 108
                 basename(__FILE__), 
108 109
                 "Input Video metadata: " . print_r($metadata, true),
109 110
                 $this->activityLogKey
110 111
             );
112
+        }
111 113
         
112 114
         try {
113 115
             // Use executer to start FFMpeg command
@@ -137,8 +139,7 @@  discard block
 block discarded – undo
137 139
             // FFProbe the output file and return its information
138 140
             $output_info =
139 141
                 $this->get_asset_info($pathToOutputFiles."/".$outputWanted->{'output_file_info'}['basename']);
140
-        }
141
-        catch (\Exception $e) {
142
+        } catch (\Exception $e) {
142 143
             $this->cpeLogger->log_out(
143 144
                 "ERROR", 
144 145
                 basename(__FILE__), 
@@ -288,8 +289,7 @@  discard block
 block discarded – undo
288 289
             $time = gmdate("H:i:s", $snapshot_sec) . ".000";
289 290
             $pathToOutputFiles .= "/" . $outputFileInfo['basename'];
290 291
             $frameOptions = " -ss $time -vframes 1";
291
-        }
292
-        else if ($outputWanted->{'mode'} == 'intervals')
292
+        } else if ($outputWanted->{'mode'} == 'intervals')
293 293
         {
294 294
             $intervals = self::INTERVALS_DEFAULT;
295 295
             if (isset($outputWanted->{'intervals'}) &&
@@ -342,8 +342,7 @@  discard block
 block discarded – undo
342 342
                 array(1 => array("pipe", "w"), 2 => array("pipe", "w")),
343 343
                 false, false, 
344 344
                 false, 1);
345
-        }
346
-        catch (\Exception $e) {
345
+        } catch (\Exception $e) {
347 346
             $this->cpeLogger->log_out(
348 347
                 "ERROR", 
349 348
                 basename(__FILE__), 
@@ -601,8 +600,7 @@  discard block
 block discarded – undo
601 600
         foreach ($metadata->streams as $key => $value) {
602 601
             if ($value->codec_type === 'video') {
603 602
                 $videoStreams = $value;
604
-            }
605
-            else if ($value->codec_type === 'audio') {
603
+            } else if ($value->codec_type === 'audio') {
606 604
                 $audioStreams = $value;
607 605
             }
608 606
         }
@@ -653,8 +651,7 @@  discard block
 block discarded – undo
653 651
                 false, false, 
654 652
                 false, 1
655 653
             );
656
-        }
657
-        catch (\Exception $e) {
654
+        } catch (\Exception $e) {
658 655
             $this->cpeLogger->log_out(
659 656
                 "ERROR", 
660 657
                 basename(__FILE__), 
Please login to merge, or discard this patch.
src/activities/BasicActivity.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             isset($this->input->{'input_asset'}->{'file'}))
103 103
         {
104 104
             // Make pre-signed URL so ffmpeg has access to file
105
-            $this->pathToInputFile = 'cache:' .
105
+            $this->pathToInputFile = 'cache:'.
106 106
                 $this->s3->getCommand('GetObject', [
107 107
                     'Bucket' => $this->input->{'input_asset'}->{'bucket'},
108 108
                     'Key' => $this->input->{'input_asset'}->{'file'}
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
         else if ($this->input->{'input_asset'}->{'http'})
112 112
         {
113 113
             // Pad HTTP input so it is cached in case of full encodes
114
-            $this->pathToInputFile = 'cache:' . $this->input->{'input_asset'}->{'http'};
114
+            $this->pathToInputFile = 'cache:'.$this->input->{'input_asset'}->{'http'};
115 115
         }
116 116
     }
117 117
     
Please login to merge, or discard this patch.
Braces   +10 added lines, -8 removed lines patch added patch discarded remove patch
@@ -79,22 +79,25 @@  discard block
 block discarded – undo
79 79
         
80 80
         $inputFileInfo = null;
81 81
         // Create TMP storage to store input file to transcode
82
-        if (isset($this->input->{'input_asset'}->{'file'}))
83
-            $inputFileInfo = pathinfo($this->input->{'input_asset'}->{'file'});
82
+        if (isset($this->input->{'input_asset'}->{'file'})) {
83
+                    $inputFileInfo = pathinfo($this->input->{'input_asset'}->{'file'});
84
+        }
84 85
         
85 86
         // Create the tmp folder if doesn't exist
86 87
         if (!file_exists($this->tmpPathInput)) 
87 88
         {
88
-            if ($this->debug)
89
-                $this->cpeLogger->log_out("INFO", basename(__FILE__), 
89
+            if ($this->debug) {
90
+                            $this->cpeLogger->log_out("INFO", basename(__FILE__), 
90 91
                     "Creating TMP input folder '".$this->tmpPathInput."'",
91 92
                     $this->activityLogKey);
93
+            }
92 94
             
93
-            if (!mkdir($this->tmpPathInput, 0750, true))
94
-                throw new CpeSdk\CpeException(
95
+            if (!mkdir($this->tmpPathInput, 0750, true)) {
96
+                            throw new CpeSdk\CpeException(
95 97
                     "Unable to create temporary folder '$this->tmpPathInput' !",
96 98
                     self::TMP_FOLDER_FAIL
97 99
                 );
100
+            }
98 101
         }
99 102
             
100 103
         $this->pathToInputFile = null;
@@ -107,8 +110,7 @@  discard block
 block discarded – undo
107 110
                     'Bucket' => $this->input->{'input_asset'}->{'bucket'},
108 111
                     'Key' => $this->input->{'input_asset'}->{'file'}
109 112
                 ])->createPresignedUrl('+1 day');
110
-        }
111
-        else if ($this->input->{'input_asset'}->{'http'})
113
+        } else if ($this->input->{'input_asset'}->{'http'})
112 114
         {
113 115
             // Pad HTTP input so it is cached in case of full encodes
114 116
             $this->pathToInputFile = 'cache:' . $this->input->{'input_asset'}->{'http'};
Please login to merge, or discard this patch.
src/activities/TranscodeAssetActivity.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -167,16 +167,18 @@
 block discarded – undo
167 167
         
168 168
         if (!file_exists($this->pathToOutputFiles)) 
169 169
         {
170
-            if ($this->debug)
171
-                $this->cpeLogger->log_out("INFO", basename(__FILE__), 
170
+            if ($this->debug) {
171
+                            $this->cpeLogger->log_out("INFO", basename(__FILE__), 
172 172
                     "Creating TMP output folder '".$this->pathToOutputFiles."'",
173 173
                     $this->activityLogKey);
174
+            }
174 175
 
175
-            if (!mkdir($this->pathToOutputFiles, 0750, true))
176
-                throw new CpeSdk\CpeException(
176
+            if (!mkdir($this->pathToOutputFiles, 0750, true)) {
177
+                            throw new CpeSdk\CpeException(
177 178
                     "Unable to create temporary folder '$this->pathToOutputFiles' !",
178 179
                     self::TMP_FOLDER_FAIL
179 180
                 );
181
+            }
180 182
         }
181 183
     }
182 184
     
Please login to merge, or discard this patch.
src/activities/ValidateAssetActivity.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
         $tmpFile = tempname(sys_get_temp_dir(), 'ct');
49 49
         file_put_contents($tmpFile, $obj['Body']);
50 50
         $mime = trim((new CommandExecuter($this->cpeLogger))->execute(
51
-            'file -b --mime-type ' . escapeshellarg($tmpFile))['out']);
51
+            'file -b --mime-type '.escapeshellarg($tmpFile))['out']);
52 52
         $type = substr($mime, 0, strpos($mime, '/'));
53 53
 
54 54
         $this->cpeLogger->log_out(
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -8,9 +8,6 @@
 block discarded – undo
8 8
 
9 9
 require_once __DIR__.'/BasicActivity.php';
10 10
 
11
-use Guzzle\Http\EntityBody;
12
-use SA\CpeSdk;
13
-
14 11
 class ValidateAssetActivity extends BasicActivity
15 12
 {
16 13
     /** @var \finfo */
Please login to merge, or discard this patch.
src/activities/transcoders/AudioTranscoder.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-require_once __DIR__ . '/BasicTranscoder.php';
3
+require_once __DIR__.'/BasicTranscoder.php';
4 4
 
5 5
 class AudioTranscoder extends BasicTranscoder
6 6
 {
Please login to merge, or discard this patch.
src/activities/transcoders/BasicTranscoder.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,9 @@
 block discarded – undo
45 45
 
46 46
     public function is_dir_empty($dir)
47 47
     {
48
-        if (!is_readable($dir)) return null; 
48
+        if (!is_readable($dir)) {
49
+            return null;
50
+        }
49 51
         $handle = opendir($dir);
50 52
         while (false !== ($entry = readdir($handle))) {
51 53
             if ($entry !== '.' && $entry !== '..') { 
Please login to merge, or discard this patch.
src/scripts/getFromS3.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -4,13 +4,13 @@  discard block
 block discarded – undo
4 4
  * Script used to get a file in AWS S3
5 5
  **/
6 6
 
7
-require __DIR__ . "/../../vendor/autoload.php";
7
+require __DIR__."/../../vendor/autoload.php";
8 8
 
9 9
 use Aws\S3\S3Client;
10 10
 
11 11
 function usage()
12 12
 {
13
-    echo("Usage: php ". basename(__FILE__) . " [-h] [--force] --bucket <s3 bucket> --file <filename> --to <filepath>\n");
13
+    echo("Usage: php ".basename(__FILE__)." [-h] [--force] --bucket <s3 bucket> --file <filename> --to <filepath>\n");
14 14
     echo("--help, -h: Print this help\n");
15 15
     echo("--bucket <s3 bucket>: Name of the S3 bucket\n");
16 16
     echo("--file <filename>: Name of the file in the S3 bucket\n");
@@ -41,8 +41,8 @@  discard block
 block discarded – undo
41 41
     file_exists($options['to']) &&
42 42
     filesize($options['to']))
43 43
 {
44
-    print json_encode([ "status" => "SUCCESS",
45
-            "msg" => "[".__FILE__."] Using local copy: '" . $options['to']  . "'" ]);
44
+    print json_encode(["status" => "SUCCESS",
45
+            "msg" => "[".__FILE__."] Using local copy: '".$options['to']."'"]);
46 46
     exit(0);
47 47
 }
48 48
 
@@ -58,14 +58,14 @@  discard block
 block discarded – undo
58 58
         ));
59 59
 
60 60
     // Print JSON error output
61
-    print json_encode([ "status" => "SUCCESS",
62
-            "msg" => "[".__FILE__."] Download '" . $options['bucket'] . "/" . $options['file'] . "' successful !" ]);
61
+    print json_encode(["status" => "SUCCESS",
62
+            "msg" => "[".__FILE__."] Download '".$options['bucket']."/".$options['file']."' successful !"]);
63 63
 } 
64 64
 catch (Exception $e) {
65
-    $err = "Unable to get '" . $options['bucket'] . "/" . $options['file'] . "' file from S3 ! " . $e->getMessage();
65
+    $err = "Unable to get '".$options['bucket']."/".$options['file']."' file from S3 ! ".$e->getMessage();
66 66
     // Print JSON error output
67
-    print json_encode([ "status" => "ERROR",
68
-            "msg" => "[".__FILE__."] $err" ]);
67
+    print json_encode(["status" => "ERROR",
68
+            "msg" => "[".__FILE__."] $err"]);
69 69
     
70 70
     die("[".__FILE__."] $err");
71 71
 }
Please login to merge, or discard this patch.
Braces   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -22,8 +22,9 @@  discard block
 block discarded – undo
22 22
 function check_input_parameters($options)
23 23
 {
24 24
     if (!count($options) || isset($options['h']) ||
25
-        isset($options['help']))
26
-        usage();
25
+        isset($options['help'])) {
26
+            usage();
27
+    }
27 28
     
28 29
     if (!isset($options['bucket']) || !isset($options['file']) ||
29 30
         !isset($options['to']))
@@ -60,8 +61,7 @@  discard block
 block discarded – undo
60 61
     // Print JSON error output
61 62
     print json_encode([ "status" => "SUCCESS",
62 63
             "msg" => "[".__FILE__."] Download '" . $options['bucket'] . "/" . $options['file'] . "' successful !" ]);
63
-} 
64
-catch (Exception $e) {
64
+} catch (Exception $e) {
65 65
     $err = "Unable to get '" . $options['bucket'] . "/" . $options['file'] . "' file from S3 ! " . $e->getMessage();
66 66
     // Print JSON error output
67 67
     print json_encode([ "status" => "ERROR",
Please login to merge, or discard this patch.
src/scripts/putInS3.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -4,13 +4,13 @@  discard block
 block discarded – undo
4 4
  * Script used to put a file in AWS S3
5 5
  **/
6 6
 
7
-require __DIR__ . "/../../vendor/autoload.php";
7
+require __DIR__."/../../vendor/autoload.php";
8 8
 
9 9
 use Aws\S3\S3Client;
10 10
 
11 11
 function usage()
12 12
 {
13
-    echo("Usage: php ". basename(__FILE__) . " [-h] [--rrs::] [--encrypt::] --bucket <s3 bucket> --file <filename> --from <filepath>\n");
13
+    echo("Usage: php ".basename(__FILE__)." [-h] [--rrs::] [--encrypt::] --bucket <s3 bucket> --file <filename> --from <filepath>\n");
14 14
     echo("--help, -h: Print this help\n");
15 15
     echo("--bucket <s3 bucket>: Name of the S3 bucket\n");
16 16
     echo("--file <filename>: Name of the file to create in bucket. You can override local filename.\n");
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
         usage();
34 34
     }
35 35
 
36
-    $options['bucket'] = rtrim( $options['bucket'], "/");
36
+    $options['bucket'] = rtrim($options['bucket'], "/");
37 37
 }
38 38
 
39 39
 $options = getopt("h", [
@@ -66,15 +66,15 @@  discard block
 block discarded – undo
66 66
     $s3->putObject($params); 
67 67
     
68 68
     // Print JSON error output
69
-    print json_encode([ "status" => "SUCCESS",
70
-            "msg" => "[".__FILE__."] Upload '" . $options['from'] . "' to '" . $options['bucket'] . "/" . $options['file']  . "' successful !" ]);
69
+    print json_encode(["status" => "SUCCESS",
70
+            "msg" => "[".__FILE__."] Upload '".$options['from']."' to '".$options['bucket']."/".$options['file']."' successful !"]);
71 71
 } 
72 72
 catch (Exception $e) {
73
-    $err = "Unable to put file '" . $options['from']  . "' into S3: '" . $options['bucket'] . "/" . $options['file']  . "'! " . $e->getMessage();
73
+    $err = "Unable to put file '".$options['from']."' into S3: '".$options['bucket']."/".$options['file']."'! ".$e->getMessage();
74 74
     
75 75
     // Print JSON error output
76
-    print json_encode([ "status" => "ERROR",
77
-            "msg" => "[".__FILE__."] $err" ]);
76
+    print json_encode(["status" => "ERROR",
77
+            "msg" => "[".__FILE__."] $err"]);
78 78
 
79 79
     die("[".__FILE__."] $err");
80 80
 }
Please login to merge, or discard this patch.
Braces   +10 added lines, -8 removed lines patch added patch discarded remove patch
@@ -23,8 +23,9 @@  discard block
 block discarded – undo
23 23
 function check_input_parameters(&$options)
24 24
 {
25 25
     if (!count($options) || isset($options['h']) ||
26
-        isset($options['help']))
27
-        usage();
26
+        isset($options['help'])) {
27
+            usage();
28
+    }
28 29
     
29 30
     if (!isset($options['bucket']) || !isset($options['file']) ||
30 31
         !isset($options['from']))
@@ -57,10 +58,12 @@  discard block
 block discarded – undo
57 58
     );
58 59
 
59 60
     // StorageClass and Encryption ?
60
-    if (isset($options['rrs']))
61
-        $params['StorageClass'] = 'REDUCED_REDUNDANCY';
62
-    if (isset($options['encrypt']))
63
-        $params['ServerSideEncryption'] = 'AES256';
61
+    if (isset($options['rrs'])) {
62
+            $params['StorageClass'] = 'REDUCED_REDUNDANCY';
63
+    }
64
+    if (isset($options['encrypt'])) {
65
+            $params['ServerSideEncryption'] = 'AES256';
66
+    }
64 67
     
65 68
     // Upload and Save file to S3
66 69
     $s3->putObject($params); 
@@ -68,8 +71,7 @@  discard block
 block discarded – undo
68 71
     // Print JSON error output
69 72
     print json_encode([ "status" => "SUCCESS",
70 73
             "msg" => "[".__FILE__."] Upload '" . $options['from'] . "' to '" . $options['bucket'] . "/" . $options['file']  . "' successful !" ]);
71
-} 
72
-catch (Exception $e) {
74
+} catch (Exception $e) {
73 75
     $err = "Unable to put file '" . $options['from']  . "' into S3: '" . $options['bucket'] . "/" . $options['file']  . "'! " . $e->getMessage();
74 76
     
75 77
     // Print JSON error output
Please login to merge, or discard this patch.
src/utils/CommandExecuter.php 1 patch
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -17,8 +17,9 @@  discard block
 block discarded – undo
17 17
     
18 18
     public function __construct($cpeLogger = null)
19 19
     {
20
-        if (!$cpeLogger)
21
-            $this->cpeLogger = new CpeSdk\CpeLogger(null, 'CommandExecuter');
20
+        if (!$cpeLogger) {
21
+                    $this->cpeLogger = new CpeSdk\CpeLogger(null, 'CommandExecuter');
22
+        }
22 23
         $this->cpeLogger = $cpeLogger;
23 24
     }
24 25
     
@@ -112,10 +113,12 @@  discard block
 block discarded – undo
112 113
         if ($procStatus['exitcode'] > 0)
113 114
         {
114 115
             $this->cpeLogger->log_out("ERROR", basename(__FILE__), "Can't execute: $cmd. Exit Code: ".$procStatus['exitcode']);
115
-            if ($allOut)
116
-                $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDOUT: ".$allOut);
117
-            if ($allOutErr)
118
-                $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDERR: ".$allOutErr);
116
+            if ($allOut) {
117
+                            $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDOUT: ".$allOut);
118
+            }
119
+            if ($allOutErr) {
120
+                            $this->cpeLogger->log_out("ERROR", basename(__FILE__), "COMMAND STDERR: ".$allOutErr);
121
+            }
119 122
         }
120 123
         
121 124
         if ($showProgress) {
Please login to merge, or discard this patch.