sportarchive / CloudProcessingEngine

pollers/src/ActivityPoller.php

Braces +40 added lines, -29 removed lines

@@ -98,9 +98,10 @@ 
     public function poll_for_activities()
     {
         // Poll from all the taskList registered for each activities 
-        if ($this->debug)
-            $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
+        if ($this->debug) {
+                    $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
                 "Polling activity taskList '" . $this->taskList  . "' ... ");
+        }
             
         try {
             // Call SWF and poll for incoming tasks
@@ -124,8 +125,9 @@ 
     {
         // Get activityType and WorkflowExecution info
         if (!($activityType      = $activityTask->get("activityType")) ||
-            !($workflowExecution = $activityTask->get("workflowExecution")))
-            return false;
+            !($workflowExecution = $activityTask->get("workflowExecution"))) {
+                    return false;
+        }
         
         $this->cpeLogger->log_out("INFO",
             basename(__FILE__),
@@ -152,16 +154,18 @@ 
             // Perform input validation
             $this->activityHandler->do_input_validation();
 
-            if ($this->debug)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity input:\n" . print_r($this->activityHandler->input, true));
+            }
         
             // Run activity task
             $result = $this->activityHandler->do_activity($activityTask);
 
-            if ($this->debug && $result)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug && $result) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity output:\n" . print_r($result, true));
+            }
         
         } catch (CpeSdk\CpeException $e) {
             $reason  = $e->ref;
@@ -216,26 +220,31 @@ 
                 // Instantiate the Activity class that will process Tasks
 
                 if (!isset($this->cpeLogger) ||
-                    !$this->cpeLogger)
-                    print "EMPTY !!!\n";
+                    !$this->cpeLogger) {
+                                    print "EMPTY !!!\n";
+                }
 
                 $params = [
                     "domain"  => $this->domain,
                     "name"    => $activityToHandle->{"name"},
                     "version" => $activityToHandle->{"version"}
                 ];
-                if (isset($activityToHandle->{"defaultTaskStartToCloseTimeout"}))
-                    $params["defaultTaskStartToCloseTimeout"] =
+                if (isset($activityToHandle->{"defaultTaskStartToCloseTimeout"})) {
+                                    $params["defaultTaskStartToCloseTimeout"] =
                         $activityToHandle->{"defaultTaskStartToCloseTimeout"};
-                if (isset($activityToHandle->{"defaultTaskHeartbeatTimeout"}))
-                    $params["defaultTaskHeartbeatTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskHeartbeatTimeout"})) {
+                                    $params["defaultTaskHeartbeatTimeout"] =
                         $activityToHandle->{"defaultTaskHeartbeatTimeout"};
-                if (isset($activityToHandle->{"defaultTaskScheduleToStartTimeout"}))
-                    $params["defaultTaskScheduleToStartTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskScheduleToStartTimeout"})) {
+                                    $params["defaultTaskScheduleToStartTimeout"] =
                         $activityToHandle->{"defaultTaskScheduleToStartTimeout"};
-                if (isset($activityToHandle->{"defaultTaskScheduleToCloseTimeout"}))
-                    $params["defaultTaskScheduleToCloseTimeout"] =
+                }
+                if (isset($activityToHandle->{"defaultTaskScheduleToCloseTimeout"})) {
+                                    $params["defaultTaskScheduleToCloseTimeout"] =
                         $activityToHandle->{"defaultTaskScheduleToCloseTimeout"};
+                }
                 
                 $this->activityHandler = 
                     new $activityToHandle->{"class"}(
@@ -301,15 +310,18 @@ 
     global $activityVersion;
     
     // Handle input parameters
-    if (!($options = getopt("D:T:A:V:c:l:hd")))
-        usage($defaultConfigFile);
+    if (!($options = getopt("D:T:A:V:c:l:hd"))) {
+            usage($defaultConfigFile);
+    }
     
-    if (!count($options) || isset($options['h']))
-        usage($defaultConfigFile);
+    if (!count($options) || isset($options['h'])) {
+            usage($defaultConfigFile);
+    }
 
     // Debug
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
 
     // Domain
     if (!isset($options['D']))
@@ -367,8 +379,7 @@ 
             print "\n[CONFIG ISSUE]\nConfiguration file '$defaultConfigFile' invalid or non-existant.\n\n[EASY FIX]\nGo to the directory mentioned in the error above and rename the template file 'cpeConfigTemplate.json' to 'cpeConfig.json'. Configure your Activities. As example you have Activities for CloudTranscode already setup in the template. You can declare your Activities and start executing tasks in an SWF workflow.\n";
             exit(1);
         }
-    }
-    catch (Exception $e) {
+    } catch (Exception $e) {
         print $e;
     }
             
@@ -388,8 +399,7 @@ 
 // Instantiate ActivityPoller
 try {
     $activityPoller = new ActivityPoller($config);
-} 
-catch (CpeSdk\CpeException $e) {
+} catch (CpeSdk\CpeException $e) {
     $cpeLogger->log_out("FATAL",
         basename(__FILE__), $e->getMessage());
     exit(1);
@@ -398,6 +408,7 @@ 
 $cpeLogger->log_out("INFO", basename(__FILE__), "Starting activity tasks polling");
 
 // Start polling loop
-while (42)
+while (42) {
     $activityPoller->poll_for_activities();
+}