sportarchive / CloudProcessingEngine

client_example/ClientCommander.php

Indentation +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     $CpeClientSdk = new SA\CpeClientSdk($key, $secret, $region, $debug);
 } catch (Exception $e) {
     exit($e->getMessage());
-  }
+    }
 
 // Commands mapping
 $commandMap = [

Spacing +1 added lines, -1 removed lines

@@ -109,7 +109,7 @@
     {
         global $help;
     
-        echo("Usage: php ". basename(__FILE__) . " -c configFile [-h] [-k <key>] [-s <secret>] [-r <region>]\n");
+        echo("Usage: php " . basename(__FILE__) . " -c configFile [-h] [-k <key>] [-s <secret>] [-r <region>]\n");
         echo("-h: Print this help\n");
         echo("-d: Debug mode\n");
         echo("-c: configFile\n");

Braces +50 added lines, -41 removed lines

@@ -38,8 +38,7 @@ 
         $decodedClient = json_decode($clientInfo);
         
         $CpeClientSdk->start_job($decodedClient, $content);
-    }
-    catch (Exception $e) {
+    } catch (Exception $e) {
         print("[ERROR] " . $e->getMessage() . "\n");
     }
 }
@@ -68,42 +67,51 @@ 
     global $argv;
         
     // Handle input parameters
-    if (!($options = getopt("c:k::s::r::hd")))
-        usage();
-    if (isset($options['h']))
-        usage();
+    if (!($options = getopt("c:k::s::r::hd"))) {
+            usage();
+    }
+    if (isset($options['h'])) {
+            usage();
+    }
     
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
   
     if (isset($options['c']))
     {
         $clientConfFile = $options['c'];
-        if (!file_exists($clientConfFile))
-            throw new Exception("The client config file is not valid!");
-        if (!($clientInfo = file_get_contents($clientConfFile)))
-            throw new Exception("Unable to read the file");
-    }
-    else
-        throw new Exception("Please provide the client config file!");
-
-    if (isset($options['k']))
-        $key = $options['k'];
-    else
-        $key = getenv("AWS_ACCESS_KEY_ID");
+        if (!file_exists($clientConfFile)) {
+                    throw new Exception("The client config file is not valid!");
+        }
+        if (!($clientInfo = file_get_contents($clientConfFile))) {
+                    throw new Exception("Unable to read the file");
+        }
+    } else {
+            throw new Exception("Please provide the client config file!");
+    }
+
+    if (isset($options['k'])) {
+            $key = $options['k'];
+    } else {
+            $key = getenv("AWS_ACCESS_KEY_ID");
+    }
     
-    if (isset($options['s']))
-        $secret = $options['s'];
-    else
-        $secret = getenv("AWS_SECRET_KEY");
-
-    if (isset($options['r']))
-        $region = $options['r'];
-    else 
-        $region = getenv("AWS_DEFAULT_REGION");
-    if (!$region)
-        throw new Exception("Please provide your AWS region as parameter or using AWS_DEFAULT_REGION env var !");
-}
+    if (isset($options['s'])) {
+            $secret = $options['s'];
+    } else {
+            $secret = getenv("AWS_SECRET_KEY");
+    }
+
+    if (isset($options['r'])) {
+            $region = $options['r'];
+    } else {
+            $region = getenv("AWS_DEFAULT_REGION");
+    }
+    if (!$region) {
+            throw new Exception("Please provide your AWS region as parameter or using AWS_DEFAULT_REGION env var !");
+    }
+    }
 
     function usage()
     {
@@ -123,8 +131,7 @@ 
 
 try {
     check_input_parameters();
-} 
-catch (Exception $e) {
+} catch (Exception $e) {
     print "[ERROR] " . $e->getMessage() . "\n";
     exit(2);
 }
@@ -147,14 +154,16 @@ 
 {
     // Prompt (<3 php)
     $line = readline("Command [enter]: ");
-    if (!$line)
-        continue;
+    if (!$line) {
+            continue;
+    }
     readline_add_history($line);
 
     // Process user input
     $args = explode(" ", $line);
-    if (!isset($commandMap[$args[0]]))
-        print "[ERROR] Command not found!\n";
-    else 
-        $commandMap[$args[0]]($args);
-}
\ No newline at end of file
+    if (!isset($commandMap[$args[0]])) {
+            print "[ERROR] Command not found!\n";
+    } else {
+            $commandMap[$args[0]]($args);
+    }
+    }
\ No newline at end of file

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
 Commands:
 start_job <filepath>: Start a new job. Pass a JSON file containing the instruction (see: input_samples folder)
 
-EOF;
+eof;
 
     
 function check_input_parameters()

pollers/src/InputPoller.php

Spacing +11 added lines, -11 removed lines

@@ -107,12 +107,12 @@ 
                 $this->cpeLogger->log_out(
                     "ERROR", 
                     basename(__FILE__), 
-                    $e->getMessage().print_r($msg, true));
+                    $e->getMessage() . print_r($msg, true));
             } catch (\Exception $e) {
                 $this->cpeLogger->log_out(
                     "ERROR", 
                     basename(__FILE__), 
-                    $e->getMessage().print_r($msg, true));
+                    $e->getMessage() . print_r($msg, true));
             }
             
             // Message polled. Valid or not, we delete it from SQS
@@ -140,7 +140,7 @@ 
         $this->cpeLogger->log_out(
             "INFO", 
             basename(__FILE__), 
-            "Received message '" . $message->{"type"}  . "'"
+            "Received message '" . $message->{"type"} . "'"
         );
         if ($this->debug)
             $this->cpeLogger->log_out(
@@ -189,7 +189,7 @@ 
             $this->cpeLogger->log_out(
                 "INFO",
                 basename(__FILE__),
-                "New workflow submitted to SWF: ".$workflowRunId->get('runId'));
+                "New workflow submitted to SWF: " . $workflowRunId->get('runId'));
 
             // Send WORKFLOW_SCHEDULED message back to client
             $this->cpeSqsWriter->workflow_scheduled($workflowType, $workflowRunId->get('runId'), $workflowId, $message);
@@ -215,10 +215,10 @@ 
     private function validate_message($message)
     {
         if (!isset($message) || 
-            !isset($message->{"time"})   || $message->{"time"} == "" || 
-            !isset($message->{"jobId"})  || $message->{"jobId"} == "" || 
-            !isset($message->{"type"})   || $message->{"type"} == "" || 
-            !isset($message->{"data"})   || $message->{"data"} == "")
+            !isset($message->{"time"}) || $message->{"time"} == "" || 
+            !isset($message->{"jobId"}) || $message->{"jobId"} == "" || 
+            !isset($message->{"type"}) || $message->{"type"} == "" || 
+            !isset($message->{"data"}) || $message->{"data"} == "")
             throw new CpeSdk\CpeException("'time', 'type', 'jobId' or 'data' fields missing in JSON message file!",
                 self::INVALID_JSON);
         
@@ -238,7 +238,7 @@ 
 
 function usage($defaultConfigFile)
 {
-    echo("Usage: php ". basename(__FILE__) . " [-h] [-d] [-n <client_name>] [-l <log path>] -c <config_file path>\n");
+    echo("Usage: php " . basename(__FILE__) . " [-h] [-d] [-n <client_name>] [-l <log path>] -c <config_file path>\n");
     echo("-h: Print this help\n");
     echo("-d: Debug mode\n");
     echo("-l <log_path>: Location where logs will be dumped in (folder).\n");
@@ -289,9 +289,9 @@ 
 
     if (isset($options['n']))
     {
-        $config->clients = [(object)[
+        $config->clients = [(object) [
             'name' => $options['n'],
-            'queues' => (object)[
+            'queues' => (object) [
                 'input' => getenv('INPUT_QUEUE'),
                 'output' => getenv('OUTPUT_QUEUE'),
             ],

Braces +32 added lines, -23 removed lines

@@ -84,9 +84,10 @@ 
     // If a msg is received, we pass it to 'handle_input' for processing
     public function poll_SQS_queues()
     {
-        if (!isset($this->config->{'clients'}))
-            throw new CpeSdk\CpeException("Clients configuration invalid. Check the config file or your parameters.",
+        if (!isset($this->config->{'clients'})) {
+                    throw new CpeSdk\CpeException("Clients configuration invalid. Check the config file or your parameters.",
                 self::INVALID_CONFIG);
+        }
         
         // For all clients in config files
         // We poll from queues
@@ -100,13 +101,14 @@ 
             try {
                 if ($msg = $this->cpeSqsListener->receive_message($queue, 10))
                 {
-                    if (!($decoded = json_decode($msg['Body'])))
-                        $this->cpeLogger->log_out(
+                    if (!($decoded = json_decode($msg['Body']))) {
+                                            $this->cpeLogger->log_out(
                             "ERROR", 
                             basename(__FILE__), 
                             "JSON data invalid in queue: '$queue'");
-                    else                    
-                        $this->handle_message($decoded);
+                    } else {
+                                            $this->handle_message($decoded);
+                    }
                 }
             } catch (CpeSdk\CpeException $e) {
                 $this->cpeLogger->log_out(
@@ -121,8 +123,9 @@ 
             }
             
             // Message polled. Valid or not, we delete it from SQS
-            if ($msg)
-                $this->cpeSqsListener->delete_message($queue, $msg);
+            if ($msg) {
+                            $this->cpeSqsListener->delete_message($queue, $msg);
+            }
         }
     }
 
@@ -147,12 +150,13 @@ 
             basename(__FILE__), 
             "Received message '" . $message->{"type"}  . "'"
         );
-        if ($this->debug)
-            $this->cpeLogger->log_out(
+        if ($this->debug) {
+                    $this->cpeLogger->log_out(
                 "DEBUG", 
                 basename(__FILE__), 
                 "Details:\n" . json_encode($message, JSON_PRETTY_PRINT)
             );
+        }
 
         // We call the callback function that handles this message  
         $this->{$this->typesMap[$message->{"type"}]}($message);
@@ -166,12 +170,13 @@ 
     // Start a new workflow in SWF to initiate new transcoding job
     private function start_job($message)
     {
-        if ($this->debug)
-            $this->cpeLogger->log_out(
+        if ($this->debug) {
+                    $this->cpeLogger->log_out(
                 "DEBUG",
                 basename(__FILE__),
                 "Starting new workflow!"
             );
+        }
         
         // Workflow info
         $workflowType = array(
@@ -223,13 +228,15 @@ 
             !isset($message->{"time"})   || $message->{"time"} == "" || 
             !isset($message->{"jobId"})  || $message->{"jobId"} == "" || 
             !isset($message->{"type"})   || $message->{"type"} == "" || 
-            !isset($message->{"data"})   || $message->{"data"} == "")
-            throw new CpeSdk\CpeException("'time', 'type', 'jobId' or 'data' fields missing in JSON message file!",
+            !isset($message->{"data"})   || $message->{"data"} == "") {
+                    throw new CpeSdk\CpeException("'time', 'type', 'jobId' or 'data' fields missing in JSON message file!",
                 self::INVALID_JSON);
+        }
         
-        if (!isset($message->{'data'}->{'workflow'}))
-            throw new CpeSdk\CpeException("Input doesn't contain any workflow information. You must provide the workflow you want to send this job to!",
+        if (!isset($message->{'data'}->{'workflow'})) {
+                    throw new CpeSdk\CpeException("Input doesn't contain any workflow information. You must provide the workflow you want to send this job to!",
                 self::INVALID_JSON);
+        }
     }
 }
 
@@ -260,11 +267,13 @@ 
     // Handle input parameters
     $options = getopt("c:l:hdn:");
 
-    if (isset($options['h']))
-        usage($defaultConfigFile);
+    if (isset($options['h'])) {
+            usage($defaultConfigFile);
+    }
     
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
     
     $logPath = null;
     if (isset($options['l']))
@@ -319,8 +328,7 @@ 
 // Create InputPoller object
 try {
     $inputPoller = new InputPoller($config);
-}
-catch (CpeSdk\CpeException $e) {
+} catch (CpeSdk\CpeException $e) {
     echo $e->getMessage();
     $cpeLogger->log_out(
         "FATAL", 
@@ -331,5 +339,6 @@ 
 }
 
 // Start polling loop to get incoming commands from SQS input queues
-while (42)
+while (42) {
     $inputPoller->poll_SQS_queues();
+}

pollers/src/ActivityPoller.php

Spacing +5 added lines, -5 removed lines

@@ -90,7 +90,7 @@ 
         // Poll from all the taskList registered for each activities 
         if ($this->debug)
             $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
-                "Polling activity taskList '" . $this->taskList  . "' ... ");
+                "Polling activity taskList '" . $this->taskList . "' ... ");
             
         try {
             // Call SWF and poll for incoming tasks
@@ -191,9 +191,9 @@ 
                 if (!file_exists($activityToHandle->{"file"}))
                 {
                     $this->cpeLogger->log_out("ERROR", basename(__FILE__),
-                        "The code file '".$activityToHandle->{"file"}."' for activity: name=" 
+                        "The code file '" . $activityToHandle->{"file"} . "' for activity: name=" 
                         . $activityToHandle->{"name"} . ",version=" 
-                        . $activityToHandle->{"version"}." doesn't exists! Check if the file is accessible and if the path is correct in your config file.");
+                        . $activityToHandle->{"version"} . " doesn't exists! Check if the file is accessible and if the path is correct in your config file.");
                     return false;
                 }
                 
@@ -227,7 +227,7 @@ 
         $this->cpeLogger->log_out("ERROR", basename(__FILE__),
             "No Activity handler was found for: name=" 
             . $this->activityName . ",version=" 
-            . $this->activityVersion.". Check your config file and ensure your 'activity' name AND 'version' is there.");    
+            . $this->activityVersion . ". Check your config file and ensure your 'activity' name AND 'version' is there.");    
         return false;
     }
 }
@@ -245,7 +245,7 @@ 
 // Usage
 function usage($defaultConfigFile)
 {
-    echo("Usage: php ". basename(__FILE__) . " -D <domain> -T <task_list> -A <activity_name> -V <activity_version> [-h] [-d] [-c <config_file path>] [-l <log path>]\n");
+    echo("Usage: php " . basename(__FILE__) . " -D <domain> -T <task_list> -A <activity_name> -V <activity_version> [-h] [-d] [-c <config_file path>] [-l <log path>]\n");
     echo("-h: Print this help\n");
     echo("-d: Debug mode\n");
     echo("-c <config_file path>: Optional parameter to override the default configuration file: '$defaultConfigFile'.\n");

Braces +27 added lines, -19 removed lines

@@ -78,8 +78,9 @@ 
         $this->cpeSwfHandler   = new CpeSdk\Swf\CpeSwfHandler($this->debug);
         
         // Check and load activities to handle
-        if (!$this->register_activities())
-            die("No activity class registered! Check the logs (/var/tmp/logs/cpe/). Exiting ...\n");
+        if (!$this->register_activities()) {
+                    die("No activity class registered! Check the logs (/var/tmp/logs/cpe/). Exiting ...\n");
+        }
     }
     
     // We poll for new activities
@@ -88,9 +89,10 @@ 
     public function poll_for_activities()
     {
         // Poll from all the taskList registered for each activities 
-        if ($this->debug)
-            $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
+        if ($this->debug) {
+                    $this->cpeLogger->log_out("DEBUG", basename(__FILE__),
                 "Polling activity taskList '" . $this->taskList  . "' ... ");
+        }
             
         try {
             // Call SWF and poll for incoming tasks
@@ -114,8 +116,9 @@ 
     {
         // Get activityType and WorkflowExecution info
         if (!($activityType      = $activityTask->get("activityType")) ||
-            !($workflowExecution = $activityTask->get("workflowExecution")))
-            return false;
+            !($workflowExecution = $activityTask->get("workflowExecution"))) {
+                    return false;
+        }
         
         $this->cpeLogger->log_out("INFO",
             basename(__FILE__),
@@ -142,16 +145,18 @@ 
             // Perform input validation
             $this->activityHandler->do_input_validation();
 
-            if ($this->debug)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity input:\n" . print_r($this->activityHandler->input, true));
+            }
         
             // Run activity task
             $result = $this->activityHandler->do_activity($activityTask);
 
-            if ($this->debug && $result)
-                $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
+            if ($this->debug && $result) {
+                            $this->cpeLogger->log_out("DEBUG", basename(__FILE__), 
                     "Activity output:\n" . print_r($result, true));
+            }
         
         } catch (CpeSdk\CpeException $e) {
             $reason  = $e->ref;
@@ -270,15 +275,18 @@ 
     global $activityVersion;
     
     // Handle input parameters
-    if (!($options = getopt("D:T:A:V:c:l:hd")))
-        usage($defaultConfigFile);
+    if (!($options = getopt("D:T:A:V:c:l:hd"))) {
+            usage($defaultConfigFile);
+    }
     
-    if (!count($options) || isset($options['h']))
-        usage($defaultConfigFile);
+    if (!count($options) || isset($options['h'])) {
+            usage($defaultConfigFile);
+    }
 
     // Debug
-    if (isset($options['d']))
-        $debug = true;
+    if (isset($options['d'])) {
+            $debug = true;
+    }
 
     // Domain
     if (!isset($options['D']))
@@ -348,8 +356,7 @@ 
 // Instantiate ActivityPoller
 try {
     $activityPoller = new ActivityPoller($config);
-} 
-catch (CpeSdk\CpeException $e) {
+} catch (CpeSdk\CpeException $e) {
     $cpeLogger->log_out("FATAL",
         basename(__FILE__), $e->getMessage());
     exit(1);
@@ -358,6 +365,7 @@ 
 $cpeLogger->log_out("INFO", basename(__FILE__), "Starting activity tasks polling");
 
 // Start polling loop
-while (42)
+while (42) {
     $activityPoller->poll_for_activities();
+}
 

client_example/ClientPoller.php

Indentation +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     $CpeClientSdk = new SA\CpeClientSdk($key, $secret, $region, $debug);
 } catch (Exception $e) {
     exit($e->getMessage());
-  }
+    }
 
 // Commands mapping
 $commandMap = [