Inspection of "Cast request URI to string for http.url trace attr..." - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#1126)

unknown

created 2024-08-28 03:37 UTC

Status

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -47,7 +47,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return 'hello world';
         });
 
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
         $core->setHandler(
-            new CallableHandler(function () {
+            new CallableHandler(function (){
                 return 'hello world';
             }, new ResponseFactory(new HttpConfig(['headers' => []])))
         );
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp){
             return $resp->withAddedHeader('hello', 'value');
         });
 
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp){
             echo 'hello!';
 
             return $resp->withAddedHeader('hello', 'value');
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp){
             echo 'hello!';
             $resp->getBody()->write('world ');
 
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             ob_start();
             ob_start();
             echo 'hello!';
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return [
                 'status' => 404,
                 'message' => 'not found',
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return new Json([
                 'status' => 404,
                 'message' => 'not found',
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore([HeaderMiddleware::class]);
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return 'hello?';
         });
 
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
         $core->getPipeline()->pushMiddleware(new Header2Middleware());
         $core->getPipeline()->riseMiddleware(new HeaderMiddleware());
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return 'hello?';
         });
 
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
         $core->getPipeline()->pushMiddleware(new HeaderMiddleware());
         $core->getPipeline()->riseMiddleware(new Header2Middleware());
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return 'hello?';
         });
 
@@ -248,12 +248,12 @@  discard block
 block discarded – undo
         $dispatcher
             ->expects(self::exactly(2))
             ->method('dispatch')
-            ->with($this->callback(static fn(RequestReceived|RequestHandled $event): bool => true));
+            ->with($this->callback(static fn(RequestReceived | RequestHandled $event): bool => true));
         $this->container->bind(EventDispatcherInterface::class, $dispatcher);
 
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function (){
             return 'hello world';
         });
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function (){
             return 'hello world';
         });
 
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function (){
             return 'hello world';
         });
 
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
                 true,
                 TraceKind::SERVER
             )
-            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
+            ->andReturnUsing(function ($name, $callback, $attributes, $scoped, $traceKind){
                 return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
             });
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function (){
             return 'hello world';
         });
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
         $tracer
             ->shouldReceive('trace')
             ->once()
-            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
+            ->andReturnUsing(function ($name, $callback, $attributes, $scoped, $traceKind){
                 return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
             });
 

Please login to merge, or discard this patch.

Braces +34 added lines, -17 removed lines patch added patch discarded remove patch

@@ -47,7 +47,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return 'hello world';
         });
 
@@ -69,7 +70,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
         $core->setHandler(
-            new CallableHandler(function () {
+            new CallableHandler(function ()
+            {
                 return 'hello world';
             }, new ResponseFactory(new HttpConfig(['headers' => []])))
         );
@@ -82,7 +84,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp)
+        {
             return $resp->withAddedHeader('hello', 'value');
         });
 
@@ -95,7 +98,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp)
+        {
             echo 'hello!';
 
             return $resp->withAddedHeader('hello', 'value');
@@ -111,7 +115,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function ($req, $resp) {
+        $core->setHandler(function ($req, $resp)
+        {
             echo 'hello!';
             $resp->getBody()->write('world ');
 
@@ -128,7 +133,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             ob_start();
             ob_start();
             echo 'hello!';
@@ -149,7 +155,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return [
                 'status' => 404,
                 'message' => 'not found',
@@ -165,7 +172,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return new Json([
                 'status' => 404,
                 'message' => 'not found',
@@ -181,7 +189,8 @@  discard block
 block discarded – undo
     {
         $core = $this->getCore([HeaderMiddleware::class]);
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return 'hello?';
         });
 
@@ -198,7 +207,8 @@  discard block
 block discarded – undo
         $core->getPipeline()->pushMiddleware(new Header2Middleware());
         $core->getPipeline()->riseMiddleware(new HeaderMiddleware());
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return 'hello?';
         });
 
@@ -215,7 +225,8 @@  discard block
 block discarded – undo
         $core->getPipeline()->pushMiddleware(new HeaderMiddleware());
         $core->getPipeline()->riseMiddleware(new Header2Middleware());
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return 'hello?';
         });
 
@@ -253,7 +264,8 @@  discard block
 block discarded – undo
 
         $core = $this->getCore();
 
-        $core->setHandler(function () {
+        $core->setHandler(function ()
+        {
             return 'hello world';
         });
 
@@ -274,7 +286,8 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function ()
+        {
             return 'hello world';
         });
 
@@ -301,7 +314,8 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function ()
+        {
             return 'hello world';
         });
 
@@ -325,7 +339,8 @@  discard block
 block discarded – undo
                 true,
                 TraceKind::SERVER
             )
-            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
+            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind)
+            {
                 return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
             });
 
@@ -351,7 +366,8 @@  discard block
 block discarded – undo
             $tracerFactory = m::mock(TracerFactoryInterface::class),
         );
 
-        $http->setHandler(function () {
+        $http->setHandler(function ()
+        {
             return 'hello world';
         });
 
@@ -364,7 +380,8 @@  discard block
 block discarded – undo
         $tracer
             ->shouldReceive('trace')
             ->once()
-            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
+            ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind)
+            {
                 return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
             });
 

Please login to merge, or discard this patch.

src/Http/src/Http.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -33,8 +33,8 @@  discard block
 block discarded – undo
         private readonly ContainerInterface $container,
         ?TracerFactoryInterface $tracerFactory = null,
         private readonly ?EventDispatcherInterface $dispatcher = null,
-    ) {
-        foreach ($this->config->getMiddleware() as $middleware) {
+    ){
+        foreach ($this->config->getMiddleware() as $middleware){
             $this->pipeline->pushMiddleware($this->container->get($middleware));
         }
 
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
         return $this->pipeline;
     }
 
-    public function setHandler(callable|RequestHandlerInterface $handler): self
+    public function setHandler(callable | RequestHandlerInterface $handler): self
     {
         $this->handler = $handler instanceof RequestHandlerInterface
             ? $handler
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
 
             $this->dispatcher?->dispatch(new RequestReceived($request));
 
-            if ($this->handler === null) {
+            if ($this->handler === null){
                 throw new HttpException('Unable to run HttpCore, no handler is set.');
             }
 
@@ -96,14 +96,14 @@  discard block
 block discarded – undo
             callback: $callback,
             attributes: [
                 'http.method' => $request->getMethod(),
-                'http.url' => (string) $request->getUri(),
+                'http.url' => (string)$request->getUri(),
                 'http.headers' => $request->getHeaders(),
             ],
             scoped: true,
             traceKind: TraceKind::SERVER
         );
 
-        foreach ($tracer->getContext() as $key => $value) {
+        foreach ($tracer->getContext() as $key => $value){
             $response = $response->withHeader($key, $value);
         }
 

Please login to merge, or discard this patch.

		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	{
48	48	$core = $this->getCore();
49	49
50		- $core->setHandler(function () {
	50	+ $core->setHandler(function (){
51	51	return 'hello world';
52	52	});
53	53
		@@ -69,7 +69,7 @@ discard block
		block discarded – undo
69	69	{
70	70	$core = $this->getCore();
71	71	$core->setHandler(
72		- new CallableHandler(function () {
	72	+ new CallableHandler(function (){
73	73	return 'hello world';
74	74	}, new ResponseFactory(new HttpConfig(['headers' => []])))
75	75	);
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	{
83	83	$core = $this->getCore();
84	84
85		- $core->setHandler(function ($req, $resp) {
	85	+ $core->setHandler(function ($req, $resp){
86	86	return $resp->withAddedHeader('hello', 'value');
87	87	});
88	88
		@@ -95,7 +95,7 @@ discard block
		block discarded – undo
95	95	{
96	96	$core = $this->getCore();
97	97
98		- $core->setHandler(function ($req, $resp) {
	98	+ $core->setHandler(function ($req, $resp){
99	99	echo 'hello!';
100	100
101	101	return $resp->withAddedHeader('hello', 'value');
		@@ -111,7 +111,7 @@ discard block
		block discarded – undo
111	111	{
112	112	$core = $this->getCore();
113	113
114		- $core->setHandler(function ($req, $resp) {
	114	+ $core->setHandler(function ($req, $resp){
115	115	echo 'hello!';
116	116	$resp->getBody()->write('world ');
117	117
		@@ -128,7 +128,7 @@ discard block
		block discarded – undo
128	128	{
129	129	$core = $this->getCore();
130	130
131		- $core->setHandler(function () {
	131	+ $core->setHandler(function (){
132	132	ob_start();
133	133	ob_start();
134	134	echo 'hello!';
		@@ -149,7 +149,7 @@ discard block
		block discarded – undo
149	149	{
150	150	$core = $this->getCore();
151	151
152		- $core->setHandler(function () {
	152	+ $core->setHandler(function (){
153	153	return [
154	154	'status' => 404,
155	155	'message' => 'not found',
		@@ -165,7 +165,7 @@ discard block
		block discarded – undo
165	165	{
166	166	$core = $this->getCore();
167	167
168		- $core->setHandler(function () {
	168	+ $core->setHandler(function (){
169	169	return new Json([
170	170	'status' => 404,
171	171	'message' => 'not found',
		@@ -181,7 +181,7 @@ discard block
		block discarded – undo
181	181	{
182	182	$core = $this->getCore([HeaderMiddleware::class]);
183	183
184		- $core->setHandler(function () {
	184	+ $core->setHandler(function (){
185	185	return 'hello?';
186	186	});
187	187
		@@ -198,7 +198,7 @@ discard block
		block discarded – undo
198	198	$core->getPipeline()->pushMiddleware(new Header2Middleware());
199	199	$core->getPipeline()->riseMiddleware(new HeaderMiddleware());
200	200
201		- $core->setHandler(function () {
	201	+ $core->setHandler(function (){
202	202	return 'hello?';
203	203	});
204	204
		@@ -215,7 +215,7 @@ discard block
		block discarded – undo
215	215	$core->getPipeline()->pushMiddleware(new HeaderMiddleware());
216	216	$core->getPipeline()->riseMiddleware(new Header2Middleware());
217	217
218		- $core->setHandler(function () {
	218	+ $core->setHandler(function (){
219	219	return 'hello?';
220	220	});
221	221
		@@ -248,12 +248,12 @@ discard block
		block discarded – undo
248	248	$dispatcher
249	249	->expects(self::exactly(2))
250	250	->method('dispatch')
251		- ->with($this->callback(static fn(RequestReceived\|RequestHandled $event): bool => true));
	251	+ ->with($this->callback(static fn(RequestReceived \| RequestHandled $event): bool => true));
252	252	$this->container->bind(EventDispatcherInterface::class, $dispatcher);
253	253
254	254	$core = $this->getCore();
255	255
256		- $core->setHandler(function () {
	256	+ $core->setHandler(function (){
257	257	return 'hello world';
258	258	});
259	259
		@@ -274,7 +274,7 @@ discard block
		block discarded – undo
274	274	$tracerFactory = m::mock(TracerFactoryInterface::class),
275	275	);
276	276
277		- $http->setHandler(function () {
	277	+ $http->setHandler(function (){
278	278	return 'hello world';
279	279	});
280	280
		@@ -301,7 +301,7 @@ discard block
		block discarded – undo
301	301	$tracerFactory = m::mock(TracerFactoryInterface::class),
302	302	);
303	303
304		- $http->setHandler(function () {
	304	+ $http->setHandler(function (){
305	305	return 'hello world';
306	306	});
307	307
		@@ -325,7 +325,7 @@ discard block
		block discarded – undo
325	325	true,
326	326	TraceKind::SERVER
327	327	)
328		- ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
	328	+ ->andReturnUsing(function ($name, $callback, $attributes, $scoped, $traceKind){
329	329	return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
330	330	});
331	331
		@@ -351,7 +351,7 @@ discard block
		block discarded – undo
351	351	$tracerFactory = m::mock(TracerFactoryInterface::class),
352	352	);
353	353
354		- $http->setHandler(function () {
	354	+ $http->setHandler(function (){
355	355	return 'hello world';
356	356	});
357	357
		@@ -364,7 +364,7 @@ discard block
		block discarded – undo
364	364	$tracer
365	365	->shouldReceive('trace')
366	366	->once()
367		- ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
	367	+ ->andReturnUsing(function ($name, $callback, $attributes, $scoped, $traceKind){
368	368	return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
369	369	});
370	370

		@@ -47,7 +47,8 @@ discard block
		block discarded – undo
47	47	{
48	48	$core = $this->getCore();
49	49
50		- $core->setHandler(function () {
	50	+ $core->setHandler(function ()
	51	+ {
51	52	return 'hello world';
52	53	});
53	54
		@@ -69,7 +70,8 @@ discard block
		block discarded – undo
69	70	{
70	71	$core = $this->getCore();
71	72	$core->setHandler(
72		- new CallableHandler(function () {
	73	+ new CallableHandler(function ()
	74	+ {
73	75	return 'hello world';
74	76	}, new ResponseFactory(new HttpConfig(['headers' => []])))
75	77	);
		@@ -82,7 +84,8 @@ discard block
		block discarded – undo
82	84	{
83	85	$core = $this->getCore();
84	86
85		- $core->setHandler(function ($req, $resp) {
	87	+ $core->setHandler(function ($req, $resp)
	88	+ {
86	89	return $resp->withAddedHeader('hello', 'value');
87	90	});
88	91
		@@ -95,7 +98,8 @@ discard block
		block discarded – undo
95	98	{
96	99	$core = $this->getCore();
97	100
98		- $core->setHandler(function ($req, $resp) {
	101	+ $core->setHandler(function ($req, $resp)
	102	+ {
99	103	echo 'hello!';
100	104
101	105	return $resp->withAddedHeader('hello', 'value');
		@@ -111,7 +115,8 @@ discard block
		block discarded – undo
111	115	{
112	116	$core = $this->getCore();
113	117
114		- $core->setHandler(function ($req, $resp) {
	118	+ $core->setHandler(function ($req, $resp)
	119	+ {
115	120	echo 'hello!';
116	121	$resp->getBody()->write('world ');
117	122
		@@ -128,7 +133,8 @@ discard block
		block discarded – undo
128	133	{
129	134	$core = $this->getCore();
130	135
131		- $core->setHandler(function () {
	136	+ $core->setHandler(function ()
	137	+ {
132	138	ob_start();
133	139	ob_start();
134	140	echo 'hello!';
		@@ -149,7 +155,8 @@ discard block
		block discarded – undo
149	155	{
150	156	$core = $this->getCore();
151	157
152		- $core->setHandler(function () {
	158	+ $core->setHandler(function ()
	159	+ {
153	160	return [
154	161	'status' => 404,
155	162	'message' => 'not found',
		@@ -165,7 +172,8 @@ discard block
		block discarded – undo
165	172	{
166	173	$core = $this->getCore();
167	174
168		- $core->setHandler(function () {
	175	+ $core->setHandler(function ()
	176	+ {
169	177	return new Json([
170	178	'status' => 404,
171	179	'message' => 'not found',
		@@ -181,7 +189,8 @@ discard block
		block discarded – undo
181	189	{
182	190	$core = $this->getCore([HeaderMiddleware::class]);
183	191
184		- $core->setHandler(function () {
	192	+ $core->setHandler(function ()
	193	+ {
185	194	return 'hello?';
186	195	});
187	196
		@@ -198,7 +207,8 @@ discard block
		block discarded – undo
198	207	$core->getPipeline()->pushMiddleware(new Header2Middleware());
199	208	$core->getPipeline()->riseMiddleware(new HeaderMiddleware());
200	209
201		- $core->setHandler(function () {
	210	+ $core->setHandler(function ()
	211	+ {
202	212	return 'hello?';
203	213	});
204	214
		@@ -215,7 +225,8 @@ discard block
		block discarded – undo
215	225	$core->getPipeline()->pushMiddleware(new HeaderMiddleware());
216	226	$core->getPipeline()->riseMiddleware(new Header2Middleware());
217	227
218		- $core->setHandler(function () {
	228	+ $core->setHandler(function ()
	229	+ {
219	230	return 'hello?';
220	231	});
221	232
		@@ -253,7 +264,8 @@ discard block
		block discarded – undo
253	264
254	265	$core = $this->getCore();
255	266
256		- $core->setHandler(function () {
	267	+ $core->setHandler(function ()
	268	+ {
257	269	return 'hello world';
258	270	});
259	271
		@@ -274,7 +286,8 @@ discard block
		block discarded – undo
274	286	$tracerFactory = m::mock(TracerFactoryInterface::class),
275	287	);
276	288
277		- $http->setHandler(function () {
	289	+ $http->setHandler(function ()
	290	+ {
278	291	return 'hello world';
279	292	});
280	293
		@@ -301,7 +314,8 @@ discard block
		block discarded – undo
301	314	$tracerFactory = m::mock(TracerFactoryInterface::class),
302	315	);
303	316
304		- $http->setHandler(function () {
	317	+ $http->setHandler(function ()
	318	+ {
305	319	return 'hello world';
306	320	});
307	321
		@@ -325,7 +339,8 @@ discard block
		block discarded – undo
325	339	true,
326	340	TraceKind::SERVER
327	341	)
328		- ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
	342	+ ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind)
	343	+ {
329	344	return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
330	345	});
331	346
		@@ -351,7 +366,8 @@ discard block
		block discarded – undo
351	366	$tracerFactory = m::mock(TracerFactoryInterface::class),
352	367	);
353	368
354		- $http->setHandler(function () {
	369	+ $http->setHandler(function ()
	370	+ {
355	371	return 'hello world';
356	372	});
357	373
		@@ -364,7 +380,8 @@ discard block
		block discarded – undo
364	380	$tracer
365	381	->shouldReceive('trace')
366	382	->once()
367		- ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind) {
	383	+ ->andReturnUsing(function($name, $callback, $attributes, $scoped, $traceKind)
	384	+ {
368	385	return $this->container->get(TracerInterface::class)->trace($name, $callback, $attributes, $scoped, $traceKind);
369	386	});
370	387

		@@ -33,8 +33,8 @@ discard block
		block discarded – undo
33	33	private readonly ContainerInterface $container,
34	34	?TracerFactoryInterface $tracerFactory = null,
35	35	private readonly ?EventDispatcherInterface $dispatcher = null,
36		- ) {
37		- foreach ($this->config->getMiddleware() as $middleware) {
	36	+ ){
	37	+ foreach ($this->config->getMiddleware() as $middleware){
38	38	$this->pipeline->pushMiddleware($this->container->get($middleware));
39	39	}
40	40
		@@ -47,7 +47,7 @@ discard block
		block discarded – undo
47	47	return $this->pipeline;
48	48	}
49	49
50		- public function setHandler(callable\|RequestHandlerInterface $handler): self
	50	+ public function setHandler(callable \| RequestHandlerInterface $handler): self
51	51	{
52	52	$this->handler = $handler instanceof RequestHandlerInterface
53	53	? $handler
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66
67	67	$this->dispatcher?->dispatch(new RequestReceived($request));
68	68
69		- if ($this->handler === null) {
	69	+ if ($this->handler === null){
70	70	throw new HttpException('Unable to run HttpCore, no handler is set.');
71	71	}
72	72
		@@ -96,14 +96,14 @@ discard block
		block discarded – undo
96	96	callback: $callback,
97	97	attributes: [
98	98	'http.method' => $request->getMethod(),
99		- 'http.url' => (string) $request->getUri(),
	99	+ 'http.url' => (string)$request->getUri(),
100	100	'http.headers' => $request->getHeaders(),
101	101	],
102	102	scoped: true,
103	103	traceKind: TraceKind::SERVER
104	104	);
105	105
106		- foreach ($tracer->getContext() as $key => $value) {
	106	+ foreach ($tracer->getContext() as $key => $value){
107	107	$response = $response->withHeader($key, $value);
108	108	}
109	109

spiral / framework

Pull Request — master (#1126)

Status

Category

Spacing +18 added lines, -18 removed lines patch added patch discarded remove patch

Braces +34 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch