ValidationException::createStatic() - Code Metrics - Inspection of "Merge pull request #1222: [Core] Fix `static` retu..." - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c81bf2...c3afe7 )

by Aleksei

created 2025-03-31 15:46 UTC

ValidationException::createStatic() A

↳ Parent: ValidationException

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php

declare(strict_types=1);

namespace Spiral\Core\Exception\Resolver;

use Spiral\Core\Exception\Traits\ClosureRendererTrait;

abstract class ValidationException extends ResolvingException
{
    use ClosureRendererTrait;


    final private function __construct(
        protected readonly \ReflectionFunctionAbstract $reflection,
        protected readonly string $parameter,
        ?string $message = null,
    ) {
        $message ??= $this->getValidationMessage($reflection, $parameter);
        parent::__construct($this->renderFunctionAndParameter($reflection, $message));
    }

    public static function createWithParam(\ReflectionFunctionAbstract $reflection, string $parameter): static
    {
        return new static($reflection, $parameter);
    }

    public function getParameter(): string
    {
        return $this->parameter;
    }

    protected static function createStatic(string $message, ?\Throwable $previous): static
    {
        $previous instanceof self or throw new \InvalidArgumentException(
            \sprintf('Previous exception must be an instance of %s.', self::class),
        );
        return new static($previous->reflection, $previous->parameter, $message);

    }

    abstract protected function getValidationMessage(
        \ReflectionFunctionAbstract $reflection,
        string $parameter,
    ): string;
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Spiral\Core\Exception\Resolver;
6
7		use Spiral\Core\Exception\Traits\ClosureRendererTrait;
8
9		abstract class ValidationException extends ResolvingException
10		{
11		use ClosureRendererTrait;
		0 ignored issues – show Bug introduced 2025-03-31 14:03 UTC by Report Bug Copy Issue Report The trait `Spiral\Core\Exception\Traits\ClosureRendererTrait` requires the property `$class` which is not provided by `Spiral\Core\Exception\Resolver\ValidationException`. Loading history...
12
13	24	final private function __construct(
14		protected readonly \ReflectionFunctionAbstract $reflection,
15		protected readonly string $parameter,
16		?string $message = null,
17		) {
18	24	$message ??= $this->getValidationMessage($reflection, $parameter);
19	24	parent::__construct($this->renderFunctionAndParameter($reflection, $message));
20		}
21
22	24	public static function createWithParam(\ReflectionFunctionAbstract $reflection, string $parameter): static
23		{
24	24	return new static($reflection, $parameter);
25		}
26
27	10	public function getParameter(): string
28		{
29	10	return $this->parameter;
30		}
31
32	7	protected static function createStatic(string $message, ?\Throwable $previous): static
33		{
34	7	$previous instanceof self or throw new \InvalidArgumentException(
35	7	\sprintf('Previous exception must be an instance of %s.', self::class),
36	7	);
37	7	return new static($previous->reflection, $previous->parameter, $message);
		0 ignored issues – show Bug introduced 2025-03-31 14:03 UTC by Report Bug Copy Issue Report Accessing `reflection` on the interface `Throwable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2025-03-31 14:03 UTC by Report Bug Copy Issue Report Accessing `parameter` on the interface `Throwable` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
38		}
39
40		abstract protected function getValidationMessage(
41		\ReflectionFunctionAbstract $reflection,
42		string $parameter,
43		): string;
44		}
45

spiral / framework

Push — master ( c81bf2...c3afe7 )

ValidationException::createStatic() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like