Spiral\Core\Exception\Resolver\ValidationException

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getParameter()	0	3	1
A	createStatic()	0	6	2
A	createWithParam()	0	3	1
A	__construct()	0	7	1

<?php

declare(strict_types=1);

namespace Spiral\Core\Exception\Resolver;

use Spiral\Core\Exception\Traits\ClosureRendererTrait;

abstract class ValidationException extends ResolvingException
{
    use ClosureRendererTrait;

The trait Spiral\Core\Exception\Traits\ClosureRendererTrait requires the property $class which is not provided by Spiral\Core\Exception\Resolver\ValidationException.

    final private function __construct(
        protected readonly \ReflectionFunctionAbstract $reflection,
        protected readonly string $parameter,
        ?string $message = null,
    ) {
        $message ??= $this->getValidationMessage($reflection, $parameter);
        parent::__construct($this->renderFunctionAndParameter($reflection, $message));
    }

    public static function createWithParam(\ReflectionFunctionAbstract $reflection, string $parameter): static
    {
        return new static($reflection, $parameter);
    }

    public function getParameter(): string
    {
        return $this->parameter;
    }

    protected static function createStatic(string $message, ?\Throwable $previous): static
    {
        $previous instanceof self or throw new \InvalidArgumentException(
            \sprintf('Previous exception must be an instance of %s.', self::class),
        );
        return new static($previous->reflection, $previous->parameter, $message);

Accessing reflection on the interface Throwable suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing parameter on the interface Throwable suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    abstract protected function getValidationMessage(
        \ReflectionFunctionAbstract $reflection,
        string $parameter,
    ): string;
}