Passed
Branch master (b26d17)
by Anton
02:18
created
src/GRPC/ProtoCompiler.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -58,14 +58,14 @@  discard block
 block discarded – undo
58 58
 
59 59
         $output = trim(join("\n", $output), "\n ,");
60 60
 
61
-        if ($output !== '') {
61
+        if ($output !== ''){
62 62
             $this->files->deleteDirectory($tmpDir);
63 63
             throw new CompileException($output);
64 64
         }
65 65
 
66 66
         // copying files (using relative path and namespace)
67 67
         $result = [];
68
-        foreach ($this->files->getFiles($tmpDir) as $file) {
68
+        foreach ($this->files->getFiles($tmpDir) as $file){
69 69
             $result[] = $this->copy($tmpDir, $file);
70 70
         }
71 71
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
82 82
     private function copy(string $tmpDir, string $file): string
83 83
     {
84 84
         $source = ltrim($this->files->relativePath($file, $tmpDir), '\\/');
85
-        if (strpos($source, $this->baseNamespace) === 0) {
85
+        if (strpos($source, $this->baseNamespace) === 0){
86 86
             $source = ltrim(substr($source, strlen($this->baseNamespace)), '\\/');
87 87
         }
88 88
 
89
-        $target = $this->files->normalizePath($this->basePath . '/' . $source);
89
+        $target = $this->files->normalizePath($this->basePath.'/'.$source);
90 90
 
91 91
         $this->files->ensureDirectory(dirname($target));
92 92
         $this->files->copy($file, $target);
@@ -99,7 +99,7 @@  discard block
 block discarded – undo
99 99
      */
100 100
     private function tmpDir(): string
101 101
     {
102
-        $directory = sys_get_temp_dir() . '/' . spl_object_hash($this);
102
+        $directory = sys_get_temp_dir().'/'.spl_object_hash($this);
103 103
         $this->files->ensureDirectory($directory);
104 104
 
105 105
         return $this->files->normalizePath($directory, true);
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -58,14 +58,16 @@  discard block
 block discarded – undo
58 58
 
59 59
         $output = trim(join("\n", $output), "\n ,");
60 60
 
61
-        if ($output !== '') {
61
+        if ($output !== '')
62
+        {
62 63
             $this->files->deleteDirectory($tmpDir);
63 64
             throw new CompileException($output);
64 65
         }
65 66
 
66 67
         // copying files (using relative path and namespace)
67 68
         $result = [];
68
-        foreach ($this->files->getFiles($tmpDir) as $file) {
69
+        foreach ($this->files->getFiles($tmpDir) as $file)
70
+        {
69 71
             $result[] = $this->copy($tmpDir, $file);
70 72
         }
71 73
 
@@ -82,7 +84,8 @@  discard block
 block discarded – undo
82 84
     private function copy(string $tmpDir, string $file): string
83 85
     {
84 86
         $source = ltrim($this->files->relativePath($file, $tmpDir), '\\/');
85
-        if (strpos($source, $this->baseNamespace) === 0) {
87
+        if (strpos($source, $this->baseNamespace) === 0)
88
+        {
86 89
             $source = ltrim(substr($source, strlen($this->baseNamespace)), '\\/');
87 90
         }
88 91
 
Please login to merge, or discard this patch.
tests/Framework/GRPC/ListTest.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     public function setUp()
20 20
     {
21 21
         exec('protoc 2>&1', $out);
22
-        if (strpos(join("\n", $out), '--php_out') === false) {
22
+        if (strpos(join("\n", $out), '--php_out') === false){
23 23
             $this->markTestSkipped('Protoc binary is missing');
24 24
             return;
25 25
         }
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
         parent::setUp();
28 28
 
29 29
         $fs = new Files();
30
-        $this->proto = $fs->normalizePath($this->app->dir('app') . 'proto/service.proto');
30
+        $this->proto = $fs->normalizePath($this->app->dir('app').'proto/service.proto');
31 31
 
32 32
         // protoc can't figure relative paths
33 33
         $this->proto = str_replace('Framework/../', '', $this->proto);
@@ -39,12 +39,12 @@  discard block
 block discarded – undo
39 39
 
40 40
         $fs = new Files();
41 41
 
42
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
43
-            $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
42
+        if ($fs->isDirectory($this->app->dir('app').'src/Service')){
43
+            $fs->deleteDirectory($this->app->dir('app').'src/Service');
44 44
         }
45 45
 
46
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
47
-            $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
46
+        if ($fs->isDirectory($this->app->dir('app').'src/GPBMetadata')){
47
+            $fs->deleteDirectory($this->app->dir('app').'src/GPBMetadata');
48 48
         }
49 49
     }
50 50
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             'proto' => $this->proto
62 62
         ]);
63 63
 
64
-        file_put_contents($this->app->dir('app') . 'src/Service/EchoService.php', GenerateTest::SERVICE);
64
+        file_put_contents($this->app->dir('app').'src/Service/EchoService.php', GenerateTest::SERVICE);
65 65
 
66 66
         $out = $this->runCommandDebug('grpc:services');
67 67
 
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -19,7 +19,8 @@  discard block
 block discarded – undo
19 19
     public function setUp()
20 20
     {
21 21
         exec('protoc 2>&1', $out);
22
-        if (strpos(join("\n", $out), '--php_out') === false) {
22
+        if (strpos(join("\n", $out), '--php_out') === false)
23
+        {
23 24
             $this->markTestSkipped('Protoc binary is missing');
24 25
             return;
25 26
         }
@@ -39,11 +40,13 @@  discard block
 block discarded – undo
39 40
 
40 41
         $fs = new Files();
41 42
 
42
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
43
+        if ($fs->isDirectory($this->app->dir('app') . 'src/Service'))
44
+        {
43 45
             $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
44 46
         }
45 47
 
46
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
48
+        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata'))
49
+        {
47 50
             $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
48 51
         }
49 52
     }
Please login to merge, or discard this patch.
tests/Framework/GRPC/DispatcherTest.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -21,14 +21,14 @@  discard block
 block discarded – undo
21 21
     public function setUp()
22 22
     {
23 23
         exec('protoc 2>&1', $out);
24
-        if (strpos(join("\n", $out), '--php_out') === false) {
24
+        if (strpos(join("\n", $out), '--php_out') === false){
25 25
             $this->markTestSkipped('Protoc binary is missing');
26 26
         }
27 27
 
28 28
         parent::setUp();
29 29
 
30 30
         $fs = new Files();
31
-        $proto = $fs->normalizePath($this->app->dir('app') . 'proto/service.proto');
31
+        $proto = $fs->normalizePath($this->app->dir('app').'proto/service.proto');
32 32
 
33 33
         // protoc can't figure relative paths
34 34
         $proto = str_replace('Framework/../', '', $proto);
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
             'proto' => $proto
38 38
         ]);
39 39
 
40
-        file_put_contents($this->app->dir('app') . 'src/Service/EchoService.php', GenerateTest::SERVICE);
40
+        file_put_contents($this->app->dir('app').'src/Service/EchoService.php', GenerateTest::SERVICE);
41 41
     }
42 42
 
43 43
     public function tearDown()
@@ -46,12 +46,12 @@  discard block
 block discarded – undo
46 46
 
47 47
         $fs = new Files();
48 48
 
49
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
50
-            $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
49
+        if ($fs->isDirectory($this->app->dir('app').'src/Service')){
50
+            $fs->deleteDirectory($this->app->dir('app').'src/Service');
51 51
         }
52 52
 
53
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
54
-            $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
53
+        if ($fs->isDirectory($this->app->dir('app').'src/GPBMetadata')){
54
+            $fs->deleteDirectory($this->app->dir('app').'src/GPBMetadata');
55 55
         }
56 56
     }
57 57
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
         $msg->setMsg("hello");
78 78
 
79 79
         $w->shouldReceive('receive')->once()->with(
80
-            \Mockery::on(function (&$context) {
80
+            \Mockery::on(function (&$context){
81 81
                 $context = '{
82 82
                   "service": "service.Echo",
83 83
                   "method": "Ping"               
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         )->andReturn($msg->serializeToString());
89 89
 
90 90
         $w->shouldReceive('send')->once()->with(
91
-            \Mockery::on(function ($out) {
91
+            \Mockery::on(function ($out){
92 92
 
93 93
                 $msg = new Message();
94 94
                 $msg->mergeFromString($out);
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
         // one command only
102 102
         $w->shouldReceive('receive')->once()->with(
103
-            \Mockery::on(function (&$context) {
103
+            \Mockery::on(function (&$context){
104 104
                 $context = null;
105 105
                 return true;
106 106
             })
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
         $msg->setMsg("hello");
121 121
 
122 122
         $w->shouldReceive('receive')->once()->with(
123
-            \Mockery::on(function (&$context) {
123
+            \Mockery::on(function (&$context){
124 124
                 $context = '{
125 125
                   "service": "service.Echo",
126 126
                   "method": "Invalid"               
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
         )->andReturn($msg->serializeToString());
132 132
 
133 133
         $w->shouldReceive('error')->once()->with(
134
-            \Mockery::on(function ($out) {
134
+            \Mockery::on(function ($out){
135 135
                 $this->assertContains('Method `Invalid` not found', $out);
136 136
                 return true;
137 137
             })
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
 
140 140
         // one command only
141 141
         $w->shouldReceive('receive')->once()->with(
142
-            \Mockery::on(function (&$context) {
142
+            \Mockery::on(function (&$context){
143 143
                 $context = null;
144 144
                 return true;
145 145
             })
Please login to merge, or discard this patch.
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,7 +21,8 @@  discard block
 block discarded – undo
21 21
     public function setUp()
22 22
     {
23 23
         exec('protoc 2>&1', $out);
24
-        if (strpos(join("\n", $out), '--php_out') === false) {
24
+        if (strpos(join("\n", $out), '--php_out') === false)
25
+        {
25 26
             $this->markTestSkipped('Protoc binary is missing');
26 27
         }
27 28
 
@@ -46,11 +47,13 @@  discard block
 block discarded – undo
46 47
 
47 48
         $fs = new Files();
48 49
 
49
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
50
+        if ($fs->isDirectory($this->app->dir('app') . 'src/Service'))
51
+        {
50 52
             $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
51 53
         }
52 54
 
53
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
55
+        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata'))
56
+        {
54 57
             $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
55 58
         }
56 59
     }
@@ -77,7 +80,8 @@  discard block
 block discarded – undo
77 80
         $msg->setMsg("hello");
78 81
 
79 82
         $w->shouldReceive('receive')->once()->with(
80
-            \Mockery::on(function (&$context) {
83
+            \Mockery::on(function (&$context)
84
+            {
81 85
                 $context = '{
82 86
                   "service": "service.Echo",
83 87
                   "method": "Ping"               
@@ -88,7 +92,8 @@  discard block
 block discarded – undo
88 92
         )->andReturn($msg->serializeToString());
89 93
 
90 94
         $w->shouldReceive('send')->once()->with(
91
-            \Mockery::on(function ($out) {
95
+            \Mockery::on(function ($out)
96
+            {
92 97
 
93 98
                 $msg = new Message();
94 99
                 $msg->mergeFromString($out);
@@ -100,7 +105,8 @@  discard block
 block discarded – undo
100 105
 
101 106
         // one command only
102 107
         $w->shouldReceive('receive')->once()->with(
103
-            \Mockery::on(function (&$context) {
108
+            \Mockery::on(function (&$context)
109
+            {
104 110
                 $context = null;
105 111
                 return true;
106 112
             })
@@ -120,7 +126,8 @@  discard block
 block discarded – undo
120 126
         $msg->setMsg("hello");
121 127
 
122 128
         $w->shouldReceive('receive')->once()->with(
123
-            \Mockery::on(function (&$context) {
129
+            \Mockery::on(function (&$context)
130
+            {
124 131
                 $context = '{
125 132
                   "service": "service.Echo",
126 133
                   "method": "Invalid"               
@@ -131,7 +138,8 @@  discard block
 block discarded – undo
131 138
         )->andReturn($msg->serializeToString());
132 139
 
133 140
         $w->shouldReceive('error')->once()->with(
134
-            \Mockery::on(function ($out) {
141
+            \Mockery::on(function ($out)
142
+            {
135 143
                 $this->assertContains('Method `Invalid` not found', $out);
136 144
                 return true;
137 145
             })
@@ -139,7 +147,8 @@  discard block
 block discarded – undo
139 147
 
140 148
         // one command only
141 149
         $w->shouldReceive('receive')->once()->with(
142
-            \Mockery::on(function (&$context) {
150
+            \Mockery::on(function (&$context)
151
+            {
143 152
                 $context = null;
144 153
                 return true;
145 154
             })
Please login to merge, or discard this patch.
tests/Framework/GRPC/GenerateTest.php 2 patches
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -32,14 +32,14 @@  discard block
 block discarded – undo
32 32
     public function setUp()
33 33
     {
34 34
         exec('protoc 2>&1', $out);
35
-        if (strpos(join("\n", $out), '--php_out') === false) {
35
+        if (strpos(join("\n", $out), '--php_out') === false){
36 36
             $this->markTestSkipped('Protoc binary is missing');
37 37
         }
38 38
 
39 39
         parent::setUp();
40 40
 
41 41
         $fs = new Files();
42
-        $this->proto = $fs->normalizePath($this->app->dir('app') . 'proto/service.proto');
42
+        $this->proto = $fs->normalizePath($this->app->dir('app').'proto/service.proto');
43 43
 
44 44
         // protoc can't figure relative paths
45 45
         $this->proto = str_replace('Framework/../', '', $this->proto);
@@ -51,12 +51,12 @@  discard block
 block discarded – undo
51 51
 
52 52
         $fs = new Files();
53 53
 
54
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
55
-            $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
54
+        if ($fs->isDirectory($this->app->dir('app').'src/Service')){
55
+            $fs->deleteDirectory($this->app->dir('app').'src/Service');
56 56
         }
57 57
 
58
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
59
-            $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
58
+        if ($fs->isDirectory($this->app->dir('app').'src/GPBMetadata')){
59
+            $fs->deleteDirectory($this->app->dir('app').'src/GPBMetadata');
60 60
         }
61 61
     }
62 62
 
@@ -84,8 +84,8 @@  discard block
 block discarded – undo
84 84
             'proto' => $this->proto
85 85
         ]);
86 86
 
87
-        $this->assertFileExists($this->app->dir('app') . 'src/Service/EchoInterface.php');
88
-        $this->assertFileExists($this->app->dir('app') . 'src/Service/Message.php');
89
-        $this->assertFileExists($this->app->dir('app') . 'src/GPBMetadata/Service.php');
87
+        $this->assertFileExists($this->app->dir('app').'src/Service/EchoInterface.php');
88
+        $this->assertFileExists($this->app->dir('app').'src/Service/Message.php');
89
+        $this->assertFileExists($this->app->dir('app').'src/GPBMetadata/Service.php');
90 90
     }
91 91
 }
92 92
\ No newline at end of file
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,8 @@  discard block
 block discarded – undo
32 32
     public function setUp()
33 33
     {
34 34
         exec('protoc 2>&1', $out);
35
-        if (strpos(join("\n", $out), '--php_out') === false) {
35
+        if (strpos(join("\n", $out), '--php_out') === false)
36
+        {
36 37
             $this->markTestSkipped('Protoc binary is missing');
37 38
         }
38 39
 
@@ -51,11 +52,13 @@  discard block
 block discarded – undo
51 52
 
52 53
         $fs = new Files();
53 54
 
54
-        if ($fs->isDirectory($this->app->dir('app') . 'src/Service')) {
55
+        if ($fs->isDirectory($this->app->dir('app') . 'src/Service'))
56
+        {
55 57
             $fs->deleteDirectory($this->app->dir('app') . 'src/Service');
56 58
         }
57 59
 
58
-        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata')) {
60
+        if ($fs->isDirectory($this->app->dir('app') . 'src/GPBMetadata'))
61
+        {
59 62
             $fs->deleteDirectory($this->app->dir('app') . 'src/GPBMetadata');
60 63
         }
61 64
     }
Please login to merge, or discard this patch.