Inspection of "Merge pull request #1098 from spiral/hotfix/stempl..." - spiral/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 819a09...a8d0c9 )

by butschster

created 2024-04-03 06:20 UTC

Status

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -23,7 +23,7 @@  discard block
 block discarded – undo
 
     public function handle(Parser $parser, Assembler $asm, Token $token): void
     {
-        switch ($token->type) {
+        switch ($token->type){
             case DynamicGrammar::TYPE_DIRECTIVE:
                 $this->directive = new Directive(new Parser\Context($token, $parser->getPath()));
                 $asm->push($this->directive);
@@ -48,20 +48,20 @@  discard block
 block discarded – undo
                 break;
 
             case DynamicGrammar::TYPE_KEYWORD:
-                if ($this->directive !== null) {
+                if ($this->directive !== null){
                     $this->directive->name = $token->content;
                 }
                 break;
 
             case DynamicGrammar::TYPE_BODY:
-                if ($this->directive !== null) {
+                if ($this->directive !== null){
                     $this->directive->body = $token->content;
                     $this->directive->values = $this->fetchValues($this->directive->body);
 
                     $this->directive = null;
                 }
 
-                if ($this->output !== null) {
+                if ($this->output !== null){
                     $this->output->body = $token->content;
                 }
 
@@ -79,31 +79,31 @@  discard block
 block discarded – undo
 
         $src = new StringStream($body);
 
-        while ($n = $src->peak()) {
-            if (\in_array($n, ['"', "'"], true)) {
+        while ($n = $src->peak()){
+            if (\in_array($n, ['"', "'"], true)){
                 $values[\count($values) - 1] .= $n;
-                while (($nn = $src->peak()) !== null) {
+                while (($nn = $src->peak()) !== null){
                     $values[\count($values) - 1] .= $nn;
-                    if ($nn === $n) {
+                    if ($nn === $n){
                         break;
                     }
                 }
                 continue;
             }
 
-            if ($n === ',' && $level === 0) {
+            if ($n === ',' && $level === 0){
                 $values[] = '';
                 continue;
             }
 
             $values[\count($values) - 1] .= $n;
 
-            if ($n === '(' || $n === '[' || $n === '{') {
+            if ($n === '(' || $n === '[' || $n === '{'){
                 $level++;
                 continue;
             }
 
-            if ($n === ')' || $n === ']' || $n === '}') {
+            if ($n === ')' || $n === ']' || $n === '}'){
                 $level--;
             }
         }

Please login to merge, or discard this patch.

Braces +22 added lines, -11 removed lines patch added patch discarded remove patch

@@ -23,7 +23,8 @@  discard block
 block discarded – undo
 
     public function handle(Parser $parser, Assembler $asm, Token $token): void
     {
-        switch ($token->type) {
+        switch ($token->type)
+        {
             case DynamicGrammar::TYPE_DIRECTIVE:
                 $this->directive = new Directive(new Parser\Context($token, $parser->getPath()));
                 $asm->push($this->directive);
@@ -48,20 +49,23 @@  discard block
 block discarded – undo
                 break;
 
             case DynamicGrammar::TYPE_KEYWORD:
-                if ($this->directive !== null) {
+                if ($this->directive !== null)
+                {
                     $this->directive->name = $token->content;
                 }
                 break;
 
             case DynamicGrammar::TYPE_BODY:
-                if ($this->directive !== null) {
+                if ($this->directive !== null)
+                {
                     $this->directive->body = $token->content;
                     $this->directive->values = $this->fetchValues($this->directive->body);
 
                     $this->directive = null;
                 }
 
-                if ($this->output !== null) {
+                if ($this->output !== null)
+                {
                     $this->output->body = $token->content;
                 }
 
@@ -79,31 +83,38 @@  discard block
 block discarded – undo
 
         $src = new StringStream($body);
 
-        while ($n = $src->peak()) {
-            if (\in_array($n, ['"', "'"], true)) {
+        while ($n = $src->peak())
+        {
+            if (\in_array($n, ['"', "'"], true))
+            {
                 $values[\count($values) - 1] .= $n;
-                while (($nn = $src->peak()) !== null) {
+                while (($nn = $src->peak()) !== null)
+                {
                     $values[\count($values) - 1] .= $nn;
-                    if ($nn === $n) {
+                    if ($nn === $n)
+                    {
                         break;
                     }
                 }
                 continue;
             }
 
-            if ($n === ',' && $level === 0) {
+            if ($n === ',' && $level === 0)
+            {
                 $values[] = '';
                 continue;
             }
 
             $values[\count($values) - 1] .= $n;
 
-            if ($n === '(' || $n === '[' || $n === '{') {
+            if ($n === '(' || $n === '[' || $n === '{')
+            {
                 $level++;
                 continue;
             }
 
-            if ($n === ')' || $n === ']' || $n === '}') {
+            if ($n === ')' || $n === ']' || $n === '}')
+            {
                 $level--;
             }
         }

Please login to merge, or discard this patch.

src/Stempler/tests/fixtures/ImageDirective.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@
 block discarded – undo
         return \sprintf(
             '<img title=%s src=%s size=%s type=%s>',
             $directive->values[0],
-            \str_starts_with($directive->values[1], '$') ? \sprintf('"<?php echo %s; ?>"', $directive->values[1]) :  $directive->values[1],
+            \str_starts_with($directive->values[1], '$') ? \sprintf('"<?php echo %s; ?>"', $directive->values[1]) : $directive->values[1],
             $directive->values[2],
             $directive->values[3],
         );

Please login to merge, or discard this patch.

		@@ -23,7 +23,7 @@ discard block
		block discarded – undo
23	23
24	24	public function handle(Parser $parser, Assembler $asm, Token $token): void
25	25	{
26		- switch ($token->type) {
	26	+ switch ($token->type){
27	27	case DynamicGrammar::TYPE_DIRECTIVE:
28	28	$this->directive = new Directive(new Parser\Context($token, $parser->getPath()));
29	29	$asm->push($this->directive);
		@@ -48,20 +48,20 @@ discard block
		block discarded – undo
48	48	break;
49	49
50	50	case DynamicGrammar::TYPE_KEYWORD:
51		- if ($this->directive !== null) {
	51	+ if ($this->directive !== null){
52	52	$this->directive->name = $token->content;
53	53	}
54	54	break;
55	55
56	56	case DynamicGrammar::TYPE_BODY:
57		- if ($this->directive !== null) {
	57	+ if ($this->directive !== null){
58	58	$this->directive->body = $token->content;
59	59	$this->directive->values = $this->fetchValues($this->directive->body);
60	60
61	61	$this->directive = null;
62	62	}
63	63
64		- if ($this->output !== null) {
	64	+ if ($this->output !== null){
65	65	$this->output->body = $token->content;
66	66	}
67	67
		@@ -79,31 +79,31 @@ discard block
		block discarded – undo
79	79
80	80	$src = new StringStream($body);
81	81
82		- while ($n = $src->peak()) {
83		- if (\in_array($n, ['"', "'"], true)) {
	82	+ while ($n = $src->peak()){
	83	+ if (\in_array($n, ['"', "'"], true)){
84	84	$values[\count($values) - 1] .= $n;
85		- while (($nn = $src->peak()) !== null) {
	85	+ while (($nn = $src->peak()) !== null){
86	86	$values[\count($values) - 1] .= $nn;
87		- if ($nn === $n) {
	87	+ if ($nn === $n){
88	88	break;
89	89	}
90	90	}
91	91	continue;
92	92	}
93	93
94		- if ($n === ',' && $level === 0) {
	94	+ if ($n === ',' && $level === 0){
95	95	$values[] = '';
96	96	continue;
97	97	}
98	98
99	99	$values[\count($values) - 1] .= $n;
100	100
101		- if ($n === '(' \|\| $n === '[' \|\| $n === '{') {
	101	+ if ($n === '(' \|\| $n === '[' \|\| $n === '{'){
102	102	$level++;
103	103	continue;
104	104	}
105	105
106		- if ($n === ')' \|\| $n === ']' \|\| $n === '}') {
	106	+ if ($n === ')' \|\| $n === ']' \|\| $n === '}'){
107	107	$level--;
108	108	}
109	109	}

		@@ -23,7 +23,8 @@ discard block
		block discarded – undo
23	23
24	24	public function handle(Parser $parser, Assembler $asm, Token $token): void
25	25	{
26		- switch ($token->type) {
	26	+ switch ($token->type)
	27	+ {
27	28	case DynamicGrammar::TYPE_DIRECTIVE:
28	29	$this->directive = new Directive(new Parser\Context($token, $parser->getPath()));
29	30	$asm->push($this->directive);
		@@ -48,20 +49,23 @@ discard block
		block discarded – undo
48	49	break;
49	50
50	51	case DynamicGrammar::TYPE_KEYWORD:
51		- if ($this->directive !== null) {
	52	+ if ($this->directive !== null)
	53	+ {
52	54	$this->directive->name = $token->content;
53	55	}
54	56	break;
55	57
56	58	case DynamicGrammar::TYPE_BODY:
57		- if ($this->directive !== null) {
	59	+ if ($this->directive !== null)
	60	+ {
58	61	$this->directive->body = $token->content;
59	62	$this->directive->values = $this->fetchValues($this->directive->body);
60	63
61	64	$this->directive = null;
62	65	}
63	66
64		- if ($this->output !== null) {
	67	+ if ($this->output !== null)
	68	+ {
65	69	$this->output->body = $token->content;
66	70	}
67	71
		@@ -79,31 +83,38 @@ discard block
		block discarded – undo
79	83
80	84	$src = new StringStream($body);
81	85
82		- while ($n = $src->peak()) {
83		- if (\in_array($n, ['"', "'"], true)) {
	86	+ while ($n = $src->peak())
	87	+ {
	88	+ if (\in_array($n, ['"', "'"], true))
	89	+ {
84	90	$values[\count($values) - 1] .= $n;
85		- while (($nn = $src->peak()) !== null) {
	91	+ while (($nn = $src->peak()) !== null)
	92	+ {
86	93	$values[\count($values) - 1] .= $nn;
87		- if ($nn === $n) {
	94	+ if ($nn === $n)
	95	+ {
88	96	break;
89	97	}
90	98	}
91	99	continue;
92	100	}
93	101
94		- if ($n === ',' && $level === 0) {
	102	+ if ($n === ',' && $level === 0)
	103	+ {
95	104	$values[] = '';
96	105	continue;
97	106	}
98	107
99	108	$values[\count($values) - 1] .= $n;
100	109
101		- if ($n === '(' \|\| $n === '[' \|\| $n === '{') {
	110	+ if ($n === '(' \|\| $n === '[' \|\| $n === '{')
	111	+ {
102	112	$level++;
103	113	continue;
104	114	}
105	115
106		- if ($n === ')' \|\| $n === ']' \|\| $n === '}') {
	116	+ if ($n === ')' \|\| $n === ']' \|\| $n === '}')
	117	+ {
107	118	$level--;
108	119	}
109	120	}

		@@ -14,7 +14,7 @@
		block discarded – undo
14	14	return \sprintf(
15	15	'<img title=%s src=%s size=%s type=%s>',
16	16	$directive->values[0],
17		- \str_starts_with($directive->values[1], '$') ? \sprintf('"<?php echo %s; ?>"', $directive->values[1]) : $directive->values[1],
	17	+ \str_starts_with($directive->values[1], '$') ? \sprintf('"<?php echo %s; ?>"', $directive->values[1]) : $directive->values[1],
18	18	$directive->values[2],
19	19	$directive->values[3],
20	20	);

spiral / framework

Push — master ( 819a09...a8d0c9 )

Status

Category

Spacing +11 added lines, -11 removed lines patch added patch discarded remove patch

Braces +22 added lines, -11 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch