spiral / framework

src/Core/src/Internal/Factory.php

Spacing +38 added lines, -38 removed lines

@@ -54,35 +54,35 @@ 
      */
     public function make(string $alias, array $parameters = [], string $context = null): mixed
     {
-        if (!isset($this->state->bindings[$alias])) {
+        if (!isset($this->state->bindings[$alias])){
             $this->tracer->push(false, action: 'autowire', alias: $alias, context: $context);
-            try {
+            try{
                 //No direct instructions how to construct class, make is automatically
                 return $this->autowire($alias, $parameters, $context);
-            } finally {
+            }finally{
                 $this->tracer->pop(false);
             }
         }
 
         $binding = $this->state->bindings[$alias];
-        try {
+        try{
             $this->tracer->push(false, action: 'resolve from binding', alias: $alias, context: $context, binding: $binding);
             $this->tracer->push(true);
 
-            if (\is_object($binding)) {
-                if ($binding::class === WeakReference::class) {
-                    if ($binding->get() === null && \class_exists($alias)) {
-                        try {
+            if (\is_object($binding)){
+                if ($binding::class === WeakReference::class){
+                    if ($binding->get() === null && \class_exists($alias)){
+                        try{
                             $this->tracer->push(false, alias: $alias, source: WeakReference::class, context: $context);
                             $object = $this->createInstance($alias, $parameters, $context);
                             $binding = $this->state->bindings[$alias] = WeakReference::create($object);
-                        } catch (\Throwable) {
+                        }catch (\Throwable){
                             throw new ContainerException($this->tracer->combineTraceMessage(\sprintf(
                                 'Can\'t resolve `%s`: can\'t instantiate `%s` from WeakReference binding.',
                                 $this->tracer->getRootAlias(),
                                 $alias,
                             )));
-                        } finally {
+                        }finally{
                             $this->tracer->pop();
                         }
                     }
@@ -92,26 +92,26 @@ 
                 return $binding;
             }
 
-            if (\is_string($binding)) {
+            if (\is_string($binding)){
                 //Binding is pointing to something else
                 return $this->make($binding, $parameters, $context);
             }
 
             unset($this->state->bindings[$alias]);
-            try {
+            try{
                 $instance = $binding[0] === $alias
                     ? $this->autowire($alias, $parameters, $context)
                     : $this->evaluateBinding($alias, $binding[0], $parameters, $context);
-            } finally {
+            }finally{
                 /** @psalm-var class-string $alias */
                 $this->state->bindings[$alias] = $binding;
             }
-        } finally {
+        }finally{
             $this->tracer->pop(true);
             $this->tracer->pop(false);
         }
 
-        if ($binding[1]) {
+        if ($binding[1]){
             // Indicates singleton
             /** @psalm-var class-string $alias */
             $this->state->bindings[$alias] = $instance;
@@ -135,7 +135,7 @@ 
                 &&
                 (isset($this->state->injectors[$class]) || $this->binder->hasInjector($class))
         ))
-        ) {
+        ){
             throw new NotFoundException($this->tracer->combineTraceMessage(\sprintf(
                 'Can\'t resolve `%s`: undefined class or binding `%s`.',
                 $this->tracer->getRootAlias(),
@@ -162,18 +162,18 @@ 
         array $parameters,
         string $context = null
     ): mixed {
-        if (\is_string($target)) {
+        if (\is_string($target)){
             // Reference
             return $this->make($target, $parameters, $context);
         }
 
-        if ($target instanceof Autowire) {
+        if ($target instanceof Autowire){
             return $target->resolve($this, $parameters);
         }
 
-        try {
+        try{
             return $this->invoker->invoke($target, $parameters);
-        } catch (NotCallableException $e) {
+        }catch (NotCallableException $e){
             throw new ContainerException(
                 $this->tracer->combineTraceMessage(\sprintf('Invalid binding for `%s`.', $alias)),
                 $e->getCode(),
@@ -197,20 +197,20 @@ 
      */
     private function createInstance(string $class, array $parameters, string $context = null): object
     {
-        try {
+        try{
             $reflection = new \ReflectionClass($class);
-        } catch (\ReflectionException $e) {
+        }catch (\ReflectionException $e){
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
         }
 
         //We have to construct class using external injector when we know exact context
-        if ($parameters === [] && $this->binder->hasInjector($class)) {
+        if ($parameters === [] && $this->binder->hasInjector($class)){
             $injector = $this->state->injectors[$reflection->getName()];
 
-            try {
+            try{
                 $injectorInstance = $this->container->get($injector);
 
-                if (!$injectorInstance instanceof InjectorInterface) {
+                if (!$injectorInstance instanceof InjectorInterface){
                     throw new InjectionException(
                         \sprintf(
                             "Class '%s' must be an instance of InjectorInterface for '%s'.",
@@ -222,7 +222,7 @@ 
 
                 /** @var InjectorInterface<TObject> $injectorInstance */
                 $instance = $injectorInstance->createInjection($reflection, $context);
-                if (!$reflection->isInstance($instance)) {
+                if (!$reflection->isInstance($instance)){
                     throw new InjectionException(
                         \sprintf(
                             "Invalid injection response for '%s'.",
@@ -232,12 +232,12 @@ 
                 }
 
                 return $instance;
-            } finally {
+            }finally{
                 $this->state->injectors[$reflection->getName()] = $injector;
             }
         }
 
-        if (!$reflection->isInstantiable()) {
+        if (!$reflection->isInstantiable()){
             $itIs = match (true) {
                 $reflection->isEnum() => 'Enum',
                 $reflection->isAbstract() => 'Abstract class',
@@ -250,12 +250,12 @@ 
 
         $constructor = $reflection->getConstructor();
 
-        if ($constructor !== null) {
-            try {
+        if ($constructor !== null){
+            try{
                 $this->tracer->push(false, action: 'resolve arguments', signature: $constructor);
                 $this->tracer->push(true);
                 $arguments = $this->resolver->resolveArguments($constructor, $parameters);
-            } catch (ValidationException $e) {
+            }catch (ValidationException $e){
                 throw new ContainerException(
                     $this->tracer->combineTraceMessage(
                         \sprintf(
@@ -265,22 +265,22 @@ 
                         )
                     ),
                 );
-            } finally {
+            }finally{
                 $this->tracer->pop(true);
                 $this->tracer->pop(false);
             }
-            try {
+            try{
                 // Using constructor with resolved arguments
                 $this->tracer->push(false, call: "$class::__construct", arguments: $arguments);
                 $this->tracer->push(true);
                 $instance = new $class(...$arguments);
-            } catch (\TypeError $e) {
+            }catch (\TypeError $e){
                 throw new WrongTypeException($constructor, $e);
-            } finally {
+            }finally{
                 $this->tracer->pop(true);
                 $this->tracer->pop(false);
             }
-        } else {
+        }else{
             // No constructor specified
             $instance = $reflection->newInstance();
         }
@@ -298,9 +298,9 @@ 
     private function registerInstance(object $instance, array $parameters): object
     {
         //Declarative singletons (only when class received via direct get)
-        if ($parameters === [] && $instance instanceof SingletonInterface) {
+        if ($parameters === [] && $instance instanceof SingletonInterface){
             $alias = $instance::class;
-            if (!isset($this->state->bindings[$alias])) {
+            if (!isset($this->state->bindings[$alias])){
                 $this->state->bindings[$alias] = $instance;
             }
         }

Braces +87 added lines, -37 removed lines

@@ -54,35 +54,48 @@ 
      */
     public function make(string $alias, array $parameters = [], string $context = null): mixed
     {
-        if (!isset($this->state->bindings[$alias])) {
+        if (!isset($this->state->bindings[$alias]))
+        {
             $this->tracer->push(false, action: 'autowire', alias: $alias, context: $context);
-            try {
+            try
+            {
                 //No direct instructions how to construct class, make is automatically
                 return $this->autowire($alias, $parameters, $context);
-            } finally {
+            }
+            finally
+            {
                 $this->tracer->pop(false);
             }
         }
 
         $binding = $this->state->bindings[$alias];
-        try {
+        try
+        {
             $this->tracer->push(false, action: 'resolve from binding', alias: $alias, context: $context, binding: $binding);
             $this->tracer->push(true);
 
-            if (\is_object($binding)) {
-                if ($binding::class === WeakReference::class) {
-                    if ($binding->get() === null && \class_exists($alias)) {
-                        try {
+            if (\is_object($binding))
+            {
+                if ($binding::class === WeakReference::class)
+                {
+                    if ($binding->get() === null && \class_exists($alias))
+                    {
+                        try
+                        {
                             $this->tracer->push(false, alias: $alias, source: WeakReference::class, context: $context);
                             $object = $this->createInstance($alias, $parameters, $context);
                             $binding = $this->state->bindings[$alias] = WeakReference::create($object);
-                        } catch (\Throwable) {
+                        }
+                        catch (\Throwable)
+                        {
                             throw new ContainerException($this->tracer->combineTraceMessage(\sprintf(
                                 'Can\'t resolve `%s`: can\'t instantiate `%s` from WeakReference binding.',
                                 $this->tracer->getRootAlias(),
                                 $alias,
                             )));
-                        } finally {
+                        }
+                        finally
+                        {
                             $this->tracer->pop();
                         }
                     }
@@ -92,26 +105,33 @@ 
                 return $binding;
             }
 
-            if (\is_string($binding)) {
+            if (\is_string($binding))
+            {
                 //Binding is pointing to something else
                 return $this->make($binding, $parameters, $context);
             }
 
             unset($this->state->bindings[$alias]);
-            try {
+            try
+            {
                 $instance = $binding[0] === $alias
                     ? $this->autowire($alias, $parameters, $context)
                     : $this->evaluateBinding($alias, $binding[0], $parameters, $context);
-            } finally {
+            }
+            finally
+            {
                 /** @psalm-var class-string $alias */
                 $this->state->bindings[$alias] = $binding;
             }
-        } finally {
+        }
+        finally
+        {
             $this->tracer->pop(true);
             $this->tracer->pop(false);
         }
 
-        if ($binding[1]) {
+        if ($binding[1])
+        {
             // Indicates singleton
             /** @psalm-var class-string $alias */
             $this->state->bindings[$alias] = $instance;
@@ -162,18 +182,23 @@ 
         array $parameters,
         string $context = null
     ): mixed {
-        if (\is_string($target)) {
+        if (\is_string($target))
+        {
             // Reference
             return $this->make($target, $parameters, $context);
         }
 
-        if ($target instanceof Autowire) {
+        if ($target instanceof Autowire)
+        {
             return $target->resolve($this, $parameters);
         }
 
-        try {
+        try
+        {
             return $this->invoker->invoke($target, $parameters);
-        } catch (NotCallableException $e) {
+        }
+        catch (NotCallableException $e)
+        {
             throw new ContainerException(
                 $this->tracer->combineTraceMessage(\sprintf('Invalid binding for `%s`.', $alias)),
                 $e->getCode(),
@@ -197,20 +222,26 @@ 
      */
     private function createInstance(string $class, array $parameters, string $context = null): object
     {
-        try {
+        try
+        {
             $reflection = new \ReflectionClass($class);
-        } catch (\ReflectionException $e) {
+        }
+        catch (\ReflectionException $e)
+        {
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
         }
 
         //We have to construct class using external injector when we know exact context
-        if ($parameters === [] && $this->binder->hasInjector($class)) {
+        if ($parameters === [] && $this->binder->hasInjector($class))
+        {
             $injector = $this->state->injectors[$reflection->getName()];
 
-            try {
+            try
+            {
                 $injectorInstance = $this->container->get($injector);
 
-                if (!$injectorInstance instanceof InjectorInterface) {
+                if (!$injectorInstance instanceof InjectorInterface)
+                {
                     throw new InjectionException(
                         \sprintf(
                             "Class '%s' must be an instance of InjectorInterface for '%s'.",
@@ -222,7 +253,8 @@ 
 
                 /** @var InjectorInterface<TObject> $injectorInstance */
                 $instance = $injectorInstance->createInjection($reflection, $context);
-                if (!$reflection->isInstance($instance)) {
+                if (!$reflection->isInstance($instance))
+                {
                     throw new InjectionException(
                         \sprintf(
                             "Invalid injection response for '%s'.",
@@ -232,12 +264,15 @@ 
                 }
 
                 return $instance;
-            } finally {
+            }
+            finally
+            {
                 $this->state->injectors[$reflection->getName()] = $injector;
             }
         }
 
-        if (!$reflection->isInstantiable()) {
+        if (!$reflection->isInstantiable())
+        {
             $itIs = match (true) {
                 $reflection->isEnum() => 'Enum',
                 $reflection->isAbstract() => 'Abstract class',
@@ -250,12 +285,16 @@ 
 
         $constructor = $reflection->getConstructor();
 
-        if ($constructor !== null) {
-            try {
+        if ($constructor !== null)
+        {
+            try
+            {
                 $this->tracer->push(false, action: 'resolve arguments', signature: $constructor);
                 $this->tracer->push(true);
                 $arguments = $this->resolver->resolveArguments($constructor, $parameters);
-            } catch (ValidationException $e) {
+            }
+            catch (ValidationException $e)
+            {
                 throw new ContainerException(
                     $this->tracer->combineTraceMessage(
                         \sprintf(
@@ -265,22 +304,31 @@ 
                         )
                     ),
                 );
-            } finally {
+            }
+            finally
+            {
                 $this->tracer->pop(true);
                 $this->tracer->pop(false);
             }
-            try {
+            try
+            {
                 // Using constructor with resolved arguments
                 $this->tracer->push(false, call: "$class::__construct", arguments: $arguments);
                 $this->tracer->push(true);
                 $instance = new $class(...$arguments);
-            } catch (\TypeError $e) {
+            }
+            catch (\TypeError $e)
+            {
                 throw new WrongTypeException($constructor, $e);
-            } finally {
+            }
+            finally
+            {
                 $this->tracer->pop(true);
                 $this->tracer->pop(false);
             }
-        } else {
+        }
+        else
+        {
             // No constructor specified
             $instance = $reflection->newInstance();
         }
@@ -298,9 +346,11 @@ 
     private function registerInstance(object $instance, array $parameters): object
     {
         //Declarative singletons (only when class received via direct get)
-        if ($parameters === [] && $instance instanceof SingletonInterface) {
+        if ($parameters === [] && $instance instanceof SingletonInterface)
+        {
             $alias = $instance::class;
-            if (!isset($this->state->bindings[$alias])) {
+            if (!isset($this->state->bindings[$alias]))
+            {
                 $this->state->bindings[$alias] = $instance;
             }
         }