View GitHub Repository framework

Schedule Inspection
Subscribe
Passed
Pull Request — master (#1102)
by Aleksei
11:46 queued 01:49
created
Status
Category
Toggle Patches
src/Bridge/Monolog/src/LogFactory.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@  discard block
 
 block discarded – undo
32 32 
         private readonly MonologConfig $config,
33 33 
         ListenerRegistryInterface $listenerRegistry,
34 34 
         private readonly FactoryInterface $factory
35 
-    ) {
35 
+    ){
36 36 
         $this->eventHandler = new EventHandler($listenerRegistry, $config->getEventLevel());
37 37 
     }
38 38 
 
@@ -40,8 +40,8 @@  discard block
 
 block discarded – undo
40 40 
     {
41 41 
         $default = $this->config->getDefault();
42 42
43 
-        if ($channel === null || $channel === $default) {
44 
-            if ($this->default !== null) {
43 
+        if ($channel === null || $channel === $default){
44 
+            if ($this->default !== null){
45 45 
                 // we should use only one default logger per system
46 46 
                 return $this->default;
47 47 
             }
 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62
63 63 
     public function createInjection(
64 64 
         \ReflectionClass $class,
65 
-        \ReflectionParameter|null|string $context = null
65 
+        \ReflectionParameter | null | string $context = null
66 66 
     ): LoggerInterface {
67 67 
         $channel = \is_object($context) ? $this->extractChannelAttribute($context) : null;
68 68 
 
@@ -72,7 +72,7 @@  discard block
 
 block discarded – undo
72 72
73 73 
     public function reset(): void
74 74 
     {
75 
-        if ($this->default instanceof ResettableInterface) {
75 
+        if ($this->default instanceof ResettableInterface){
76 76 
             $this->default->reset();
77 77 
         }
78 78 
     }
 
@@ -88,15 +88,15 @@  discard block
 
 block discarded – undo
88 88 
         // always include default handler
89 89 
         $handlers = [];
90 90
91 
-        foreach ($this->config->getHandlers($channel) as $handler) {
92 
-            if (!$handler instanceof Autowire) {
91 
+        foreach ($this->config->getHandlers($channel) as $handler){
92 
+            if (!$handler instanceof Autowire){
93 93 
                 $handlers[] = $handler;
94 94 
                 continue;
95 95 
             }
96 96
97 
-            try {
97 
+            try{
98 98 
                 $handlers[] = $handler->resolve($this->factory);
99 
-            } catch (ContainerExceptionInterface $e) {
99 
+            }catch (ContainerExceptionInterface $e){
100 100 
                 throw new ConfigException($e->getMessage(), $e->getCode(), $e);
101 101 
             }
102 102 
         }
 
@@ -114,20 +114,20 @@  discard block
 
 block discarded – undo
114 114 
     protected function getProcessors(string $channel): array
115 115 
     {
116 116 
         $processors = [];
117 
-        foreach ($this->config->getProcessors($channel) as $processor) {
118 
-            if (!$processor instanceof Autowire) {
117 
+        foreach ($this->config->getProcessors($channel) as $processor){
118 
+            if (!$processor instanceof Autowire){
119 119 
                 $processors[] = $processor;
120 120 
                 continue;
121 121 
             }
122 122
123 
-            try {
123 
+            try{
124 124 
                 $processors[] = $processor->resolve($this->factory);
125 
-            } catch (ContainerExceptionInterface $e) {
125 
+            }catch (ContainerExceptionInterface $e){
126 126 
                 throw new ConfigException($e->getMessage(), $e->getCode(), $e);
127 127 
             }
128 128 
         }
129 129
130 
-        if ($processors === []) {
130 
+        if ($processors === []){
131 131 
             $processors[] = new PsrLogMessageProcessor();
132 132 
         }
133 133
Please login to merge, or discard this patch.
src/Bridge/Monolog/tests/FactoryTest.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
         $logger = $factory->getLogger();
56 56
57 57 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
58 
-            new class() implements LoaderInterface {
58 
+            new class() implements LoaderInterface{
59 59 
                 public function has(string $section): bool
60 60 
                 {
61 61 
                     return false;
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
         $factory = new LogFactory(new MonologConfig([]), new ListenerRegistry(), new Container());
84 84
85 85 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
86 
-            new class() implements LoaderInterface {
86 
+            new class() implements LoaderInterface{
87 87 
                 public function has(string $section): bool
88 88 
                 {
89 89 
                     return false;
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
         $this->container->get(StrategyBasedBootloadManager::class)->bootload([MonologBootloader::class]);
103 103 
         $this->container->bind(LogFactory::class, $factory);
104 104
105 
-        $this->container->invoke(function (#[LoggerChannel('foo')] LoggerInterface $logger) {
105 
+        $this->container->invoke(function (#[LoggerChannel('foo')] LoggerInterface $logger){
106 106 
             $this->assertSame('foo', $logger->getName());
107 107 
         });
108 108 
     }
 
@@ -110,7 +110,7 @@  discard block
 
 block discarded – undo
110 110 
     public function testFinalizerShouldResetDefaultLogger()
111 111 
     {
112 112 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
113 
-            new class() implements LoaderInterface {
113 
+            new class() implements LoaderInterface{
114 114 
                 public function has(string $section): bool
115 115 
                 {
116 116 
                     return false;
 
@@ -150,7 +150,7 @@  discard block
 
 block discarded – undo
150 150 
     public function testFinalizerShouldNotResetLoggerWhenApplicationTerminating()
151 151 
     {
152 152 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
153 
-            new class() implements LoaderInterface {
153 
+            new class() implements LoaderInterface{
154 154 
                 public function has(string $section): bool
155 155 
                 {
156 156 
                     return false;
Please login to merge, or discard this patch.
Braces   +10 added lines, -5 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,8 @@  discard block
 
 block discarded – undo
55 55 
         $logger = $factory->getLogger();
56 56
57 57 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
58 
-            new class() implements LoaderInterface {
58 
+            new class() implements LoaderInterface
59 
+            {
59 60 
                 public function has(string $section): bool
60 61 
                 {
61 62 
                     return false;
 
@@ -83,7 +84,8 @@  discard block
 
 block discarded – undo
83 84 
         $factory = new LogFactory(new MonologConfig([]), new ListenerRegistry(), new Container());
84 85
85 86 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
86 
-            new class() implements LoaderInterface {
87 
+            new class() implements LoaderInterface
88 
+            {
87 89 
                 public function has(string $section): bool
88 90 
                 {
89 91 
                     return false;
 
@@ -102,7 +104,8 @@  discard block
 
 block discarded – undo
102 104 
         $this->container->get(StrategyBasedBootloadManager::class)->bootload([MonologBootloader::class]);
103 105 
         $this->container->bind(LogFactory::class, $factory);
104 106
105 
-        $this->container->invoke(function (#[LoggerChannel('foo')] LoggerInterface $logger) {
107 
+        $this->container->invoke(function (#[LoggerChannel('foo')] LoggerInterface $logger)
108 
+        {
106 109 
             $this->assertSame('foo', $logger->getName());
107 110 
         });
108 111 
     }
 
@@ -110,7 +113,8 @@  discard block
 
 block discarded – undo
110 113 
     public function testFinalizerShouldResetDefaultLogger()
111 114 
     {
112 115 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
113 
-            new class() implements LoaderInterface {
116 
+            new class() implements LoaderInterface
117 
+            {
114 118 
                 public function has(string $section): bool
115 119 
                 {
116 120 
                     return false;
 
@@ -150,7 +154,8 @@  discard block
 
 block discarded – undo
150 154 
     public function testFinalizerShouldNotResetLoggerWhenApplicationTerminating()
151 155 
     {
152 156 
         $this->container->bind(ConfiguratorInterface::class, new ConfigManager(
153 
-            new class() implements LoaderInterface {
157 
+            new class() implements LoaderInterface
158 
+            {
154 159 
                 public function has(string $section): bool
155 160 
                 {
156 161 
                     return false;
Please login to merge, or discard this patch.