Spiral\Storage\Resolver\AwsS3Resolver::buildUrl()

Complexity

Conditions	2
Paths	1

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function buildUrl(string $uri, array $options = [])
    {
        $s3Client = $this->fsInfo->getClient();

The method getClient() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. It seems like you code against a sub-type of Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface such as Spiral\Storage\Config\DTO\FileSystemInfo\Aws\AwsS3Info.

        return (string)$s3Client
            ->createPresignedRequest(
                $s3Client->getCommand(
                    'GetObject',
                    [
                        'Bucket' => $this->fsInfo->getOption(AwsS3Info::BUCKET_KEY),

The method getOption() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface.

                        'Key' => $this->normalizeFilePath($uri),
                    ]
                ),
                array_key_exists(static::EXPIRES_OPTION, $options)
                    ? $options[static::EXPIRES_OPTION]
                    : static::DEFAULT_URL_EXPIRES
            )
            ->getUri();
    }