Spiral\Storage\Resolver\AwsS3Resolver

Complexity

Total Complexity

2

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	buildUrl()	0	18	2

<?php

/**
 * This file is part of Spiral Framework package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Spiral\Storage\Resolver;

use Spiral\Storage\Config\DTO\FileSystemInfo\Aws\AwsS3Info;
use Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface;

class AwsS3Resolver extends AbstractAdapterResolver
{
    public const EXPIRES_OPTION = 'expires';

    protected const FILE_SYSTEM_INFO_CLASS = AwsS3Info::class;

    private const DEFAULT_URL_EXPIRES = '+24hours';

    /**
     * @var FileSystemInfoInterface|AwsS3Info
     */
    protected $fsInfo;

    /**
     * @inheritDoc
     */
    public function buildUrl(string $uri, array $options = [])
    {
        $s3Client = $this->fsInfo->getClient();

The method getClient() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. It seems like you code against a sub-type of Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface such as Spiral\Storage\Config\DTO\FileSystemInfo\Aws\AwsS3Info.

        return (string)$s3Client
            ->createPresignedRequest(
                $s3Client->getCommand(
                    'GetObject',
                    [
                        'Bucket' => $this->fsInfo->getOption(AwsS3Info::BUCKET_KEY),

The method getOption() does not exist on Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Spiral\Storage\Config\DTO\FileSystemInfo\FileSystemInfoInterface.

                        'Key' => $this->normalizeFilePath($uri),
                    ]
                ),
                array_key_exists(static::EXPIRES_OPTION, $options)
                    ? $options[static::EXPIRES_OPTION]
                    : static::DEFAULT_URL_EXPIRES
            )
            ->getUri();
    }
}