Test Failed
Pull Request — master (#1222)
by Aleksei
19:46 queued 08:54
created
src/Core/src/Internal/Proxy/ProxyClassRenderer.php 1 patch
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -27,29 +27,29 @@  discard block
 block discarded – undo
27 27
             MagicCallTrait::class,
28 28
         ] : [];
29 29
 
30
-        if (\str_contains($className, '\\')) {
30
+        if (\str_contains($className, '\\')){
31 31
             $classShortName = \substr($className, \strrpos($className, '\\') + 1);
32
-            $classNamespaceStr = 'namespace ' . \substr($className, 0, \strrpos($className, '\\')) . ';';
33
-        } else {
32
+            $classNamespaceStr = 'namespace '.\substr($className, 0, \strrpos($className, '\\')).';';
33
+        }else{
34 34
             $classShortName = $className;
35 35
             $classNamespaceStr = '';
36 36
         }
37 37
 
38 38
         $interface = $type->getName();
39 39
         $classBody = [];
40
-        foreach ($type->getMethods() as $method) {
41
-            if ($method->isConstructor()) {
40
+        foreach ($type->getMethods() as $method){
41
+            if ($method->isConstructor()){
42 42
                 throw new \LogicException('Constructor is not allowed in a proxy.');
43 43
             }
44 44
 
45
-            if ($method->isDestructor()) {
45
+            if ($method->isDestructor()){
46 46
                 $classBody[] = self::renderMethod($method);
47 47
                 continue;
48 48
             }
49 49
 
50 50
             $hasRefs = false;
51
-            $return = $method->hasReturnType() && (string) $method->getReturnType() === 'void' ? '' : 'return ';
52
-            $call = ($method->isStatic() ? '::' : '->') . $method->getName();
51
+            $return = $method->hasReturnType() && (string)$method->getReturnType() === 'void' ? '' : 'return ';
52
+            $call = ($method->isStatic() ? '::' : '->').$method->getName();
53 53
             $context = $method->isStatic() ? 'null' : '$this->__container_proxy_context';
54 54
             $containerStr = match (false) {
55 55
                 $attachContainer => 'null',
@@ -69,12 +69,12 @@  discard block
 block discarded – undo
69 69
                 PHP;
70 70
 
71 71
             $args = [];
72
-            foreach ($method->getParameters() as $param) {
72
+            foreach ($method->getParameters() as $param){
73 73
                 $hasRefs = $hasRefs || $param->isPassedByReference();
74
-                $args[] = ($param->isVariadic() ? '...' : '') . '$' . $param->getName();
74
+                $args[] = ($param->isVariadic() ? '...' : '').'$'.$param->getName();
75 75
             }
76 76
 
77
-            if (!$hasRefs && !$method->isVariadic()) {
77
+            if (!$hasRefs && !$method->isVariadic()){
78 78
                 $classBody[] = self::renderMethod(
79 79
                     $method,
80 80
                     <<<PHP
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
             $argsStr = \implode(', ', $args);
88 88
 
89
-            if ($method->isVariadic()) {
89
+            if ($method->isVariadic()){
90 90
                 $classBody[] = self::renderMethod(
91 91
                     $method,
92 92
                     <<<PHP
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
 
109 109
         $traitsStr = $traits === [] ? '' : \implode(
110 110
             "\n    ",
111
-            \array_map(static fn(string $trait): string => 'use \\' . \ltrim($trait, '\\') . ';', $traits),
111
+            \array_map(static fn(string $trait) : string => 'use \\'.\ltrim($trait, '\\').';', $traits),
112 112
         );
113 113
         return <<<PHP
114 114
             $classNamespaceStr
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
             $m->getName(),
132 132
             \implode(', ', \array_map(self::renderParameter(...), $m->getParameters())),
133 133
             $m->hasReturnType()
134
-                ? ': ' . self::renderParameterTypes($m->getReturnType(), $m->getDeclaringClass())
134
+                ? ': '.self::renderParameterTypes($m->getReturnType(), $m->getDeclaringClass())
135 135
                 : '',
136 136
             $body,
137 137
         );
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
145 145
                 $param->hasType() ? 'mixed' : '',
146 146
                 $param->isPassedByReference() ? '&' : '',
147 147
                 $param->isVariadic() ? '...' : '',
148
-                '$' . $param->getName(),
149
-                $param->isOptional() && !$param->isVariadic() ? ' = ' . self::renderDefaultValue($param) : '',
148
+                '$'.$param->getName(),
149
+                $param->isOptional() && !$param->isVariadic() ? ' = '.self::renderDefaultValue($param) : '',
150 150
             ),
151 151
             ' ',
152 152
         );
@@ -154,8 +154,8 @@  discard block
 block discarded – undo
154 154
 
155 155
     public static function renderParameterTypes(\ReflectionType $types, \ReflectionClass $class): string
156 156
     {
157
-        if ($types instanceof \ReflectionNamedType) {
158
-            return ($types->allowsNull() && $types->getName() !== 'mixed' ? '?' : '') . ($types->isBuiltin()
157
+        if ($types instanceof \ReflectionNamedType){
158
+            return ($types->allowsNull() && $types->getName() !== 'mixed' ? '?' : '').($types->isBuiltin()
159 159
                     ? $types->getName()
160 160
                     : self::normalizeClassType($types, $class));
161 161
         }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         };
168 168
 
169 169
         $result = [];
170
-        foreach ($types as $type) {
170
+        foreach ($types as $type){
171 171
             $result[] = $type->isBuiltin()
172 172
                 ? $type->getName()
173 173
                 : self::normalizeClassType($type, $class);
@@ -178,12 +178,12 @@  discard block
 block discarded – undo
178 178
 
179 179
     public static function renderDefaultValue(\ReflectionParameter $param): string
180 180
     {
181
-        if ($param->isDefaultValueConstant()) {
181
+        if ($param->isDefaultValueConstant()){
182 182
             $result = $param->getDefaultValueConstantName();
183 183
 
184
-            return \explode('::', (string) $result)[0] === 'self'
184
+            return \explode('::', (string)$result)[0] === 'self'
185 185
                 ? $result
186
-                : '\\' . $result;
186
+                : '\\'.$result;
187 187
         }
188 188
 
189 189
         $cut = self::cutDefaultValue($param);
@@ -197,14 +197,14 @@  discard block
 block discarded – undo
197 197
     {
198 198
         return match($type->getName()) {
199 199
             'static' => 'static',
200
-            'self' => '\\' . $class->getName(),
201
-            default => '\\' . $type->getName(),
200
+            'self' => '\\'.$class->getName(),
201
+            default => '\\'.$type->getName(),
202 202
         };
203 203
     }
204 204
 
205 205
     private static function cutDefaultValue(\ReflectionParameter $param): string
206 206
     {
207
-        $string = (string) $param;
207
+        $string = (string)$param;
208 208
 
209 209
         return \trim(\substr($string, \strpos($string, '=') + 1, -1));
210 210
     }
Please login to merge, or discard this patch.
src/Core/src/Internal/Actor.php 2 patches
Spacing   +78 added lines, -78 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
      */
88 88
     public function resolveType(
89 89
         string $alias,
90
-        ?Binding &$binding = null,
90
+        ?Binding & $binding = null,
91 91
         ?object &$singleton = null,
92 92
         ?object &$injector = null,
93 93
         ?self &$actor = null,
@@ -96,20 +96,20 @@  discard block
 block discarded – undo
96 96
         // Aliases to prevent circular dependencies
97 97
         $as = [];
98 98
         $actor = $this;
99
-        do {
99
+        do{
100 100
             $bindings = &$actor->state->bindings;
101 101
             $singletons = &$actor->state->singletons;
102 102
             $injectors = &$actor->state->injectors;
103 103
             $binding = $bindings[$alias] ?? null;
104
-            if (\array_key_exists($alias, $singletons)) {
104
+            if (\array_key_exists($alias, $singletons)){
105 105
                 $singleton = $singletons[$alias];
106 106
                 $injector = $injectors[$alias] ?? null;
107 107
                 return \is_object($singleton::class) ? $singleton::class : null;
108 108
             }
109 109
 
110
-            if ($binding !== null) {
111
-                if ($followAlias && $binding::class === Alias::class) {
112
-                    if ($binding->alias === $alias) {
110
+            if ($binding !== null){
111
+                if ($followAlias && $binding::class === Alias::class){
112
+                    if ($binding->alias === $alias){
113 113
                         break;
114 114
                     }
115 115
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
                 return $binding->getReturnClass();
125 125
             }
126 126
 
127
-            if (\array_key_exists($alias, $injectors)) {
127
+            if (\array_key_exists($alias, $injectors)){
128 128
                 $injector = $injectors[$alias];
129 129
                 $binding = $bindings[$alias] ?? null;
130 130
                 return $alias;
@@ -132,12 +132,12 @@  discard block
 block discarded – undo
132 132
 
133 133
             // Go to parent scope
134 134
             $parent = $actor->scope->getParentActor();
135
-            if ($parent === null) {
135
+            if ($parent === null){
136 136
                 break;
137 137
             }
138 138
 
139 139
             $actor = $parent;
140
-        } while (true);
140
+        }while (true);
141 141
 
142 142
         return \class_exists($alias) ? $alias : null;
143 143
     }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
     public function resolveBinding(
146 146
         object $binding,
147 147
         string $alias,
148
-        \Stringable|string|null $context,
148
+        \Stringable | string | null $context,
149 149
         array $arguments,
150 150
         Tracer $tracer,
151 151
     ): mixed {
@@ -202,18 +202,18 @@  discard block
 block discarded – undo
202 202
     private function resolveInjector(Config\Injectable $binding, Ctx $ctx, array $arguments, Tracer $tracer)
203 203
     {
204 204
         $context = $ctx->context;
205
-        try {
205
+        try{
206 206
             $reflection = $ctx->reflection ??= new \ReflectionClass($ctx->class);
207
-        } catch (\ReflectionException $e) {
207
+        }catch (\ReflectionException $e){
208 208
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
209 209
         }
210 210
 
211 211
         $injector = $binding->injector;
212 212
 
213
-        try {
213
+        try{
214 214
             $injectorInstance = \is_object($injector) ? $injector : $this->container->get($injector);
215 215
 
216
-            if (!$injectorInstance instanceof InjectorInterface) {
216
+            if (!$injectorInstance instanceof InjectorInterface){
217 217
                 throw new InjectionException(
218 218
                     \sprintf(
219 219
                         "Class '%s' must be an instance of InjectorInterface for '%s'.",
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
             static $cache = [];
228 228
             $extended = $cache[$injectorInstance::class] ??= (
229 229
             static fn(\ReflectionType $type): bool =>
230
-                $type::class === \ReflectionUnionType::class || (string) $type === 'mixed'
230
+                $type::class === \ReflectionUnionType::class || (string)$type === 'mixed'
231 231
             )(
232 232
                 ($refMethod = new \ReflectionMethod($injectorInstance, 'createInjection'))
233 233
                     ->getParameters()[1]->getType()
@@ -237,10 +237,10 @@  discard block
 block discarded – undo
237 237
             $instance = $injectorInstance->createInjection($reflection, match (true) {
238 238
                 $asIs => $context,
239 239
                 $context instanceof \ReflectionParameter => $context->getName(),
240
-                default => (string) $context,
240
+                default => (string)$context,
241 241
             });
242 242
 
243
-            if (!$reflection->isInstance($instance)) {
243
+            if (!$reflection->isInstance($instance)){
244 244
                 throw new InjectionException(
245 245
                     \sprintf(
246 246
                         "Invalid injection response for '%s'.",
@@ -250,12 +250,12 @@  discard block
 block discarded – undo
250 250
             }
251 251
 
252 252
             return $instance;
253
-        } catch (TracedContainerException $e) {
253
+        }catch (TracedContainerException $e){
254 254
             throw isset($injectorInstance) ? $e : $e::extendTracedException(\sprintf(
255 255
                 'Can\'t resolve `%s`.',
256 256
                 $tracer->getRootAlias(),
257 257
             ), $tracer->getTraces(), $e);
258
-        } finally {
258
+        }finally{
259 259
             $this->state->bindings[$ctx->class] ??= $binding;
260 260
         }
261 261
     }
@@ -263,22 +263,22 @@  discard block
 block discarded – undo
263 263
     private function resolveAlias(
264 264
         Config\Alias $binding,
265 265
         string $alias,
266
-        \Stringable|string|null $context,
266
+        \Stringable | string | null $context,
267 267
         array $arguments,
268 268
         Tracer $tracer,
269 269
     ): mixed {
270
-        if ($binding->alias === $alias) {
270
+        if ($binding->alias === $alias){
271 271
             $instance = $this->autowire(
272 272
                 new Ctx(alias: $alias, class: $binding->alias, context: $context, singleton: $binding->singleton && $arguments === []),
273 273
                 $arguments,
274 274
                 $this,
275 275
                 $tracer,
276 276
             );
277
-        } else {
278
-            try {
277
+        }else{
278
+            try{
279 279
                 //Binding is pointing to something else
280 280
                 $instance = $this->factory->make($binding->alias, $arguments, $context);
281
-            } catch (TracedContainerException $e) {
281
+            }catch (TracedContainerException $e){
282 282
                 throw $e::extendTracedException(
283 283
                     $alias === $tracer->getRootAlias()
284 284
                         ? "Can't resolve `{$alias}`."
@@ -295,9 +295,9 @@  discard block
 block discarded – undo
295 295
         return $instance;
296 296
     }
297 297
 
298
-    private function resolveProxy(Config\Proxy $binding, string $alias, \Stringable|string|null $context): mixed
298
+    private function resolveProxy(Config\Proxy $binding, string $alias, \Stringable | string | null $context): mixed
299 299
     {
300
-        if ($context instanceof RetryContext) {
300
+        if ($context instanceof RetryContext){
301 301
             return $binding->fallbackFactory === null
302 302
                 ? throw new RecursiveProxyException(
303 303
                     $alias,
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 
309 309
         $result = Proxy::create(new \ReflectionClass($binding->getReturnClass()), $context, new Attribute\Proxy());
310 310
 
311
-        if ($binding->singleton) {
311
+        if ($binding->singleton){
312 312
             $this->state->singletons[$alias] = $result;
313 313
         }
314 314
 
@@ -318,11 +318,11 @@  discard block
 block discarded – undo
318 318
     private function resolveShared(
319 319
         Config\Shared $binding,
320 320
         string $alias,
321
-        \Stringable|string|null $context,
321
+        \Stringable | string | null $context,
322 322
         array $arguments,
323 323
         Tracer $tracer,
324 324
     ): object {
325
-        if ($arguments !== []) {
325
+        if ($arguments !== []){
326 326
             // Avoid singleton cache
327 327
             return $this->createInstance(
328 328
                 new Ctx(alias: $alias, class: $binding->value::class, context: $context, singleton: false),
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
             );
333 333
         }
334 334
 
335
-        if ($binding->singleton) {
335
+        if ($binding->singleton){
336 336
             $this->state->singletons[$alias] = $binding->value;
337 337
         }
338 338
 
@@ -342,16 +342,16 @@  discard block
 block discarded – undo
342 342
     private function resolveAutowire(
343 343
         Config\Autowire $binding,
344 344
         string $alias,
345
-        \Stringable|string|null $context,
345
+        \Stringable | string | null $context,
346 346
         array $arguments,
347 347
         Tracer $tracer,
348 348
     ): mixed {
349 349
         $target = $binding->autowire->alias;
350 350
         $ctx = new Ctx(alias: $alias, class: $target, context: $context, singleton: $binding->singleton && $arguments === [] ?: null);
351 351
 
352
-        if ($alias === $target) {
352
+        if ($alias === $target){
353 353
             $instance = $this->autowire($ctx, \array_merge($binding->autowire->parameters, $arguments), $this, $tracer);
354
-        } else {
354
+        }else{
355 355
             $instance = $binding->autowire->resolve($this->factory, $arguments);
356 356
             $this->validateConstraint($instance, $ctx);
357 357
         }
@@ -360,32 +360,32 @@  discard block
 block discarded – undo
360 360
     }
361 361
 
362 362
     private function resolveFactory(
363
-        Config\Factory|Config\DeferredFactory $binding,
363
+        Config\Factory | Config\DeferredFactory $binding,
364 364
         string $alias,
365
-        \Stringable|string|null $context,
365
+        \Stringable | string | null $context,
366 366
         array $arguments,
367 367
         Tracer $tracer,
368 368
     ): mixed {
369 369
         $ctx = new Ctx(alias: $alias, class: $alias, context: $context, singleton: $binding->singleton && $arguments === [] ?: null);
370
-        try {
370
+        try{
371 371
             $instance = $binding::class === Config\Factory::class && $binding->getParametersCount() === 0
372 372
                 ? ($binding->factory)()
373 373
                 : $this->invoker->invoke($binding->factory, $arguments);
374
-        } catch (NotCallableException $e) {
374
+        }catch (NotCallableException $e){
375 375
             throw TracedContainerException::createWithTrace(
376 376
                 \sprintf('Invalid callable binding for `%s`.', $ctx->alias),
377 377
                 $tracer->getTraces(),
378 378
                 $e,
379 379
             );
380
-        } catch (TracedContainerException $e) {
380
+        }catch (TracedContainerException $e){
381 381
             throw $e::extendTracedException(
382 382
                 \sprintf("Can't resolve `%s`: factory invocation failed.", $tracer->getRootAlias()),
383 383
                 $tracer->getTraces(),
384 384
                 $e,
385 385
             );
386
-        } catch (ContainerExceptionInterface $e) {
386
+        }catch (ContainerExceptionInterface $e){
387 387
             throw $e;
388
-        } catch (\Throwable $e) {
388
+        }catch (\Throwable $e){
389 389
             throw NotFoundException::createWithTrace(
390 390
                 \sprintf("Can't resolve `%s` due to factory invocation error: %s", $tracer->getRootAlias(), $e->getMessage()),
391 391
                 $tracer->getTraces(),
@@ -393,7 +393,7 @@  discard block
 block discarded – undo
393 393
             );
394 394
         }
395 395
 
396
-        if (\is_object($instance)) {
396
+        if (\is_object($instance)){
397 397
             $this->validateConstraint($instance, $ctx);
398 398
             return $this->registerInstance($ctx, $instance);
399 399
         }
@@ -404,14 +404,14 @@  discard block
 block discarded – undo
404 404
     private function resolveWeakReference(
405 405
         Config\WeakReference $binding,
406 406
         string $alias,
407
-        \Stringable|string|null $context,
407
+        \Stringable | string | null $context,
408 408
         array $arguments,
409 409
         Tracer $tracer,
410 410
     ): ?object {
411 411
         $avoidCache = $arguments !== [];
412 412
 
413
-        if (($avoidCache || $binding->reference->get() === null) && \class_exists($alias)) {
414
-            try {
413
+        if (($avoidCache || $binding->reference->get() === null) && \class_exists($alias)){
414
+            try{
415 415
                 $tracer->push(false, alias: $alias, source: \WeakReference::class, context: $context);
416 416
 
417 417
                 $object = $this->createInstance(
@@ -420,17 +420,17 @@  discard block
 block discarded – undo
420 420
                     $this,
421 421
                     $tracer,
422 422
                 );
423
-                if ($avoidCache) {
423
+                if ($avoidCache){
424 424
                     return $object;
425 425
                 }
426 426
                 $binding->reference = \WeakReference::create($object);
427
-            } catch (\Throwable) {
427
+            }catch (\Throwable){
428 428
                 throw TracedContainerException::createWithTrace(\sprintf(
429 429
                     'Can\'t resolve `%s`: can\'t instantiate `%s` from WeakReference binding.',
430 430
                     $tracer->getRootAlias(),
431 431
                     $alias,
432 432
                 ), $tracer->getTraces());
433
-            } finally {
433
+            }finally{
434 434
                 $tracer->pop();
435 435
             }
436 436
         }
@@ -446,13 +446,13 @@  discard block
 block discarded – undo
446 446
         object $instance,
447 447
         Ctx $ctx,
448 448
     ): void {
449
-        if ($this->options->checkScope) {
449
+        if ($this->options->checkScope){
450 450
             // Check scope name
451 451
             $ctx->reflection ??= new \ReflectionClass($instance);
452 452
             $scopeName = ($ctx->reflection->getAttributes(Attribute\Scope::class)[0] ?? null)?->newInstance()->name;
453
-            if ($scopeName !== null) {
453
+            if ($scopeName !== null){
454 454
                 $scope = $this->scope;
455
-                while ($scope->getScopeName() !== $scopeName) {
455
+                while ($scope->getScopeName() !== $scopeName){
456 456
                     $scope = $scope->getParentScope() ?? throw new BadScopeException($scopeName, $instance::class);
457 457
                 }
458 458
             }
@@ -479,26 +479,26 @@  discard block
 block discarded – undo
479 479
         Tracer $tracer,
480 480
     ): object {
481 481
         $class = $ctx->class;
482
-        try {
482
+        try{
483 483
             $ctx->reflection = $reflection = new \ReflectionClass($class);
484
-        } catch (\ReflectionException $e) {
484
+        }catch (\ReflectionException $e){
485 485
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
486 486
         }
487 487
 
488 488
         // Check Scope attribute
489 489
         $actor = $fallbackActor ?? $this;
490
-        if ($this->options->checkScope) { # todo
490
+        if ($this->options->checkScope){ # todo
491 491
             $ar = ($reflection->getAttributes(Attribute\Scope::class)[0] ?? null);
492
-            if ($ar !== null) {
492
+            if ($ar !== null){
493 493
                 /** @var Attribute\Scope $attr */
494 494
                 $attr = $ar->newInstance();
495 495
                 $scope = $this->scope;
496 496
                 $actor = $this;
497 497
                 // Go through all parent scopes
498 498
                 $needed = $actor;
499
-                while ($attr->name !== $scope->getScopeName()) {
499
+                while ($attr->name !== $scope->getScopeName()){
500 500
                     $needed = $scope->getParentActor();
501
-                    if ($needed === null) {
501
+                    if ($needed === null){
502 502
                         throw new BadScopeException($attr->name, $class);
503 503
                     }
504 504
 
@@ -511,11 +511,11 @@  discard block
 block discarded – undo
511 511
         } # todo
512 512
 
513 513
         // We have to construct class using external injector when we know the exact context
514
-        if ($arguments === [] && $actor->binder->hasInjector($class)) {
514
+        if ($arguments === [] && $actor->binder->hasInjector($class)){
515 515
             return $actor->resolveInjector($actor->state->bindings[$ctx->class], $ctx, $arguments, $tracer);
516 516
         }
517 517
 
518
-        if (!$reflection->isInstantiable()) {
518
+        if (!$reflection->isInstantiable()){
519 519
             $itIs = match (true) {
520 520
                 $reflection->isEnum() => 'Enum',
521 521
                 $reflection->isAbstract() => 'Abstract class',
@@ -529,8 +529,8 @@  discard block
 block discarded – undo
529 529
 
530 530
         $constructor = $reflection->getConstructor();
531 531
 
532
-        if ($constructor !== null) {
533
-            try {
532
+        if ($constructor !== null){
533
+            try{
534 534
                 $newScope = $this !== $actor;
535 535
                 $debug = [
536 536
                     'action' => 'resolve arguments',
@@ -544,18 +544,18 @@  discard block
 block discarded – undo
544 544
                 $tracer->push($newScope, ...$debug);
545 545
                 $tracer->push(true);
546 546
                 $args = $actor->resolver->resolveArguments($constructor, $arguments, $actor->options->validateArguments);
547
-            } catch (ValidationException $e) {
547
+            }catch (ValidationException $e){
548 548
                 throw TracedContainerException::createWithTrace(\sprintf(
549 549
                     'Can\'t resolve `%s`. %s',
550 550
                     $tracer->getRootAlias(),
551 551
                     $e->getMessage(),
552 552
                 ), $tracer->getTraces());
553
-            } catch (TracedContainerException $e) {
553
+            }catch (TracedContainerException $e){
554 554
                 throw $e::extendTracedException(\sprintf(
555 555
                     'Can\'t resolve `%s`.',
556 556
                     $tracer->getRootAlias(),
557 557
                 ), $tracer->getTraces(), $e);
558
-            } catch (\Throwable $e) {
558
+            }catch (\Throwable $e){
559 559
                 throw TracedContainerException::createWithTrace(
560 560
                     \sprintf(
561 561
                         "Can't resolve `%s`.\n%s",
@@ -563,28 +563,28 @@  discard block
 block discarded – undo
563 563
                         $e->getMessage(),
564 564
                     ), $tracer->getTraces(), $e
565 565
                 );
566
-            } finally {
566
+            }finally{
567 567
                 $tracer->pop($newScope);
568 568
                 $tracer->pop(false);
569 569
             }
570
-            try {
570
+            try{
571 571
                 // Using constructor with resolved arguments
572 572
                 $tracer->push(false, call: "$class::__construct", arguments: $args);
573 573
                 $tracer->push(true);
574 574
                 $instance = new $class(...$args);
575
-            } catch (\TypeError $e) {
575
+            }catch (\TypeError $e){
576 576
                 throw new WrongTypeException($constructor, $e);
577
-            } catch (TracedContainerException $e) {
577
+            }catch (TracedContainerException $e){
578 578
                 throw $e::extendTracedException(\sprintf(
579 579
                     'Can\'t resolve `%s`: failed constructing `%s`.',
580 580
                     $tracer->getRootAlias(),
581 581
                     $class,
582 582
                 ), $tracer->getTraces(), $e);
583
-            } finally {
583
+            }finally{
584 584
                 $tracer->pop(true);
585 585
                 $tracer->pop(false);
586 586
             }
587
-        } else {
587
+        }else{
588 588
             // No constructor specified
589 589
             $instance = $reflection->newInstance();
590 590
         }
@@ -616,12 +616,12 @@  discard block
 block discarded – undo
616 616
      */
617 617
     private function isSingleton(Ctx $ctx): bool
618 618
     {
619
-        if (is_bool($ctx->singleton)) {
619
+        if (is_bool($ctx->singleton)){
620 620
             return $ctx->singleton;
621 621
         }
622 622
 
623 623
         /** @psalm-suppress RedundantCondition https://github.com/vimeo/psalm/issues/9489 */
624
-        if ($ctx->reflection->implementsInterface(SingletonInterface::class)) {
624
+        if ($ctx->reflection->implementsInterface(SingletonInterface::class)){
625 625
             return true;
626 626
         }
627 627
 
@@ -635,7 +635,7 @@  discard block
 block discarded – undo
635 635
          * @var Attribute\Finalize|null $attribute
636 636
          */
637 637
         $attribute = ($ctx->reflection->getAttributes(Attribute\Finalize::class)[0] ?? null)?->newInstance();
638
-        if ($attribute === null) {
638
+        if ($attribute === null){
639 639
             return null;
640 640
         }
641 641
 
@@ -649,10 +649,10 @@  discard block
 block discarded – undo
649 649
     {
650 650
         $scope = $this->scope;
651 651
 
652
-        while ($scope !== null) {
653
-            foreach ($this->state->inflectors as $class => $inflectors) {
654
-                if ($instance instanceof $class) {
655
-                    foreach ($inflectors as $inflector) {
652
+        while ($scope !== null){
653
+            foreach ($this->state->inflectors as $class => $inflectors){
654
+                if ($instance instanceof $class){
655
+                    foreach ($inflectors as $inflector){
656 656
                         $instance = $inflector->getParametersCount() > 1
657 657
                             ? $this->invoker->invoke($inflector->inflector, [$instance])
658 658
                             : ($inflector->inflector)($instance);
@@ -668,9 +668,9 @@  discard block
 block discarded – undo
668 668
 
669 669
     private function validateArguments(ContextFunction $reflection, array $arguments = []): bool
670 670
     {
671
-        try {
671
+        try{
672 672
             $this->resolver->validateArguments($reflection, $arguments);
673
-        } catch (\Throwable) {
673
+        }catch (\Throwable){
674 674
             return false;
675 675
         }
676 676
 
Please login to merge, or discard this patch.
Braces   +155 added lines, -66 removed lines patch added patch discarded remove patch
@@ -96,20 +96,25 @@  discard block
 block discarded – undo
96 96
         // Aliases to prevent circular dependencies
97 97
         $as = [];
98 98
         $actor = $this;
99
-        do {
99
+        do
100
+        {
100 101
             $bindings = &$actor->state->bindings;
101 102
             $singletons = &$actor->state->singletons;
102 103
             $injectors = &$actor->state->injectors;
103 104
             $binding = $bindings[$alias] ?? null;
104
-            if (\array_key_exists($alias, $singletons)) {
105
+            if (\array_key_exists($alias, $singletons))
106
+            {
105 107
                 $singleton = $singletons[$alias];
106 108
                 $injector = $injectors[$alias] ?? null;
107 109
                 return \is_object($singleton::class) ? $singleton::class : null;
108 110
             }
109 111
 
110
-            if ($binding !== null) {
111
-                if ($followAlias && $binding::class === Alias::class) {
112
-                    if ($binding->alias === $alias) {
112
+            if ($binding !== null)
113
+            {
114
+                if ($followAlias && $binding::class === Alias::class)
115
+                {
116
+                    if ($binding->alias === $alias)
117
+                    {
113 118
                         break;
114 119
                     }
115 120
 
@@ -124,7 +129,8 @@  discard block
 block discarded – undo
124 129
                 return $binding->getReturnClass();
125 130
             }
126 131
 
127
-            if (\array_key_exists($alias, $injectors)) {
132
+            if (\array_key_exists($alias, $injectors))
133
+            {
128 134
                 $injector = $injectors[$alias];
129 135
                 $binding = $bindings[$alias] ?? null;
130 136
                 return $alias;
@@ -132,7 +138,8 @@  discard block
 block discarded – undo
132 138
 
133 139
             // Go to parent scope
134 140
             $parent = $actor->scope->getParentActor();
135
-            if ($parent === null) {
141
+            if ($parent === null)
142
+            {
136 143
                 break;
137 144
             }
138 145
 
@@ -202,18 +209,23 @@  discard block
 block discarded – undo
202 209
     private function resolveInjector(Config\Injectable $binding, Ctx $ctx, array $arguments, Tracer $tracer)
203 210
     {
204 211
         $context = $ctx->context;
205
-        try {
212
+        try
213
+        {
206 214
             $reflection = $ctx->reflection ??= new \ReflectionClass($ctx->class);
207
-        } catch (\ReflectionException $e) {
215
+        }
216
+        catch (\ReflectionException $e)
217
+        {
208 218
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
209 219
         }
210 220
 
211 221
         $injector = $binding->injector;
212 222
 
213
-        try {
223
+        try
224
+        {
214 225
             $injectorInstance = \is_object($injector) ? $injector : $this->container->get($injector);
215 226
 
216
-            if (!$injectorInstance instanceof InjectorInterface) {
227
+            if (!$injectorInstance instanceof InjectorInterface)
228
+            {
217 229
                 throw new InjectionException(
218 230
                     \sprintf(
219 231
                         "Class '%s' must be an instance of InjectorInterface for '%s'.",
@@ -240,7 +252,8 @@  discard block
 block discarded – undo
240 252
                 default => (string) $context,
241 253
             });
242 254
 
243
-            if (!$reflection->isInstance($instance)) {
255
+            if (!$reflection->isInstance($instance))
256
+            {
244 257
                 throw new InjectionException(
245 258
                     \sprintf(
246 259
                         "Invalid injection response for '%s'.",
@@ -250,12 +263,16 @@  discard block
 block discarded – undo
250 263
             }
251 264
 
252 265
             return $instance;
253
-        } catch (TracedContainerException $e) {
266
+        }
267
+        catch (TracedContainerException $e)
268
+        {
254 269
             throw isset($injectorInstance) ? $e : $e::extendTracedException(\sprintf(
255 270
                 'Can\'t resolve `%s`.',
256 271
                 $tracer->getRootAlias(),
257 272
             ), $tracer->getTraces(), $e);
258
-        } finally {
273
+        }
274
+        finally
275
+        {
259 276
             $this->state->bindings[$ctx->class] ??= $binding;
260 277
         }
261 278
     }
@@ -267,18 +284,24 @@  discard block
 block discarded – undo
267 284
         array $arguments,
268 285
         Tracer $tracer,
269 286
     ): mixed {
270
-        if ($binding->alias === $alias) {
287
+        if ($binding->alias === $alias)
288
+        {
271 289
             $instance = $this->autowire(
272 290
                 new Ctx(alias: $alias, class: $binding->alias, context: $context, singleton: $binding->singleton && $arguments === []),
273 291
                 $arguments,
274 292
                 $this,
275 293
                 $tracer,
276 294
             );
277
-        } else {
278
-            try {
295
+        }
296
+        else
297
+        {
298
+            try
299
+            {
279 300
                 //Binding is pointing to something else
280 301
                 $instance = $this->factory->make($binding->alias, $arguments, $context);
281
-            } catch (TracedContainerException $e) {
302
+            }
303
+            catch (TracedContainerException $e)
304
+            {
282 305
                 throw $e::extendTracedException(
283 306
                     $alias === $tracer->getRootAlias()
284 307
                         ? "Can't resolve `{$alias}`."
@@ -297,7 +320,8 @@  discard block
 block discarded – undo
297 320
 
298 321
     private function resolveProxy(Config\Proxy $binding, string $alias, \Stringable|string|null $context): mixed
299 322
     {
300
-        if ($context instanceof RetryContext) {
323
+        if ($context instanceof RetryContext)
324
+        {
301 325
             return $binding->fallbackFactory === null
302 326
                 ? throw new RecursiveProxyException(
303 327
                     $alias,
@@ -308,7 +332,8 @@  discard block
 block discarded – undo
308 332
 
309 333
         $result = Proxy::create(new \ReflectionClass($binding->getReturnClass()), $context, new Attribute\Proxy());
310 334
 
311
-        if ($binding->singleton) {
335
+        if ($binding->singleton)
336
+        {
312 337
             $this->state->singletons[$alias] = $result;
313 338
         }
314 339
 
@@ -322,7 +347,8 @@  discard block
 block discarded – undo
322 347
         array $arguments,
323 348
         Tracer $tracer,
324 349
     ): object {
325
-        if ($arguments !== []) {
350
+        if ($arguments !== [])
351
+        {
326 352
             // Avoid singleton cache
327 353
             return $this->createInstance(
328 354
                 new Ctx(alias: $alias, class: $binding->value::class, context: $context, singleton: false),
@@ -332,7 +358,8 @@  discard block
 block discarded – undo
332 358
             );
333 359
         }
334 360
 
335
-        if ($binding->singleton) {
361
+        if ($binding->singleton)
362
+        {
336 363
             $this->state->singletons[$alias] = $binding->value;
337 364
         }
338 365
 
@@ -349,9 +376,12 @@  discard block
 block discarded – undo
349 376
         $target = $binding->autowire->alias;
350 377
         $ctx = new Ctx(alias: $alias, class: $target, context: $context, singleton: $binding->singleton && $arguments === [] ?: null);
351 378
 
352
-        if ($alias === $target) {
379
+        if ($alias === $target)
380
+        {
353 381
             $instance = $this->autowire($ctx, \array_merge($binding->autowire->parameters, $arguments), $this, $tracer);
354
-        } else {
382
+        }
383
+        else
384
+        {
355 385
             $instance = $binding->autowire->resolve($this->factory, $arguments);
356 386
             $this->validateConstraint($instance, $ctx);
357 387
         }
@@ -367,25 +397,34 @@  discard block
 block discarded – undo
367 397
         Tracer $tracer,
368 398
     ): mixed {
369 399
         $ctx = new Ctx(alias: $alias, class: $alias, context: $context, singleton: $binding->singleton && $arguments === [] ?: null);
370
-        try {
400
+        try
401
+        {
371 402
             $instance = $binding::class === Config\Factory::class && $binding->getParametersCount() === 0
372 403
                 ? ($binding->factory)()
373 404
                 : $this->invoker->invoke($binding->factory, $arguments);
374
-        } catch (NotCallableException $e) {
405
+        }
406
+        catch (NotCallableException $e)
407
+        {
375 408
             throw TracedContainerException::createWithTrace(
376 409
                 \sprintf('Invalid callable binding for `%s`.', $ctx->alias),
377 410
                 $tracer->getTraces(),
378 411
                 $e,
379 412
             );
380
-        } catch (TracedContainerException $e) {
413
+        }
414
+        catch (TracedContainerException $e)
415
+        {
381 416
             throw $e::extendTracedException(
382 417
                 \sprintf("Can't resolve `%s`: factory invocation failed.", $tracer->getRootAlias()),
383 418
                 $tracer->getTraces(),
384 419
                 $e,
385 420
             );
386
-        } catch (ContainerExceptionInterface $e) {
421
+        }
422
+        catch (ContainerExceptionInterface $e)
423
+        {
387 424
             throw $e;
388
-        } catch (\Throwable $e) {
425
+        }
426
+        catch (\Throwable $e)
427
+        {
389 428
             throw NotFoundException::createWithTrace(
390 429
                 \sprintf("Can't resolve `%s` due to factory invocation error: %s", $tracer->getRootAlias(), $e->getMessage()),
391 430
                 $tracer->getTraces(),
@@ -393,7 +432,8 @@  discard block
 block discarded – undo
393 432
             );
394 433
         }
395 434
 
396
-        if (\is_object($instance)) {
435
+        if (\is_object($instance))
436
+        {
397 437
             $this->validateConstraint($instance, $ctx);
398 438
             return $this->registerInstance($ctx, $instance);
399 439
         }
@@ -410,8 +450,10 @@  discard block
 block discarded – undo
410 450
     ): ?object {
411 451
         $avoidCache = $arguments !== [];
412 452
 
413
-        if (($avoidCache || $binding->reference->get() === null) && \class_exists($alias)) {
414
-            try {
453
+        if (($avoidCache || $binding->reference->get() === null) && \class_exists($alias))
454
+        {
455
+            try
456
+            {
415 457
                 $tracer->push(false, alias: $alias, source: \WeakReference::class, context: $context);
416 458
 
417 459
                 $object = $this->createInstance(
@@ -420,17 +462,22 @@  discard block
 block discarded – undo
420 462
                     $this,
421 463
                     $tracer,
422 464
                 );
423
-                if ($avoidCache) {
465
+                if ($avoidCache)
466
+                {
424 467
                     return $object;
425 468
                 }
426 469
                 $binding->reference = \WeakReference::create($object);
427
-            } catch (\Throwable) {
470
+            }
471
+            catch (\Throwable)
472
+            {
428 473
                 throw TracedContainerException::createWithTrace(\sprintf(
429 474
                     'Can\'t resolve `%s`: can\'t instantiate `%s` from WeakReference binding.',
430 475
                     $tracer->getRootAlias(),
431 476
                     $alias,
432 477
                 ), $tracer->getTraces());
433
-            } finally {
478
+            }
479
+            finally
480
+            {
434 481
                 $tracer->pop();
435 482
             }
436 483
         }
@@ -446,13 +493,16 @@  discard block
 block discarded – undo
446 493
         object $instance,
447 494
         Ctx $ctx,
448 495
     ): void {
449
-        if ($this->options->checkScope) {
496
+        if ($this->options->checkScope)
497
+        {
450 498
             // Check scope name
451 499
             $ctx->reflection ??= new \ReflectionClass($instance);
452 500
             $scopeName = ($ctx->reflection->getAttributes(Attribute\Scope::class)[0] ?? null)?->newInstance()->name;
453
-            if ($scopeName !== null) {
501
+            if ($scopeName !== null)
502
+            {
454 503
                 $scope = $this->scope;
455
-                while ($scope->getScopeName() !== $scopeName) {
504
+                while ($scope->getScopeName() !== $scopeName)
505
+                {
456 506
                     $scope = $scope->getParentScope() ?? throw new BadScopeException($scopeName, $instance::class);
457 507
                 }
458 508
             }
@@ -479,26 +529,34 @@  discard block
 block discarded – undo
479 529
         Tracer $tracer,
480 530
     ): object {
481 531
         $class = $ctx->class;
482
-        try {
532
+        try
533
+        {
483 534
             $ctx->reflection = $reflection = new \ReflectionClass($class);
484
-        } catch (\ReflectionException $e) {
535
+        }
536
+        catch (\ReflectionException $e)
537
+        {
485 538
             throw new ContainerException($e->getMessage(), $e->getCode(), $e);
486 539
         }
487 540
 
488 541
         // Check Scope attribute
489 542
         $actor = $fallbackActor ?? $this;
490
-        if ($this->options->checkScope) { # todo
543
+        if ($this->options->checkScope)
544
+        {
545
+# todo
491 546
             $ar = ($reflection->getAttributes(Attribute\Scope::class)[0] ?? null);
492
-            if ($ar !== null) {
547
+            if ($ar !== null)
548
+            {
493 549
                 /** @var Attribute\Scope $attr */
494 550
                 $attr = $ar->newInstance();
495 551
                 $scope = $this->scope;
496 552
                 $actor = $this;
497 553
                 // Go through all parent scopes
498 554
                 $needed = $actor;
499
-                while ($attr->name !== $scope->getScopeName()) {
555
+                while ($attr->name !== $scope->getScopeName())
556
+                {
500 557
                     $needed = $scope->getParentActor();
501
-                    if ($needed === null) {
558
+                    if ($needed === null)
559
+                    {
502 560
                         throw new BadScopeException($attr->name, $class);
503 561
                     }
504 562
 
@@ -511,11 +569,13 @@  discard block
 block discarded – undo
511 569
         } # todo
512 570
 
513 571
         // We have to construct class using external injector when we know the exact context
514
-        if ($arguments === [] && $actor->binder->hasInjector($class)) {
572
+        if ($arguments === [] && $actor->binder->hasInjector($class))
573
+        {
515 574
             return $actor->resolveInjector($actor->state->bindings[$ctx->class], $ctx, $arguments, $tracer);
516 575
         }
517 576
 
518
-        if (!$reflection->isInstantiable()) {
577
+        if (!$reflection->isInstantiable())
578
+        {
519 579
             $itIs = match (true) {
520 580
                 $reflection->isEnum() => 'Enum',
521 581
                 $reflection->isAbstract() => 'Abstract class',
@@ -529,8 +589,10 @@  discard block
 block discarded – undo
529 589
 
530 590
         $constructor = $reflection->getConstructor();
531 591
 
532
-        if ($constructor !== null) {
533
-            try {
592
+        if ($constructor !== null)
593
+        {
594
+            try
595
+            {
534 596
                 $newScope = $this !== $actor;
535 597
                 $debug = [
536 598
                     'action' => 'resolve arguments',
@@ -544,18 +606,24 @@  discard block
 block discarded – undo
544 606
                 $tracer->push($newScope, ...$debug);
545 607
                 $tracer->push(true);
546 608
                 $args = $actor->resolver->resolveArguments($constructor, $arguments, $actor->options->validateArguments);
547
-            } catch (ValidationException $e) {
609
+            }
610
+            catch (ValidationException $e)
611
+            {
548 612
                 throw TracedContainerException::createWithTrace(\sprintf(
549 613
                     'Can\'t resolve `%s`. %s',
550 614
                     $tracer->getRootAlias(),
551 615
                     $e->getMessage(),
552 616
                 ), $tracer->getTraces());
553
-            } catch (TracedContainerException $e) {
617
+            }
618
+            catch (TracedContainerException $e)
619
+            {
554 620
                 throw $e::extendTracedException(\sprintf(
555 621
                     'Can\'t resolve `%s`.',
556 622
                     $tracer->getRootAlias(),
557 623
                 ), $tracer->getTraces(), $e);
558
-            } catch (\Throwable $e) {
624
+            }
625
+            catch (\Throwable $e)
626
+            {
559 627
                 throw TracedContainerException::createWithTrace(
560 628
                     \sprintf(
561 629
                         "Can't resolve `%s`.\n%s",
@@ -563,28 +631,39 @@  discard block
 block discarded – undo
563 631
                         $e->getMessage(),
564 632
                     ), $tracer->getTraces(), $e
565 633
                 );
566
-            } finally {
634
+            }
635
+            finally
636
+            {
567 637
                 $tracer->pop($newScope);
568 638
                 $tracer->pop(false);
569 639
             }
570
-            try {
640
+            try
641
+            {
571 642
                 // Using constructor with resolved arguments
572 643
                 $tracer->push(false, call: "$class::__construct", arguments: $args);
573 644
                 $tracer->push(true);
574 645
                 $instance = new $class(...$args);
575
-            } catch (\TypeError $e) {
646
+            }
647
+            catch (\TypeError $e)
648
+            {
576 649
                 throw new WrongTypeException($constructor, $e);
577
-            } catch (TracedContainerException $e) {
650
+            }
651
+            catch (TracedContainerException $e)
652
+            {
578 653
                 throw $e::extendTracedException(\sprintf(
579 654
                     'Can\'t resolve `%s`: failed constructing `%s`.',
580 655
                     $tracer->getRootAlias(),
581 656
                     $class,
582 657
                 ), $tracer->getTraces(), $e);
583
-            } finally {
658
+            }
659
+            finally
660
+            {
584 661
                 $tracer->pop(true);
585 662
                 $tracer->pop(false);
586 663
             }
587
-        } else {
664
+        }
665
+        else
666
+        {
588 667
             // No constructor specified
589 668
             $instance = $reflection->newInstance();
590 669
         }
@@ -616,12 +695,14 @@  discard block
 block discarded – undo
616 695
      */
617 696
     private function isSingleton(Ctx $ctx): bool
618 697
     {
619
-        if (is_bool($ctx->singleton)) {
698
+        if (is_bool($ctx->singleton))
699
+        {
620 700
             return $ctx->singleton;
621 701
         }
622 702
 
623 703
         /** @psalm-suppress RedundantCondition https://github.com/vimeo/psalm/issues/9489 */
624
-        if ($ctx->reflection->implementsInterface(SingletonInterface::class)) {
704
+        if ($ctx->reflection->implementsInterface(SingletonInterface::class))
705
+        {
625 706
             return true;
626 707
         }
627 708
 
@@ -635,7 +716,8 @@  discard block
 block discarded – undo
635 716
          * @var Attribute\Finalize|null $attribute
636 717
          */
637 718
         $attribute = ($ctx->reflection->getAttributes(Attribute\Finalize::class)[0] ?? null)?->newInstance();
638
-        if ($attribute === null) {
719
+        if ($attribute === null)
720
+        {
639 721
             return null;
640 722
         }
641 723
 
@@ -649,10 +731,14 @@  discard block
 block discarded – undo
649 731
     {
650 732
         $scope = $this->scope;
651 733
 
652
-        while ($scope !== null) {
653
-            foreach ($this->state->inflectors as $class => $inflectors) {
654
-                if ($instance instanceof $class) {
655
-                    foreach ($inflectors as $inflector) {
734
+        while ($scope !== null)
735
+        {
736
+            foreach ($this->state->inflectors as $class => $inflectors)
737
+            {
738
+                if ($instance instanceof $class)
739
+                {
740
+                    foreach ($inflectors as $inflector)
741
+                    {
656 742
                         $instance = $inflector->getParametersCount() > 1
657 743
                             ? $this->invoker->invoke($inflector->inflector, [$instance])
658 744
                             : ($inflector->inflector)($instance);
@@ -668,9 +754,12 @@  discard block
 block discarded – undo
668 754
 
669 755
     private function validateArguments(ContextFunction $reflection, array $arguments = []): bool
670 756
     {
671
-        try {
757
+        try
758
+        {
672 759
             $this->resolver->validateArguments($reflection, $arguments);
673
-        } catch (\Throwable) {
760
+        }
761
+        catch (\Throwable)
762
+        {
674 763
             return false;
675 764
         }
676 765
 
Please login to merge, or discard this patch.