Passed
Pull Request — master (#368)
by Valentin
04:11
created
src/DataGrid/src/InputMapper.php 2 patches
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -32,15 +32,15 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function hasOption(string $option): bool
34 34
     {
35
-        if (!isset($this->mapped[$option])) {
35
+        if (!isset($this->mapped[$option])){
36 36
             return $this->input->hasValue($option);
37 37
         }
38 38
 
39 39
         $mappedOptions = $this->mapped[$option];
40
-        foreach ($mappedOptions as $mappedOption) {
40
+        foreach ($mappedOptions as $mappedOption){
41 41
             $paths = $mappedOption[0];
42 42
             $firstPath = array_shift($paths);
43
-            if ($this->input->hasValue($firstPath)) {
43
+            if ($this->input->hasValue($firstPath)){
44 44
                 return true;
45 45
             }
46 46
         }
@@ -54,33 +54,33 @@  discard block
 block discarded – undo
54 54
      */
55 55
     public function getOption(string $option)
56 56
     {
57
-        if (!isset($this->mapped[$option])) {
57
+        if (!isset($this->mapped[$option])){
58 58
             return $this->input->getValue($option);
59 59
         }
60 60
 
61 61
         $mappedOptions = $this->mapped[$option];
62 62
         $output = [];
63
-        foreach ($mappedOptions as $mappedOption) {
63
+        foreach ($mappedOptions as $mappedOption){
64 64
             [$paths, $to] = $mappedOption;
65 65
             $firstPath = array_shift($paths);
66
-            if (!$this->input->hasValue($firstPath)) {
66
+            if (!$this->input->hasValue($firstPath)){
67 67
                 continue;
68 68
             }
69 69
 
70 70
             $data = $this->input->getValue($firstPath);
71
-            if (!empty($paths) && !is_array($data)) {
71
+            if (!empty($paths) && !is_array($data)){
72 72
                 continue;
73 73
             }
74 74
 
75
-            foreach ($paths as $path) {
76
-                if (!is_array($data) || !isset($data[$path])) {
75
+            foreach ($paths as $path){
76
+                if (!is_array($data) || !isset($data[$path])){
77 77
                     continue 2;
78 78
                 }
79 79
                 $data = $data[$path];
80 80
             }
81 81
 
82 82
             $result = $data;
83
-            foreach ($to as $path) {
83
+            foreach ($to as $path){
84 84
                 $result = [$path => $result];
85 85
             }
86 86
 
@@ -92,10 +92,10 @@  discard block
 block discarded – undo
92 92
 
93 93
     protected function map(): void
94 94
     {
95
-        foreach ($this->mapping as $from => $to) {
95
+        foreach ($this->mapping as $from => $to){
96 96
             $to = explode('.', $to);
97 97
             $option = array_shift($to);
98
-            if (!isset($this->mapped[$option])) {
98
+            if (!isset($this->mapped[$option])){
99 99
                 $this->mapped[$option] = [];
100 100
             }
101 101
             $this->mapped[$option][] = [explode('.', $from), array_reverse($to)];
Please login to merge, or discard this patch.
Braces   +24 added lines, -12 removed lines patch added patch discarded remove patch
@@ -32,15 +32,18 @@  discard block
 block discarded – undo
32 32
 
33 33
     public function hasOption(string $option): bool
34 34
     {
35
-        if (!isset($this->mapped[$option])) {
35
+        if (!isset($this->mapped[$option]))
36
+        {
36 37
             return $this->input->hasValue($option);
37 38
         }
38 39
 
39 40
         $mappedOptions = $this->mapped[$option];
40
-        foreach ($mappedOptions as $mappedOption) {
41
+        foreach ($mappedOptions as $mappedOption)
42
+        {
41 43
             $paths = $mappedOption[0];
42 44
             $firstPath = array_shift($paths);
43
-            if ($this->input->hasValue($firstPath)) {
45
+            if ($this->input->hasValue($firstPath))
46
+            {
44 47
                 return true;
45 48
             }
46 49
         }
@@ -54,33 +57,40 @@  discard block
 block discarded – undo
54 57
      */
55 58
     public function getOption(string $option)
56 59
     {
57
-        if (!isset($this->mapped[$option])) {
60
+        if (!isset($this->mapped[$option]))
61
+        {
58 62
             return $this->input->getValue($option);
59 63
         }
60 64
 
61 65
         $mappedOptions = $this->mapped[$option];
62 66
         $output = [];
63
-        foreach ($mappedOptions as $mappedOption) {
67
+        foreach ($mappedOptions as $mappedOption)
68
+        {
64 69
             [$paths, $to] = $mappedOption;
65 70
             $firstPath = array_shift($paths);
66
-            if (!$this->input->hasValue($firstPath)) {
71
+            if (!$this->input->hasValue($firstPath))
72
+            {
67 73
                 continue;
68 74
             }
69 75
 
70 76
             $data = $this->input->getValue($firstPath);
71
-            if (!empty($paths) && !is_array($data)) {
77
+            if (!empty($paths) && !is_array($data))
78
+            {
72 79
                 continue;
73 80
             }
74 81
 
75
-            foreach ($paths as $path) {
76
-                if (!is_array($data) || !isset($data[$path])) {
82
+            foreach ($paths as $path)
83
+            {
84
+                if (!is_array($data) || !isset($data[$path]))
85
+                {
77 86
                     continue 2;
78 87
                 }
79 88
                 $data = $data[$path];
80 89
             }
81 90
 
82 91
             $result = $data;
83
-            foreach ($to as $path) {
92
+            foreach ($to as $path)
93
+            {
84 94
                 $result = [$path => $result];
85 95
             }
86 96
 
@@ -92,10 +102,12 @@  discard block
 block discarded – undo
92 102
 
93 103
     protected function map(): void
94 104
     {
95
-        foreach ($this->mapping as $from => $to) {
105
+        foreach ($this->mapping as $from => $to)
106
+        {
96 107
             $to = explode('.', $to);
97 108
             $option = array_shift($to);
98
-            if (!isset($this->mapped[$option])) {
109
+            if (!isset($this->mapped[$option]))
110
+            {
99 111
                 $this->mapped[$option] = [];
100 112
             }
101 113
             $this->mapped[$option][] = [explode('.', $from), array_reverse($to)];
Please login to merge, or discard this patch.
src/DataGrid/tests/MapperTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
             $mapper->getOption('sort')
80 80
         );
81 81
         $this->assertSame(
82
-            ['byOldestFilter' => false,],
82
+            ['byOldestFilter' => false, ],
83 83
             $mapper->getOption('filter')
84 84
         );
85 85
     }
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
             $mapper->getOption('sort')
119 119
         );
120 120
         $this->assertSame(
121
-            ['by' => ['oldest' => false],],
121
+            ['by' => ['oldest' => false], ],
122 122
             $mapper->getOption('filter')
123 123
         );
124 124
     }
Please login to merge, or discard this patch.
src/DataGrid/src/GridFactory.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
         ['view' => $view, 'source' => $source] = $this->applySorters($view, $source, $schema);
117 117
         ['view' => $view, 'source' => $source] = $this->applyPaginator($view, $source, $schema);
118 118
 
119
-        if (!is_iterable($source)) {
119
+        if (!is_iterable($source)){
120 120
             throw new GridViewException('GridView expects the source to be iterable after all.');
121 121
         }
122 122
 
@@ -134,11 +134,11 @@  discard block
 block discarded – undo
134 134
     protected function getFilters($source, GridSchema $schema): array
135 135
     {
136 136
         $filters = [];
137
-        foreach ($this->getOptionArray(static::KEY_FILTER) ?? [] as $name => $value) {
138
-            if ($schema->hasFilter($name)) {
137
+        foreach ($this->getOptionArray(static::KEY_FILTER) ?? [] as $name => $value){
138
+            if ($schema->hasFilter($name)){
139 139
                 $filter = $schema->getFilter($name)->withValue($value);
140 140
 
141
-                if ($filter !== null) {
141
+                if ($filter !== null){
142 142
                     $source = $this->compiler->compile($source, $filter);
143 143
                     $filters[$name] = $filter->getValue();
144 144
                 }
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
 
151 151
     protected function applyCounter(GridInterface $view, $source, GridSchema $schema): array
152 152
     {
153
-        if (is_countable($source) && $this->getOption(static::KEY_FETCH_COUNT)) {
153
+        if (is_countable($source) && $this->getOption(static::KEY_FETCH_COUNT)){
154 154
             $view = $view->withOption(GridInterface::COUNT, ($this->count)($source));
155 155
         }
156 156
 
@@ -168,11 +168,11 @@  discard block
 block discarded – undo
168 168
     protected function getSorters($source, GridSchema $schema): array
169 169
     {
170 170
         $sorters = [];
171
-        foreach ($this->getOptionArray(static::KEY_SORT) ?? [] as $name => $value) {
172
-            if ($schema->hasSorter($name)) {
171
+        foreach ($this->getOptionArray(static::KEY_SORT) ?? [] as $name => $value){
172
+            if ($schema->hasSorter($name)){
173 173
                 $sorter = $schema->getSorter($name)->withDirection($value);
174 174
 
175
-                if ($sorter !== null) {
175
+                if ($sorter !== null){
176 176
                     $source = $this->compiler->compile($source, $sorter);
177 177
                     $sorters[$name] = $sorter->getValue();
178 178
                 }
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
     protected function applyPaginator(GridInterface $view, $source, GridSchema $schema): array
186 186
     {
187
-        if ($schema->getPaginator() !== null) {
187
+        if ($schema->getPaginator() !== null){
188 188
             ['source' => $source, 'paginator' => $paginator] = $this->getPaginator($source, $schema);
189 189
             $view = $view->withOption(GridInterface::PAGINATOR, $paginator);
190 190
         }
@@ -195,12 +195,12 @@  discard block
 block discarded – undo
195 195
     protected function getPaginator($source, GridSchema $schema): array
196 196
     {
197 197
         $paginator = $schema->getPaginator();
198
-        if (!$paginator instanceof FilterInterface) {
198
+        if (!$paginator instanceof FilterInterface){
199 199
             throw new CompilerException('Paginator can not be null');
200 200
         }
201 201
 
202 202
         $withValue = $paginator->withValue($this->getOption(static::KEY_PAGINATE));
203
-        if ($withValue === null) {
203
+        if ($withValue === null){
204 204
             throw new CompilerException('Paginator can not be null');
205 205
         }
206 206
 
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     protected function getOptionArray(string $option): array
220 220
     {
221 221
         $result = $this->getOption($option);
222
-        if (!is_array($result)) {
222
+        if (!is_array($result)){
223 223
             return [];
224 224
         }
225 225
 
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
      */
235 235
     protected function getOption(string $option)
236 236
     {
237
-        if ($this->mapper->hasOption($option)) {
237
+        if ($this->mapper->hasOption($option)){
238 238
             return $this->mapper->getOption($option);
239 239
         }
240 240
 
Please login to merge, or discard this patch.
Braces   +26 added lines, -13 removed lines patch added patch discarded remove patch
@@ -116,7 +116,8 @@  discard block
 block discarded – undo
116 116
         ['view' => $view, 'source' => $source] = $this->applySorters($view, $source, $schema);
117 117
         ['view' => $view, 'source' => $source] = $this->applyPaginator($view, $source, $schema);
118 118
 
119
-        if (!is_iterable($source)) {
119
+        if (!is_iterable($source))
120
+        {
120 121
             throw new GridViewException('GridView expects the source to be iterable after all.');
121 122
         }
122 123
 
@@ -134,11 +135,14 @@  discard block
 block discarded – undo
134 135
     protected function getFilters($source, GridSchema $schema): array
135 136
     {
136 137
         $filters = [];
137
-        foreach ($this->getOptionArray(static::KEY_FILTER) ?? [] as $name => $value) {
138
-            if ($schema->hasFilter($name)) {
138
+        foreach ($this->getOptionArray(static::KEY_FILTER) ?? [] as $name => $value)
139
+        {
140
+            if ($schema->hasFilter($name))
141
+            {
139 142
                 $filter = $schema->getFilter($name)->withValue($value);
140 143
 
141
-                if ($filter !== null) {
144
+                if ($filter !== null)
145
+                {
142 146
                     $source = $this->compiler->compile($source, $filter);
143 147
                     $filters[$name] = $filter->getValue();
144 148
                 }
@@ -150,7 +154,8 @@  discard block
 block discarded – undo
150 154
 
151 155
     protected function applyCounter(GridInterface $view, $source, GridSchema $schema): array
152 156
     {
153
-        if (is_countable($source) && $this->getOption(static::KEY_FETCH_COUNT)) {
157
+        if (is_countable($source) && $this->getOption(static::KEY_FETCH_COUNT))
158
+        {
154 159
             $view = $view->withOption(GridInterface::COUNT, ($this->count)($source));
155 160
         }
156 161
 
@@ -168,11 +173,14 @@  discard block
 block discarded – undo
168 173
     protected function getSorters($source, GridSchema $schema): array
169 174
     {
170 175
         $sorters = [];
171
-        foreach ($this->getOptionArray(static::KEY_SORT) ?? [] as $name => $value) {
172
-            if ($schema->hasSorter($name)) {
176
+        foreach ($this->getOptionArray(static::KEY_SORT) ?? [] as $name => $value)
177
+        {
178
+            if ($schema->hasSorter($name))
179
+            {
173 180
                 $sorter = $schema->getSorter($name)->withDirection($value);
174 181
 
175
-                if ($sorter !== null) {
182
+                if ($sorter !== null)
183
+                {
176 184
                     $source = $this->compiler->compile($source, $sorter);
177 185
                     $sorters[$name] = $sorter->getValue();
178 186
                 }
@@ -184,7 +192,8 @@  discard block
 block discarded – undo
184 192
 
185 193
     protected function applyPaginator(GridInterface $view, $source, GridSchema $schema): array
186 194
     {
187
-        if ($schema->getPaginator() !== null) {
195
+        if ($schema->getPaginator() !== null)
196
+        {
188 197
             ['source' => $source, 'paginator' => $paginator] = $this->getPaginator($source, $schema);
189 198
             $view = $view->withOption(GridInterface::PAGINATOR, $paginator);
190 199
         }
@@ -195,12 +204,14 @@  discard block
 block discarded – undo
195 204
     protected function getPaginator($source, GridSchema $schema): array
196 205
     {
197 206
         $paginator = $schema->getPaginator();
198
-        if (!$paginator instanceof FilterInterface) {
207
+        if (!$paginator instanceof FilterInterface)
208
+        {
199 209
             throw new CompilerException('Paginator can not be null');
200 210
         }
201 211
 
202 212
         $withValue = $paginator->withValue($this->getOption(static::KEY_PAGINATE));
203
-        if ($withValue === null) {
213
+        if ($withValue === null)
214
+        {
204 215
             throw new CompilerException('Paginator can not be null');
205 216
         }
206 217
 
@@ -219,7 +230,8 @@  discard block
 block discarded – undo
219 230
     protected function getOptionArray(string $option): array
220 231
     {
221 232
         $result = $this->getOption($option);
222
-        if (!is_array($result)) {
233
+        if (!is_array($result))
234
+        {
223 235
             return [];
224 236
         }
225 237
 
@@ -234,7 +246,8 @@  discard block
 block discarded – undo
234 246
      */
235 247
     protected function getOption(string $option)
236 248
     {
237
-        if ($this->mapper->hasOption($option)) {
249
+        if ($this->mapper->hasOption($option))
250
+        {
238 251
             return $this->mapper->getOption($option);
239 252
         }
240 253
 
Please login to merge, or discard this patch.