Record::save() - Code Metrics - Inspection of "transactions and relations" - spiral/components - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — feature/pre-split (4cb052)

by Anton

created 2017-01-12 22:12 UTC

Record::save() A

↳ Parent: Record

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	3
nop	2
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * components
 *
 * @author    Wolfy-J
 */
namespace Spiral\ORM;

use Spiral\Models\ActiveEntityInterface;
use Spiral\ORM\Commands\InsertCommand;
use Spiral\ORM\Commands\UpdateCommand;

/**
 * Adds ActiveRecord abilities to RecordEntity.
 */
abstract class Record extends RecordEntity implements ActiveEntityInterface
{
   public function save(TransactionInterface $transaction = null, bool $queueRelations = true): int
    {
        //saturate transaction
        $transaction->addCommand($command = $this->queueSave($queueRelations));
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}

        if ($command instanceof InsertCommand) {
            return self::CREATED;
        } elseif ($command instanceof UpdateCommand) {
            return self::UPDATED;
        }

        return self::UNCHANGED;
    }

    public function delete(TransactionInterface $transaction = null)
    {
        //saturate transaction

        $transaction->addCommand($this->queueDelete());
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
    }
}

1			<?php
2			/**
3			* components
4			*
5			* @author Wolfy-J
6			*/
7			namespace Spiral\ORM;
8
9			use Spiral\Models\ActiveEntityInterface;
10			use Spiral\ORM\Commands\InsertCommand;
11			use Spiral\ORM\Commands\UpdateCommand;
12
13			/**
14			* Adds ActiveRecord abilities to RecordEntity.
15			*/
16			abstract class Record extends RecordEntity implements ActiveEntityInterface
17			{
18			public function save(TransactionInterface $transaction = null, bool $queueRelations = true): int
19			{
20			//saturate transaction
21			$transaction->addCommand($command = $this->queueSave($queueRelations));
			0 ignored issues – show Bug introduced 2017-01-12 22:15 UTC by Report Bug Copy Issue Report It seems like `$transaction` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
22
23			if ($command instanceof InsertCommand) {
24			return self::CREATED;
25			} elseif ($command instanceof UpdateCommand) {
26			return self::UPDATED;
27			}
28
29			return self::UNCHANGED;
30			}
31
32			public function delete(TransactionInterface $transaction = null)
33			{
34			//saturate transaction
35
36			$transaction->addCommand($this->queueDelete());
			0 ignored issues – show Bug introduced 2017-01-12 22:15 UTC by Report Bug Copy Issue Report It seems like `$transaction` is not always an object, but can also be of type `null`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
37			}
38			}

spiral / components

Branch — feature/pre-split (4cb052)

Record::save() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like