Spiral\ORM\Record

Complexity

Total Complexity

4

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	save()	0	13	3
A	delete()	0	6	1

<?php
/**
 * components
 *
 * @author    Wolfy-J
 */
namespace Spiral\ORM;

use Spiral\Models\ActiveEntityInterface;
use Spiral\ORM\Commands\InsertCommand;
use Spiral\ORM\Commands\UpdateCommand;

/**
 * Adds ActiveRecord abilities to RecordEntity.
 */
abstract class Record extends RecordEntity implements ActiveEntityInterface
{
   public function save(TransactionInterface $transaction = null, bool $queueRelations = true): int
    {
        //saturate transaction
        $transaction->addCommand($command = $this->queueSave($queueRelations));

It seems like $transaction is not always an object, but can also be of type null. Maybe add an additional type check?

        if ($command instanceof InsertCommand) {
            return self::CREATED;
        } elseif ($command instanceof UpdateCommand) {
            return self::UPDATED;
        }

        return self::UNCHANGED;
    }

    public function delete(TransactionInterface $transaction = null)
    {
        //saturate transaction

        $transaction->addCommand($this->queueDelete());

It seems like $transaction is not always an object, but can also be of type null. Maybe add an additional type check?

    }
}