WelcomeController::savePassword() - Code Metrics - Inspection of "wip" - spatie/laravel-welcome-notification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 890028...40491b )

by Freek

created 2020-03-09 19:59 UTC

WelcomeController::savePassword() A

↳ Parent: WelcomeController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Spatie\WelcomeNotification;

use Illuminate\Foundation\Auth\User;
use Illuminate\Http\Request;
use Symfony\Component\HttpFoundation\Response;

class WelcomeController
{
    public function showWelcomeForm(Request $request, User $user)
    {
        return view('welcomeNotification::welcome')->with([
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            'email' => $request->email,
            'user' => $user,
        ]);
    }

    public function savePassword(Request $request, User $user)
    {
        $request->validate($this->rules());


        $user->password = bcrypt($request->password);
        $user->welcome_valid_until = null;
        $user->save();

        auth()->login($user);

        return $this->sendPasswordSavedResponse();
    }

    protected function sendPasswordSavedResponse(): Response
    {
        return redirect()->to($this->redirectPath())->with('status', 'Welcome! You are now logged in!');
    }

    protected function rules()
    {
        return [
            'password' => 'required|confirmed|min:8',
        ];
    }

    public function redirectPath()
    {
        if (method_exists($this, 'redirectTo')) {
            return $this->redirectTo();

        }

        return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace Spatie\WelcomeNotification;
4
5			use Illuminate\Foundation\Auth\User;
6			use Illuminate\Http\Request;
7			use Symfony\Component\HttpFoundation\Response;
8
9			class WelcomeController
10			{
11			public function showWelcomeForm(Request $request, User $user)
12			{
13			return view('welcomeNotification::welcome')->with([
			0 ignored issues – show Bug introduced 2019-11-12 11:58 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
14			'email' => $request->email,
15			'user' => $user,
16			]);
17			}
18
19			public function savePassword(Request $request, User $user)
20			{
21			$request->validate($this->rules());
			0 ignored issues – show Bug introduced 2020-03-09 20:13 UTC by Report Bug Copy Issue Report The call to `validate()` misses a required argument `$...$params`. This check looks for function calls that miss required arguments. Loading history...
22
23			$user->password = bcrypt($request->password);
24			$user->welcome_valid_until = null;
25			$user->save();
26
27			auth()->login($user);
28
29			return $this->sendPasswordSavedResponse();
30			}
31
32			protected function sendPasswordSavedResponse(): Response
33			{
34			return redirect()->to($this->redirectPath())->with('status', 'Welcome! You are now logged in!');
35			}
36
37			protected function rules()
38			{
39			return [
40			'password' => 'required\|confirmed\|min:8',
41			];
42			}
43
44			public function redirectPath()
45			{
46			if (method_exists($this, 'redirectTo')) {
47			return $this->redirectTo();
			0 ignored issues – show Bug introduced 2020-03-09 20:13 UTC by Report Bug Copy Issue Report The method `redirectTo()` does not seem to exist on `object<Spatie\WelcomeNot...tion\WelcomeController>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
48			}
49
50			return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';
			0 ignored issues – show Bug introduced 2020-03-09 20:13 UTC by Report Bug Copy Issue Report The property `redirectTo` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
51			}
52			}
53

spatie / laravel-welcome-notification

GitHub Access Token became invalid

Push — master ( 890028...40491b )

WelcomeController::savePassword() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like