Spatie\WelcomeNotification\WelcomeController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	showWelcomeForm()	0	7	1
A	savePassword()	0	12	1
A	sendPasswordSavedResponse()	0	4	1
A	rules()	0	6	1
A	redirectPath()	0	8	3

<?php

namespace Spatie\WelcomeNotification;

use Illuminate\Foundation\Auth\User;
use Illuminate\Http\Request;
use Symfony\Component\HttpFoundation\Response;

class WelcomeController
{
    public function showWelcomeForm(Request $request, User $user)
    {
        return view('welcomeNotification::welcome')->with([

The method with does only exist in Illuminate\View\View, but not in Illuminate\Contracts\View\Factory.

            'email' => $request->email,
            'user' => $user,
        ]);
    }

    public function savePassword(Request $request, User $user)
    {
        $request->validate($this->rules());

The call to validate() misses a required argument $...$params.

        $user->password = bcrypt($request->password);
        $user->welcome_valid_until = null;
        $user->save();

        auth()->login($user);

        return $this->sendPasswordSavedResponse();
    }

    protected function sendPasswordSavedResponse(): Response
    {
        return redirect()->to($this->redirectPath())->with('status', 'Welcome! You are now logged in!');
    }

    protected function rules()
    {
        return [
            'password' => 'required|confirmed|min:8',
        ];
    }

    public function redirectPath()
    {
        if (method_exists($this, 'redirectTo')) {
            return $this->redirectTo();

The method redirectTo() does not seem to exist on object<Spatie\WelcomeNotification\WelcomeController>.

        }

        return property_exists($this, 'redirectTo') ? $this->redirectTo : '/home';

The property redirectTo does not exist. Did you maybe forget to declare it?

    }
}