VerifySlackRequest::handle() - Code Metrics - Inspection of "new signature verifying" - spatie/laravel-slack-slash-command - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#76)

unknown

created 2019-01-15 16:41 UTC

VerifySlackRequest::handle() A

↳ Parent: VerifySlackRequest

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace Spatie\SlashCommand\Middleware;

use Closure;
use Spatie\SlashCommand\SlackRequestSignature;

class VerifySlackRequest
{
    /** @var SlackRequestSignature */
    private $slackRequestSignature;

    public function __construct(SlackRequestSignature $slackRequestSignature)
    {
        $this->slackRequestSignature = $slackRequestSignature;
    }

    /**
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $signature = $this->slackRequestSignature->create($request);

        if (!$this->isEqualsSignature($signature, $request->header('X-Slack-Signature'))) {

            abort(401, 'The request had an invalid signature.');
        }

        return $next($request);
    }

    private function isEqualsSignature(string $signature, string $slackSignature): bool
    {
        return $signature === $slackSignature;
    }
}


1			<?php
2
3			namespace Spatie\SlashCommand\Middleware;
4
5			use Closure;
6			use Spatie\SlashCommand\SlackRequestSignature;
7
8			class VerifySlackRequest
9			{
10			/** @var SlackRequestSignature */
11			private $slackRequestSignature;
12
13			public function __construct(SlackRequestSignature $slackRequestSignature)
14			{
15			$this->slackRequestSignature = $slackRequestSignature;
16			}
17
18			/**
19			* @param \Illuminate\Http\Request $request
20			* @param \Closure $next
21			*
22			* @return mixed
23			*/
24			public function handle($request, Closure $next)
25			{
26			$signature = $this->slackRequestSignature->create($request);
27
28			if (!$this->isEqualsSignature($signature, $request->header('X-Slack-Signature'))) {
			0 ignored issues – show Bug introduced 2019-01-15 16:52 UTC by Report Bug Copy Issue Report It seems like `$request->header('X-Slack-Signature')` targeting `Illuminate\Http\Concerns...actsWithInput::header()` can also be of type `array` or `null`; however, `Spatie\SlashCommand\Midd...st::isEqualsSignature()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
29			abort(401, 'The request had an invalid signature.');
30			}
31
32			return $next($request);
33			}
34
35			private function isEqualsSignature(string $signature, string $slackSignature): bool
36			{
37			return $signature === $slackSignature;
38			}
39			}
40

spatie / laravel-slack-slash-command

GitHub Access Token became invalid

Pull Request — master (#76)

VerifySlackRequest::handle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like