Spatie\SlashCommand\Middleware\VerifySlackRequest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	handle()	0	10	2
A	isEqualsSignature()	0	4	1

<?php

namespace Spatie\SlashCommand\Middleware;

use Closure;
use Spatie\SlashCommand\SlackRequestSignature;

class VerifySlackRequest
{
    /** @var SlackRequestSignature */
    private $slackRequestSignature;

    public function __construct(SlackRequestSignature $slackRequestSignature)
    {
        $this->slackRequestSignature = $slackRequestSignature;
    }

    /**
     * @param \Illuminate\Http\Request $request
     * @param \Closure $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $signature = $this->slackRequestSignature->create($request);

        if (!$this->isEqualsSignature($signature, $request->header('X-Slack-Signature'))) {

It seems like $request->header('X-Slack-Signature') targeting Illuminate\Http\Concerns\InteractsWithInput::header() can also be of type array or null; however, Spatie\SlashCommand\Middleware\VerifySlackRequest::isEqualsSignature() does only seem to accept string, maybe add an additional type check?

            abort(401, 'The request had an invalid signature.');
        }

        return $next($request);
    }

    private function isEqualsSignature(string $signature, string $slackSignature): bool
    {
        return $signature === $slackSignature;
    }
}