Completed
Pull Request — master (#31)
by Freek
04:47 queued 02:15
created
src/BaseElement.php 2 patches
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,12 +2,12 @@
 block discarded – undo
2 2
 
3 3
 namespace Spatie\Html;
4 4
 
5
+use Illuminate\Contracts\Support\Htmlable;
5 6
 use Illuminate\Support\Collection;
6 7
 use Illuminate\Support\HtmlString;
7
-use Spatie\Html\Exceptions\MissingTag;
8
-use Spatie\Html\Exceptions\InvalidHtml;
9 8
 use Spatie\Html\Exceptions\InvalidChild;
10
-use Illuminate\Contracts\Support\Htmlable;
9
+use Spatie\Html\Exceptions\InvalidHtml;
10
+use Spatie\Html\Exceptions\MissingTag;
11 11
 
12 12
 abstract class BaseElement implements Htmlable, HtmlElement
13 13
 {
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     /**
174 174
      * Alias for `addChildren`.
175 175
      *
176
-     * @param \Spatie\Html\HtmlElement|string|iterable|null $children
176
+     * @param Elements\Input $child
177 177
      * @param callable|null $mapper
178 178
      *
179 179
      * @return static
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
     /**
187 187
      * Alias for `addChildren`.
188 188
      *
189
-     * @param \Spatie\Html\HtmlElement|string|iterable|null $children
189
+     * @param \Spatie\Html\HtmlElement|string|iterable|null $child
190 190
      * @param callable|null $mapper
191 191
      *
192 192
      * @return static
@@ -358,6 +358,9 @@  discard block
 block discarded – undo
358 358
         return $this->render();
359 359
     }
360 360
 
361
+    /**
362
+     * @param callable $mapper
363
+     */
361 364
     protected function parseChildren($children, $mapper = null): Collection
362 365
     {
363 366
         if ($children instanceof HtmlElement) {
Please login to merge, or discard this patch.
src/Elements/Fieldset.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     protected $tag = 'fieldset';
10 10
 
11 11
     /**
12
-     * @param \Spatie\Html\HtmlElement|string $text
13 12
      *
14 13
      * @return static
15 14
      */
Please login to merge, or discard this patch.
Unused Use Statements   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,8 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace Spatie\Html\Elements;
4 4
 
5
-use Spatie\Html\BaseElement;
6 5
 use Illuminate\Support\Traits\Macroable;
6
+use Spatie\Html\BaseElement;
7 7
 
8 8
 class Fieldset extends BaseElement
9 9
 {
Please login to merge, or discard this patch.
src/Elements/Select.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
     }
65 65
 
66 66
     /**
67
-     * @param string|null $test
67
+     * @param string|null $text
68 68
      *
69 69
      * @return static
70 70
      */
Please login to merge, or discard this patch.
Unused Use Statements   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -2,11 +2,11 @@
 block discarded – undo
2 2
 
3 3
 namespace Spatie\Html\Elements;
4 4
 
5
-use Illuminate\Support\Str;
6
-use Spatie\Html\Selectable;
7
-use Spatie\Html\BaseElement;
8 5
 use Illuminate\Support\Collection;
6
+use Illuminate\Support\Str;
9 7
 use Illuminate\Support\Traits\Macroable;
8
+use Spatie\Html\BaseElement;
9
+use Spatie\Html\Selectable;
10 10
 
11 11
 class Select extends BaseElement
12 12
 {
Please login to merge, or discard this patch.
src/Html.php 2 patches
Doc Comments   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 
36 36
     /**
37 37
      * @param string|null $href
38
-     * @param string|null $text
38
+     * @param string $contents
39 39
      *
40 40
      * @return \Spatie\Html\Elements\A
41 41
      */
@@ -48,7 +48,6 @@  discard block
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * @param string|null $type
51
-     * @param string|null $text
52 51
      *
53 52
      * @return \Spatie\Html\Elements\Button
54 53
      */
@@ -238,7 +237,6 @@  discard block
 block discarded – undo
238 237
     }
239 238
 
240 239
     /**
241
-     * @param string|null $value
242 240
      *
243 241
      * @return \Spatie\Html\Elements\Input
244 242
      */
@@ -287,7 +285,7 @@  discard block
 block discarded – undo
287 285
     }
288 286
 
289 287
     /**
290
-     * @param string|null $test
288
+     * @param string|null $text
291 289
      *
292 290
      * @return \Spatie\Html\Elements\Button
293 291
      */
@@ -390,7 +388,7 @@  discard block
 block discarded – undo
390 388
      * @param string $name
391 389
      * @param mixed $value
392 390
      *
393
-     * @return mixed
391
+     * @return string|null
394 392
      */
395 393
     protected function old($name, $value = null)
396 394
     {
Please login to merge, or discard this patch.
Unused Use Statements   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -2,24 +2,24 @@
 block discarded – undo
2 2
 
3 3
 namespace Spatie\Html;
4 4
 
5
-use Spatie\Html\Elements\A;
5
+use Illuminate\Contracts\Support\Htmlable;
6 6
 use Illuminate\Http\Request;
7
+use Illuminate\Support\Collection;
8
+use Illuminate\Support\HtmlString;
9
+use Illuminate\Support\Traits\Macroable;
10
+use Spatie\Html\Elements\A;
11
+use Spatie\Html\Elements\Button;
7 12
 use Spatie\Html\Elements\Div;
13
+use Spatie\Html\Elements\Element;
14
+use Spatie\Html\Elements\Fieldset;
8 15
 use Spatie\Html\Elements\Form;
9
-use Spatie\Html\Elements\Span;
10 16
 use Spatie\Html\Elements\Input;
11 17
 use Spatie\Html\Elements\Label;
12
-use Spatie\Html\Elements\Button;
13 18
 use Spatie\Html\Elements\Legend;
14 19
 use Spatie\Html\Elements\Option;
15 20
 use Spatie\Html\Elements\Select;
16
-use Spatie\Html\Elements\Element;
17
-use Illuminate\Support\Collection;
18
-use Illuminate\Support\HtmlString;
19
-use Spatie\Html\Elements\Fieldset;
21
+use Spatie\Html\Elements\Span;
20 22
 use Spatie\Html\Elements\Textarea;
21
-use Illuminate\Support\Traits\Macroable;
22
-use Illuminate\Contracts\Support\Htmlable;
23 23
 
24 24
 class Html
25 25
 {
Please login to merge, or discard this patch.