Completed
Pull Request — master (#149)
by
unknown
01:28
created
src/Elements/Fieldset.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
     protected $tag = 'fieldset';
10 10
 
11 11
     /**
12
-     * @param \Spatie\Html\HtmlElement|string $text
13 12
      *
14 13
      * @return static
15 14
      */
Please login to merge, or discard this patch.
src/Elements/Select.php 2 patches
Unused Use Statements   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2,10 +2,10 @@
 block discarded – undo
2 2
 
3 3
 namespace Spatie\Html\Elements;
4 4
 
5
+use Illuminate\Support\Collection;
5 6
 use Illuminate\Support\Str;
6
-use Spatie\Html\Selectable;
7 7
 use Spatie\Html\BaseElement;
8
-use Illuminate\Support\Collection;
8
+use Spatie\Html\Selectable;
9 9
 
10 10
 class Select extends BaseElement
11 11
 {
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -137,6 +137,9 @@
 block discarded – undo
137 137
         $this->children = $this->applyValueToElements($value, $this->children);
138 138
     }
139 139
 
140
+    /**
141
+     * @param Collection $value
142
+     */
140 143
     protected function applyValueToElements($value, Collection $children)
141 144
     {
142 145
         return $children->map(function ($child) use ($value) {
Please login to merge, or discard this patch.
src/Elements/File.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
     }
50 50
 
51 51
     /**
52
-     * @param string|null $name
53 52
      *
54 53
      * @return static
55 54
      */
Please login to merge, or discard this patch.
src/Elements/Optgroup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@
 block discarded – undo
12 12
     protected $tag = 'optgroup';
13 13
 
14 14
     /**
15
-     * @param string|null $href
16 15
      *
16
+     * @param string $label
17 17
      * @return static
18 18
      */
19 19
     public function label($label)
Please login to merge, or discard this patch.
src/Html.php 2 patches
Doc Comments   +2 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 
42 42
     /**
43 43
      * @param string|null $href
44
-     * @param string|null $text
44
+     * @param string $contents
45 45
      *
46 46
      * @return \Spatie\Html\Elements\A
47 47
      */
@@ -53,8 +53,6 @@  discard block
 block discarded – undo
53 53
     }
54 54
 
55 55
     /**
56
-     * @param string|null $href
57
-     * @param string|null $text
58 56
      *
59 57
      * @return \Spatie\Html\Elements\I
60 58
      */
@@ -66,7 +64,7 @@  discard block
 block discarded – undo
66 64
 
67 65
     /**
68 66
      * @param string|null $type
69
-     * @param string|null $text
67
+     * @param string $contents
70 68
      *
71 69
      * @return \Spatie\Html\Elements\Button
72 70
      */
@@ -314,7 +312,6 @@  discard block
 block discarded – undo
314 312
     }
315 313
 
316 314
     /**
317
-     * @param string|null $value
318 315
      *
319 316
      * @return \Spatie\Html\Elements\Input
320 317
      */
@@ -516,7 +513,6 @@  discard block
 block discarded – undo
516 513
      * a public alias for `old`.
517 514
      *
518 515
      * @param string $name
519
-     * @param mixed $value
520 516
      *
521 517
      * @return mixed
522 518
      */
Please login to merge, or discard this patch.
Unused Use Statements   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -3,28 +3,28 @@
 block discarded – undo
3 3
 namespace Spatie\Html;
4 4
 
5 5
 use DateTimeImmutable;
6
+use Illuminate\Contracts\Support\Htmlable;
7
+use Illuminate\Http\Request;
8
+use Illuminate\Support\Collection;
9
+use Illuminate\Support\HtmlString;
6 10
 use Illuminate\Support\Str;
11
+use Illuminate\Support\Traits\Macroable;
7 12
 use Spatie\Html\Elements\A;
8
-use Spatie\Html\Elements\I;
9
-use Illuminate\Http\Request;
13
+use Spatie\Html\Elements\Button;
10 14
 use Spatie\Html\Elements\Div;
11
-use Spatie\Html\Elements\Img;
15
+use Spatie\Html\Elements\Element;
16
+use Spatie\Html\Elements\Fieldset;
12 17
 use Spatie\Html\Elements\File;
13 18
 use Spatie\Html\Elements\Form;
14
-use Spatie\Html\Elements\Span;
19
+use Spatie\Html\Elements\I;
20
+use Spatie\Html\Elements\Img;
15 21
 use Spatie\Html\Elements\Input;
16 22
 use Spatie\Html\Elements\Label;
17
-use Spatie\Html\Elements\Button;
18 23
 use Spatie\Html\Elements\Legend;
19 24
 use Spatie\Html\Elements\Option;
20 25
 use Spatie\Html\Elements\Select;
21
-use Spatie\Html\Elements\Element;
22
-use Illuminate\Support\Collection;
23
-use Illuminate\Support\HtmlString;
24
-use Spatie\Html\Elements\Fieldset;
26
+use Spatie\Html\Elements\Span;
25 27
 use Spatie\Html\Elements\Textarea;
26
-use Illuminate\Support\Traits\Macroable;
27
-use Illuminate\Contracts\Support\Htmlable;
28 28
 
29 29
 class Html
30 30
 {
Please login to merge, or discard this patch.
src/BaseElement.php 2 patches
Doc Comments   +10 added lines, -3 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      * @param string $attribute
89 89
      * @param mixed $fallback
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getAttribute($attribute, $fallback = null)
94 94
     {
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
     /**
193 193
      * Alias for `addChildren`.
194 194
      *
195
-     * @param \Spatie\Html\HtmlElement|string|iterable|null $children
195
+     * @param Elements\Input $child
196 196
      * @param callable|null $mapper
197 197
      *
198 198
      * @return static
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
     /**
206 206
      * Alias for `addChildren`.
207 207
      *
208
-     * @param \Spatie\Html\HtmlElement|string|iterable|null $children
208
+     * @param \Spatie\Html\HtmlElement|string|iterable|null $child
209 209
      * @param callable|null $mapper
210 210
      *
211 211
      * @return static
@@ -425,6 +425,10 @@  discard block
 block discarded – undo
425 425
         return $this->__macro_call($name, $arguments);
426 426
     }
427 427
 
428
+    /**
429
+     * @param string $type
430
+     * @param string $method
431
+     */
428 432
     protected function callConditionalMethod($type, $method, array $arguments)
429 433
     {
430 434
         $value = array_shift($arguments);
@@ -460,6 +464,9 @@  discard block
 block discarded – undo
460 464
         return $this->render();
461 465
     }
462 466
 
467
+    /**
468
+     * @param callable $mapper
469
+     */
463 470
     protected function parseChildren($children, $mapper = null): Collection
464 471
     {
465 472
         if ($children instanceof HtmlElement) {
Please login to merge, or discard this patch.
Unused Use Statements   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -3,14 +3,14 @@
 block discarded – undo
3 3
 namespace Spatie\Html;
4 4
 
5 5
 use BadMethodCallException;
6
-use Illuminate\Support\Str;
6
+use Illuminate\Contracts\Support\Htmlable;
7 7
 use Illuminate\Support\Collection;
8 8
 use Illuminate\Support\HtmlString;
9
-use Spatie\Html\Exceptions\MissingTag;
10
-use Spatie\Html\Exceptions\InvalidHtml;
9
+use Illuminate\Support\Str;
11 10
 use Illuminate\Support\Traits\Macroable;
12 11
 use Spatie\Html\Exceptions\InvalidChild;
13
-use Illuminate\Contracts\Support\Htmlable;
12
+use Spatie\Html\Exceptions\InvalidHtml;
13
+use Spatie\Html\Exceptions\MissingTag;
14 14
 
15 15
 abstract class BaseElement implements Htmlable, HtmlElement
16 16
 {
Please login to merge, or discard this patch.