PgSQLDatabaseTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	29.09 %

Coupling/Cohesion

Components	1
Dependencies	5

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	16	16	1
A	tearDown()	0	4	1
A	testFileExtension()	0	6	1
A	testDump()	0	20	1

<?php

use Mockery as m;
use Spatie\Backup\BackupHandlers\Database\Databases\PgSQLDatabase;

class PgSQLDatabaseTest extends Orchestra\Testbench\TestCase

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    protected $console;
    protected $database;

    public function setUp()

This method seems to be duplicated in your project.

    {
        parent::setUp();

        $this->console = m::mock('Spatie\Backup\Console');

        $this->database = new PgSQLDatabase(
            $this->console,
            'testDatabase',
            'public',
            'testUser',
            'password',
            'localhost',
            '5432'
        );
    }

    public function tearDown()
    {
        m::close();
    }

    public function testFileExtension()
    {
        $this->assertEquals(
            'sql', $this->database->getFileExtension()
        );
    }

    public function testDump()
    {
        $this->console->shouldReceive('run')
            ->with(m::on(function ($parameter) {
                $pattern = "/pg_dump --inserts --schema='public' 'testDatabase' > 'testfile.sql'/";

                return preg_match($pattern, $parameter) == true;

It seems like you are loosely comparing preg_match($pattern, $parameter) of type integer to the boolean true. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

            }), null, [
                'PGHOST' => 'localhost',
                'PGUSER' => 'testUser',
                'PGPASSWORD' => 'password',
                'PGPORT' => '5432'
            ])
            ->once()
            ->andReturn(true);

        $this->assertTrue(
            $this->database->dump('testfile.sql')
        );
    }
}