PgSQLDatabaseTest::testDump() - Code Metrics - Inspection of "Merge pull request #60 from Jamesking56/feature/po..." - spatie/laravel-backup - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 410526...963b63 )

by Freek

created 2016-01-04 18:09 UTC

PgSQLDatabaseTest::testDump() A

↳ Parent: PgSQLDatabaseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	20
rs	9.4286
cc	1
eloc	14
nc	1
nop	0

<?php

use Mockery as m;
use Spatie\Backup\BackupHandlers\Database\Databases\PgSQLDatabase;

class PgSQLDatabaseTest extends Orchestra\Testbench\TestCase
namespace YourVendor;

class YourClass { }
{
    protected $console;
    protected $database;

    public function setUp()

    {
        parent::setUp();

        $this->console = m::mock('Spatie\Backup\Console');

        $this->database = new PgSQLDatabase(
            $this->console,
            'testDatabase',
            'public',
            'testUser',
            'password',
            'localhost',
            '5432'
        );
    }

    public function tearDown()
    {
        m::close();
    }

    public function testFileExtension()
    {
        $this->assertEquals(
            'sql', $this->database->getFileExtension()
        );
    }

    public function testDump()
    {
        $this->console->shouldReceive('run')
            ->with(m::on(function ($parameter) {
                $pattern = "/pg_dump --inserts --schema='public' 'testDatabase' > 'testfile.sql'/";

                return preg_match($pattern, $parameter) == true;

            }), null, [
                'PGHOST' => 'localhost',
                'PGUSER' => 'testUser',
                'PGPASSWORD' => 'password',
                'PGPORT' => '5432'
            ])
            ->once()
            ->andReturn(true);

        $this->assertTrue(
            $this->database->dump('testfile.sql')
        );
    }
}

1		<?php
2
3		use Mockery as m;
4		use Spatie\Backup\BackupHandlers\Database\Databases\PgSQLDatabase;
5
6		class PgSQLDatabaseTest extends Orchestra\Testbench\TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7		{
8		protected $console;
9		protected $database;
10
11	View Code Duplication	public function setUp()
		0 ignored issues – show Duplication introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
12		{
13		parent::setUp();
14
15		$this->console = m::mock('Spatie\Backup\Console');
16
17		$this->database = new PgSQLDatabase(
18		$this->console,
19		'testDatabase',
20		'public',
21		'testUser',
22		'password',
23		'localhost',
24		'5432'
25		);
26		}
27
28		public function tearDown()
29		{
30		m::close();
31		}
32
33		public function testFileExtension()
34		{
35		$this->assertEquals(
36		'sql', $this->database->getFileExtension()
37		);
38		}
39
40		public function testDump()
41		{
42		$this->console->shouldReceive('run')
43		->with(m::on(function ($parameter) {
44		$pattern = "/pg_dump --inserts --schema='public' 'testDatabase' > 'testfile.sql'/";
45
46		return preg_match($pattern, $parameter) == true;
		0 ignored issues – show Bug Best Practice introduced 2016-01-01 23:24 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `preg_match($pattern, $parameter)` of type `integer` to the boolean `true`. If you are specifically checking for non-zero, consider using something more explicit like `> 0` or `!== 0` instead. Loading history...
47		}), null, [
48		'PGHOST' => 'localhost',
49		'PGUSER' => 'testUser',
50		'PGPASSWORD' => 'password',
51		'PGPORT' => '5432'
52		])
53		->once()
54		->andReturn(true);
55
56		$this->assertTrue(
57		$this->database->dump('testfile.sql')
58		);
59		}
60		}

spatie / laravel-backup

Push — master ( 410526...963b63 )

PgSQLDatabaseTest::testDump() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like