ScalarTypeHintsRemover::leaveNode() - Code Metrics - spatie/7to5 - Measure and Improve Code Quality continuously with Scrutinizer

ScalarTypeHintsRemover::leaveNode() A
last analyzed 2018-10-24 11:34 UTC

↳ Parent: ScalarTypeHintsRemover

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.3222
c	0
b	0
f	0
cc	5
nc	7
nop	1

<?php

namespace Spatie\Php7to5\NodeVisitors;

use PhpParser\Node;
use PhpParser\Node\Param;
use PhpParser\NodeVisitorAbstract;

class ScalarTypeHintsRemover extends NodeVisitorAbstract
{
    /**
     * {@inheritdoc}
     */
    public function leaveNode(Node $node)
    {
        if (!$node instanceof Param) {
            return;
        }

        if ($node->type instanceof Node\NullableType) {
            $node->type = $node->type->type;
            if (!$node->default) {
                $node->default = new Node\Expr\ConstFetch(
                    new Node\Name('null')
                );
            }
        }

        if ($this->isScalar($node->type)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $node->type = null;
        }
    }

    /**
     * @param string|null $type
     *
     * @return bool
     */
    protected function isScalar($type)
    {
        return in_array($type, ['int', 'integer', 'float', 'string', 'bool', 'boolean']);
    }
}


1			<?php
2
3			namespace Spatie\Php7to5\NodeVisitors;
4
5			use PhpParser\Node;
6			use PhpParser\Node\Param;
7			use PhpParser\NodeVisitorAbstract;
8
9			class ScalarTypeHintsRemover extends NodeVisitorAbstract
10			{
11			/**
12			* {@inheritdoc}
13			*/
14			public function leaveNode(Node $node)
15			{
16			if (!$node instanceof Param) {
17			return;
18			}
19
20			if ($node->type instanceof Node\NullableType) {
21			$node->type = $node->type->type;
22			if (!$node->default) {
23			$node->default = new Node\Expr\ConstFetch(
24			new Node\Name('null')
25			);
26			}
27			}
28
29			if ($this->isScalar($node->type)) {
			0 ignored issues – show Bug introduced 2016-02-20 00:17 UTC by Report Bug Copy Issue Report It seems like `$node->type` can also be of type `object<PhpParser\Node\Name>`; however, `Spatie\Php7to5\NodeVisit...intsRemover::isScalar()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
30			$node->type = null;
31			}
32			}
33
34			/**
35			* @param string\|null $type
36			*
37			* @return bool
38			*/
39			protected function isScalar($type)
40			{
41			return in_array($type, ['int', 'integer', 'float', 'string', 'bool', 'boolean']);
42			}
43			}
44

spatie / 7to5

ScalarTypeHintsRemover::leaveNode() A last analyzed 2018-10-24 11:34 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ScalarTypeHintsRemover::leaveNode() A
last analyzed 2018-10-24 11:34 UTC