Spatie\Php7to5\NodeVisitors\ScalarTypeHintsRemover

Complexity

Total Complexity

6

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	leaveNode()	0	19	5
A	isScalar()	0	4	1

<?php

namespace Spatie\Php7to5\NodeVisitors;

use PhpParser\Node;
use PhpParser\Node\Param;
use PhpParser\NodeVisitorAbstract;

class ScalarTypeHintsRemover extends NodeVisitorAbstract
{
    /**
     * {@inheritdoc}
     */
    public function leaveNode(Node $node)
    {
        if (!$node instanceof Param) {
            return;
        }

        if ($node->type instanceof Node\NullableType) {
            $node->type = $node->type->type;
            if (!$node->default) {
                $node->default = new Node\Expr\ConstFetch(
                    new Node\Name('null')
                );
            }
        }

        if ($this->isScalar($node->type)) {

It seems like $node->type can also be of type object<PhpParser\Node\Name>; however, Spatie\Php7to5\NodeVisitors\ScalarTypeHintsRemover::isScalar() does only seem to accept string|null, maybe add an additional type check?

            $node->type = null;
        }
    }

    /**
     * @param string|null $type
     *
     * @return bool
     */
    protected function isScalar($type)
    {
        return in_array($type, ['int', 'integer', 'float', 'string', 'bool', 'boolean']);
    }
}