spaghettisolutions / xlsx-parser

src/XLSXParser/AbstractXMLResource.php

<?php declare(strict_types = 1);

namespace Spaghetti\XLSXParser;

use Spaghetti\XLSXParser\Exception\InvalidXLSXFileException;
use Throwable;
use XMLReader;

/**
 * @internal
 */
abstract class AbstractXMLResource
{
    private ?XMLReader $xml = null;

    public function __construct(private readonly string $path)
    {
    }

    public function __destruct()
    {
        $this->closeXMLReader();
    }

    protected function getXMLReader(): XMLReader
    {
        return $this->xml ??= $this->createXMLReader();
    }

    protected function createXMLReader(): XMLReader
    {
        return $this->validateXMLReader(xml: new XMLReader());
    }

    protected function closeXMLReader(): void
    {
        $this->xml?->close();
        $this->xml = null;
    }

    private function validateXMLReader(XMLReader $xml): XMLReader
    {
        try {
            @$xml->open(uri: $this->path);

It seems like you do not handle an error condition for open(). This can introduce security issues, and is generally not recommended.

            $xml->read();
        } catch (Throwable $throwable) {
            throw new InvalidXLSXFileException(path: $this->path, previous: $throwable);
        }

        return $xml;
    }
}