Spaghetti\XLSXParser\AbstractXMLResource

Complexity

Total Complexity

7

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes	1
Bugs	1	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getXMLReader()	0	3	1
A	closeXMLReader()	0	4	1
A	createXMLReader()	0	3	1
A	__construct()	0	2	1
A	__destruct()	0	3	1
A	validateXMLReader()	0	10	2

<?php declare(strict_types = 1);

namespace Spaghetti\XLSXParser;

use Spaghetti\XLSXParser\Exception\InvalidXLSXFileException;
use Throwable;
use XMLReader;

/**
 * @internal
 */
abstract class AbstractXMLResource
{
    private ?XMLReader $xml = null;

    public function __construct(private readonly string $path)
    {
    }

    public function __destruct()
    {
        $this->closeXMLReader();
    }

    protected function getXMLReader(): XMLReader
    {
        return $this->xml ??= $this->createXMLReader();
    }

    protected function createXMLReader(): XMLReader
    {
        return $this->validateXMLReader(xml: new XMLReader());
    }

    protected function closeXMLReader(): void
    {
        $this->xml?->close();
        $this->xml = null;
    }

    private function validateXMLReader(XMLReader $xml): XMLReader
    {
        try {
            @$xml->open(uri: $this->path);

It seems like you do not handle an error condition for open(). This can introduce security issues, and is generally not recommended.

            $xml->read();
        } catch (Throwable $throwable) {
            throw new InvalidXLSXFileException(path: $this->path, previous: $throwable);
        }

        return $xml;
    }
}