spaark / composite-utils

src/Factory/Reflection/ReflectionCompositeFactory.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 
 namespace Spaark\CompositeUtils\Factory\Reflection;
 
-use Spaark\CompositeUtils\Factory\BaseFactory;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
-use Spaark\CompositeUtils\Service\PropertyAccessor;
 use \ReflectionClass as PHPNativeReflectionClass;
 
 class ReflectionCompositeFactory extends ReflectorFactory

Spacing +3 added lines, -6 removed lines

@@ -39,12 +39,10 @@ 
 
     protected function buildProperty($reflect)
     {
-        $this->accessor->rawAddToValue
-        (
+        $this->accessor->rawAddToValue(
             'properties',
             (new ReflectionPropertyFactory($reflect))
-                ->build
-                (
+                ->build(
                     $this->object,
                     $this->reflector
                         ->getDefaultProperties()[$reflect->getName()]
@@ -54,8 +52,7 @@ 
 
     protected function buildMethod($reflect)
     {
-        $this->accessor->rawAddToValue
-        (
+        $this->accessor->rawAddToValue(
             'methods',
             (new ReflectionMethodFactory($reflect))
                 ->build($this->object)

src/Factory/Reflection/ReflectionPropertyFactory.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
-use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
 use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
 use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;

Spacing +2 added lines, -4 removed lines

@@ -26,8 +26,7 @@ 
 
     public static function fromName($class, $property)
     {
-        return new static(new PHPNativeReflectionProperty
-        (
+        return new static(new PHPNativeReflectionProperty(
             $class, $property
         ));
     }
@@ -36,8 +35,7 @@ 
     {
         $this->accessor->setRawValue('owner', $parent);
         $this->accessor->setRawValue('defaultValue', $default);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );

Braces +2 added lines, -4 removed lines

@@ -52,8 +52,7 @@ 
         if ($value{0} !== '?')
         {
             $nullable = false;
-        }
-        else
+        } else
         {
             $nullable = true;
             $value = substr($value, 1);
@@ -62,8 +61,7 @@ 
         if (substr($value, -2) !== '[]')
         {
             $collection = false;
-        }
-        else
+        } else
         {
             $collection = true;
             $value = substr($value, 0, -2);

src/Service/PropertyAccessor.php

Doc Comments +1 added lines, -2 removed lines

@@ -29,7 +29,6 @@ 
 
     /**
      * @param object $object The object to access
-     * @param ReflectionModel|null $reflect A reflection entity
      */
     public function __construct($object)
     {
@@ -80,7 +79,7 @@ 
      * Adds a value to a property, irrespective of access permissions
      *
      * @param string $key The property to write to
-     * @param mixed $value The value to add
+     * @param \Spaark\CompositeUtils\Model\Reflection\Reflector $value The value to add
      * @throws CannotWritePropertyException In the event the property
      *    does not exist
      */ 

Spacing +4 added lines, -8 removed lines

@@ -48,8 +48,7 @@ 
      */
     public function setRawValue($key, $value)
     {
-        $this->getPropertyOrFail
-        (
+        $this->getPropertyOrFail(
             $key,
             CannotWritePropertyException::class
         )
@@ -68,8 +67,7 @@ 
     public function getRawValue($key)
     {
         return
-            $this->getPropertyOrFail
-            (
+            $this->getPropertyOrFail(
                 $key,
                 CannotReadPropertyException::class
             )
@@ -86,8 +84,7 @@ 
      */ 
     public function rawAddToValue($key, $value)
     {
-        $property = $this->getPropertyOrFail
-        (
+        $property = $this->getPropertyOrFail(
             $key,
             CannotWritePropertyException::class
         );
@@ -113,8 +110,7 @@ 
         }
         catch (ReflectionException $e)
         {
-            throw new $class
-            (
+            throw new $class(
                 get_class($this->object),
                 $key,
                 $e

Braces +1 added lines, -2 removed lines

@@ -110,8 +110,7 @@
             $prop->setAccessible(true);
 
             return $prop;
-        }
-        catch (ReflectionException $e)
+        } catch (ReflectionException $e)
         {
             throw new $class
             (

src/Factory/Reflection/ReflectorFactory.php

Indentation +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     {
         preg_match_all
         (
-              '/^'
+                '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
             .     '(.*)'

Spacing +3 added lines, -5 removed lines

@@ -37,8 +37,7 @@ 
 
     protected function parseDocComment()
     {
-        preg_match_all
-        (
+        preg_match_all(
               '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
@@ -55,8 +54,7 @@ 
 
             if (isset($this->acceptedParams[$name]))
             {
-                call_user_func
-                (
+                call_user_func(
                     array($this, $this->acceptedParams[$name]),
                     $name, $value
                 );
@@ -66,7 +64,7 @@ 
 
     protected function setBool($name, $value)
     {
-        switch(strtolower($value))
+        switch (strtolower($value))
         {
             case '':
             case 'true':

src/Factory/Reflection/ReflectionMethodFactory.php

Spacing +3 added lines, -5 removed lines

@@ -13,17 +13,15 @@
 
     public static function fromName($class, $method)
     {
-        return new static(new PHPNativeReflectionMethod
-        (
+        return new static(new PHPNativeReflectionMethod(
             $class, $method
         ));
     }
 
-    public function build(?ReflectionComposite $parent = null)
+    public function build(? ReflectionComposite $parent = null)
     {
         $this->accessor->setRawValue('owner', $parent);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );

src/Model/Reflection/Reflector.php

Braces +1 added lines, -2 removed lines

@@ -23,8 +23,7 @@
         if ($this->locked)
         {
             return parent::__set($var, $val);
-        }
-        else
+        } else
         {
             $this->$var = $val;
         }

src/Model/Collection/Set.php

Indentation +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     private function getScalar($value)
     {
         return
-              (is_object($value) ? spl_object_hash($value)
+                (is_object($value) ? spl_object_hash($value)
             : (is_array($value)  ? implode($value)
             : (                    (string)$value)));
     }

Spacing +2 added lines, -2 removed lines

@@ -28,8 +28,8 @@
     {
         return
               (is_object($value) ? spl_object_hash($value)
-            : (is_array($value)  ? implode($value)
-            : (                    (string)$value)));
+            : (is_array($value) ? implode($value)
+            : ((string)$value)));
     }
 
     /**

src/Model/Collection/Stack.php

Braces +3 added lines, -1 removed lines

@@ -43,7 +43,9 @@
      */
     public function popMultiple($i = 1)
     {
-        if ($i < 1) return NULL;
+        if ($i < 1) {
+            return NULL;
+        }
 
         $ret = array_slice($this->data, -1 * $i);
         $this->data = array_slice($this->data, 0, -1 * $i);

src/Model/Collection/HashMap.php

Spacing +2 added lines, -2 removed lines

@@ -24,8 +24,8 @@
     {
         return
               (is_object($value) ? spl_object_hash($value)
-            : (is_array($value)  ? implode($value)
-            : (                    (string)$value)));
+            : (is_array($value) ? implode($value)
+            : ((string)$value)));
     }
 
     public function add($value)

Indentation +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
     private function getScalar($value)
     {
         return
-              (is_object($value) ? spl_object_hash($value)
+                (is_object($value) ? spl_object_hash($value)
             : (is_array($value)  ? implode($value)
             : (                    (string)$value)));
     }