spaark / composite-utils

src/Factory/Reflection/ReflectionPropertyFactory.php

Unused Use Statements -7 removed lines

@@ -16,13 +16,6 @@
 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
-use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
-use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
-use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
-use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
-use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
 use Spaark\CompositeUtils\Service\RawPropertyAccessor;
 use \ReflectionProperty as PHPNativeReflectionProperty;
 

Spacing +12 added lines, -24 removed lines

@@ -53,8 +53,7 @@ 
      */
     public static function fromName($class, $property)
     {
-        return new static(new PHPNativeReflectionProperty
-        (
+        return new static(new PHPNativeReflectionProperty(
             $class, $property
         ));
     }
@@ -72,14 +71,12 @@ 
     {
         $this->accessor->setRawValue('owner', $parent);
         $this->accessor->setRawValue('defaultValue', $default);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );
 
-        $this->parseDocComment
-        ([
+        $this->parseDocComment([
             'readable' => 'setBool',
             'writable' => 'setBool',
             'var' => 'setType',
@@ -97,8 +94,7 @@ 
      */
     protected function setType($name, $value)
     {
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'type',
             (new TypeParser($this->object->owner))->parse($value)
         );
@@ -120,50 +116,42 @@ 
         switch ($value[0])
         {
             case 'required':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'requiredInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'requiredProperties',
                     $this->object
                 );
                 break;
             case 'new':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'builtInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'builtProperties',
                     $this->object
                 );
                 break;
             case 'optional':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'optionalProperties',
                     $this->object
                 );
 
                 if (isset($value[1]) && $value[1] === 'new')
                 {
-                    $this->accessor->setRawValue
-                    (
+                    $this->accessor->setRawValue(
                         'builtInConstructor',
                         true
                     );

src/Factory/Reflection/ReflectorFactory.php

Spacing +3 added lines, -5 removed lines

@@ -63,8 +63,7 @@ 
      */
     protected function parseDocComment(array $acceptedParams)
     {
-        preg_match_all
-        (
+        preg_match_all(
               '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
@@ -81,8 +80,7 @@ 
 
             if (isset($acceptedParams[$name]))
             {
-                call_user_func
-                (
+                call_user_func(
                     array($this, $acceptedParams[$name]),
                     $name, $value
                 );
@@ -98,7 +96,7 @@ 
      */
     protected function setBool($name, $value)
     {
-        switch(strtolower($value))
+        switch (strtolower($value))
         {
             case '':
             case 'true':

src/Service/GenericNameProvider.php

Unused Use Statements -3 removed lines

@@ -20,10 +20,7 @@
 use Spaark\CompositeUtils\Model\Reflection\Type\FloatType;
 use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
 use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
 use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
-use Spaark\CompositeUtils\Exception\PropertyNotWritableException;
-use Spaark\CompositeUtils\Exception\PropertyNotReadableException;
 
 /**
  * Used to retrieve the classname for an AbstractType

Braces +1 added lines, -2 removed lines

@@ -68,8 +68,7 @@
         if ($reflect->generics->empty())
         {
             return $reflect->classname;
-        }
-        else
+        } else
         {
             $items = [];
             foreach ($reflect->generics as $generic)

src/Factory/Reflection/ReflectionCompositeFactory.php

Spacing +10 added lines, -20 removed lines

@@ -78,8 +78,7 @@ 
      * @param PHPNativeReflectionClass $reflect
      * @param ReflectionCompositeProviderInterface $provider
      */
-    public function __construct
-    (
+    public function __construct(
         PHPNativeReflectionClass $reflect,
         ReflectionCompositeProviderInterface $provider
     )
@@ -112,8 +111,7 @@ 
             $this->addInheritance('interfaces', $interface);
         }
 
-        $this->parseDocComment
-        ([
+        $this->parseDocComment([
             'generic' => 'addGeneric'
         ]);
 
@@ -122,13 +120,11 @@ 
         $file = (new ReflectionFileFactory($fileName))->build();
         $this->accessor->setRawValue('file', $file);
 
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'classname',
             $this->reflector->name
         );
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'namespace',
             $file->namespaces[$this->reflector->getNamespaceName()]
         );
@@ -151,8 +147,7 @@ 
             $size = count($this->reflector->{'get' . $name}());
             foreach ($prefixes as $prefix)
             {
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     $prefix . $name,
                     new FixedList($size)
                 );
@@ -207,8 +202,7 @@ 
      * @param bool $checkFile
      * @param string $singular
      */
-    protected function addItems
-    (
+    protected function addItems(
         string $name,
         bool $checkFile,
         string $signular
@@ -239,8 +233,7 @@ 
                     new $factory($item),
                     $item
                 );
-                $this->accessor->rawAddToValue
-                (
+                $this->accessor->rawAddToValue(
                     'local' . ucfirst($name),
                     $item
                 );
@@ -257,8 +250,7 @@ 
      * @param PHPNativeReflectionClass $reflect
      * @param string $method
      */
-    protected function addInheritance
-    (
+    protected function addInheritance(
         string $group,
         PHPNativeReflectionClass $reflect,
         string $method = 'rawAddToValue'
@@ -283,15 +275,13 @@ 
      * @param ReflectionPropertyFactory $factory
      * @return ReflectionProperty
      */
-    protected function buildProperty
-    (
+    protected function buildProperty(
         ReflectionPropertyFactory $factory,
         PHPNativeReflectionProperty $reflect
     )
     : ReflectionProperty
     {
-        return $factory->build
-        (
+        return $factory->build(
             $this->object,
             $this->reflector
                 ->getDefaultProperties()[$reflect->getName()]

Braces +1 added lines, -2 removed lines

@@ -174,8 +174,7 @@
         {
             $key = $value;
             $type = '';
-        }
-        else
+        } else
         {
             $key = substr($value, 0, $space);
             $type = substr($value, $space);

src/Factory/Reflection/TypeParser.php

Spacing +2 added lines, -2 removed lines

@@ -100,7 +100,7 @@ 
                     $item = $stack->pop();
                     if ($value{$i - 1} !== '>')
                     {
-                        $item->generics[] =$this->resolveName();
+                        $item->generics[] = $this->resolveName();
                     }
 
                     if ($i + 1 !== strlen($value) && $value{$i + 1} === '[')
@@ -148,7 +148,7 @@ 
         }
         elseif ($i + 2 !== strlen($value))
         {
-            if (!in_array($value{$i + 2}, ['>',',']))
+            if (!in_array($value{$i + 2}, ['>', ',']))
             {
                 throw new \Exception('Unexpected char after collection');
             }

Braces +5 added lines, -10 removed lines

@@ -113,8 +113,7 @@ 
                     if ($stack->isEmpty())
                     {
                         return $item;
-                    }
-                    else
+                    } else
                     {
                         $stack->top()->generics[] = $item;
                     }
@@ -141,12 +140,10 @@ 
         if ($i + 1 === strlen($value))
         {
             throw new \Exception('Unexpected EOF');
-        }
-        elseif ($value{$i + 1} !== ']')
+        } elseif ($value{$i + 1} !== ']')
         {
             throw new \Exception('[ must be followed by ]');
-        }
-        elseif ($i + 2 !== strlen($value))
+        } elseif ($i + 2 !== strlen($value))
         {
             if (!in_array($value{$i + 2}, ['>',',']))
             {
@@ -245,12 +242,10 @@ 
         if ($useStatements->containsKey($this->currentValue))
         {
             return $useStatements[$this->currentValue]->classname;
-        }
-        elseif ($generics->containsKey($this->currentValue))
+        } elseif ($generics->containsKey($this->currentValue))
         {
             return new GenericType($this->currentValue);
-        }
-        else
+        } else
         {
             return $this->context->namespace->namespace
                 . '\\' . $this->currentValue;

src/Service/TypeComparator.php

Spacing +1 added lines, -2 removed lines

@@ -31,8 +31,7 @@
      * @param AbstractType $child
      * @return boolean
      */
-    public function compatible
-    (
+    public function compatible(
         AbstractType $parent,
         AbstractType $child
     )

Braces +2 added lines, -4 removed lines

@@ -41,12 +41,10 @@
         if ($parent instanceof MixedType)
         {
             return true;
-        }
-        elseif ($parent instanceof ScalarType)
+        } elseif ($parent instanceof ScalarType)
         {
             return get_class($parent) === get_class($child);
-        }
-        elseif ($parent instanceof ObjectType)
+        } elseif ($parent instanceof ObjectType)
         {
             return
                 $child instanceof ObjectType && 

src/Factory/Reflection/ReflectionMethodFactory.php

Indentation +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
         $this->initParams();
 
         $this->accessor->setRawValue('visibility',
-              ($this->reflector->isPublic() ? 'public'
+                ($this->reflector->isPublic() ? 'public'
             : ($this->reflector->isProtected() ? 'protected'
             : ($this->reflector->isPrivate() ? 'private'
             : (''))))

Spacing +6 added lines, -11 removed lines

@@ -63,8 +63,7 @@ 
      */
     public static function fromName(string $class, string $method)
     {
-        return new static(new PHPNativeReflectionMethod
-        (
+        return new static(new PHPNativeReflectionMethod(
             $class, $method
         ));
     }
@@ -84,12 +83,11 @@ 
      *     this method belongs to
      * @return ReflectionMethod
      */
-    public function build(?ReflectionComposite $parent = null)
+    public function build(? ReflectionComposite $parent = null)
     {
         $this->typeParser = new TypeParser($parent);
         $this->accessor->setRawValue('owner', $parent);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );
@@ -125,13 +123,11 @@ 
      */
     protected function initParams()
     {
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'parameters',
             new FixedList(count($this->reflector->getParameters()))
         );
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'nativeParameters',
             new FixedList(count($this->reflector->getParameters()))
         );
@@ -174,8 +170,7 @@ 
      *
      * @param PHPNativeReflectionParameter $reflect
      */
-    protected function addParameter
-    (
+    protected function addParameter(
         PHPNativeReflectionParameter $reflect
     )
     : void

src/Model/Collection/OrderedMap.php

Spacing +1 added lines, -2 removed lines

@@ -44,8 +44,7 @@
     {
         if (!$pair instanceof OrderedPair)
         {
-            $pair = new OrderedPair
-            (
+            $pair = new OrderedPair(
                 $this->size(),
                 $pair->key,
                 $pair->value

Doc Comments +4 added lines, -3 removed lines

@@ -37,8 +37,6 @@ 
     /**
      * Adds an element to the Map
      *
-     * @param KeyType $key The key to add
-     * @param ValueType $value The value to add
      */
     public function insert(Pair $pair)
     {
@@ -59,7 +57,7 @@ 
     /**
      * Checks if a key exists
      *
-     * @param KeyType $key The key to search for
+     * @param string $key The key to search for
      * @return boolean
      */
     public function containsKey($key) : bool
@@ -103,6 +101,9 @@ 
         return $this->list->size();
     }
 
+    /**
+     * @param string $key
+     */
     public function indexOfKey($key)
     {
         return $this->getPair($key)->index;

src/Traits/HasReflectorTrait.php

Spacing +2 added lines, -4 removed lines

@@ -41,8 +41,7 @@ 
         if (!static::$reflectionComposite)
         {
             static::$reflectionComposite =
-                ReflectionCompositeFactory::fromClassName
-                (
+                ReflectionCompositeFactory::fromClassName(
                     get_called_class()
                 )
                 ->build();
@@ -54,8 +53,7 @@ 
     /**
      * Set the default ReflectionComposite for this class
      */
-    protected static function setDefaultReflectionComposite
-    (
+    protected static function setDefaultReflectionComposite(
         ReflectionComposite $defaultReflectionComposite
     )
     {