spaark / composite-utils

src/Factory/Reflection/ReflectionPropertyFactory.php

Unused Use Statements -7 removed lines

@@ -16,13 +16,6 @@
 
 use Spaark\CompositeUtils\Model\Reflection\ReflectionComposite;
 use Spaark\CompositeUtils\Model\Reflection\ReflectionProperty;
-use Spaark\CompositeUtils\Model\Reflection\ReflectionParameter;
-use Spaark\CompositeUtils\Model\Reflection\Type\BooleanType;
-use Spaark\CompositeUtils\Model\Reflection\Type\CollectionType;
-use Spaark\CompositeUtils\Model\Reflection\Type\IntegerType;
-use Spaark\CompositeUtils\Model\Reflection\Type\MixedType;
-use Spaark\CompositeUtils\Model\Reflection\Type\ObjectType;
-use Spaark\CompositeUtils\Model\Reflection\Type\StringType;
 use Spaark\CompositeUtils\Service\RawPropertyAccessor;
 use \ReflectionProperty as PHPNativeReflectionProperty;
 

Spacing +12 added lines, -24 removed lines

@@ -53,8 +53,7 @@ 
      */
     public static function fromName($class, $property)
     {
-        return new static(new PHPNativeReflectionProperty
-        (
+        return new static(new PHPNativeReflectionProperty(
             $class, $property
         ));
     }
@@ -72,14 +71,12 @@ 
     {
         $this->accessor->setRawValue('owner', $parent);
         $this->accessor->setRawValue('defaultValue', $default);
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'name',
             $this->reflector->getName()
         );
 
-        $this->parseDocComment
-        ([
+        $this->parseDocComment([
             'readable' => 'setBool',
             'writable' => 'setBool',
             'var' => 'setType',
@@ -97,8 +94,7 @@ 
      */
     protected function setType($name, $value)
     {
-        $this->accessor->setRawValue
-        (
+        $this->accessor->setRawValue(
             'type',
             (new TypeParser($this->object->owner))->parse($value)
         );
@@ -120,50 +116,42 @@ 
         switch ($value[0])
         {
             case 'required':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'requiredInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'requiredProperties',
                     $this->object
                 );
                 break;
             case 'new':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'builtInConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'builtProperties',
                     $this->object
                 );
                 break;
             case 'optional':
-                $this->accessor->setRawValue
-                (
+                $this->accessor->setRawValue(
                     'passedToConstructor',
                     true
                 );
-                $compositeAccessor->rawAddToValue
-                (
+                $compositeAccessor->rawAddToValue(
                     'optionalProperties',
                     $this->object
                 );
 
                 if (isset($value[1]) && $value[1] === 'new')
                 {
-                    $this->accessor->setRawValue
-                    (
+                    $this->accessor->setRawValue(
                         'builtInConstructor',
                         true
                     );

src/Factory/Reflection/TypeParser.php

Doc Comments +6 added lines

@@ -47,6 +47,9 @@ 
         return $this->innerParse($value);
     }
 
+    /**
+     * @param string $value
+     */
     protected function innerParse($value)
     {
         $nullable = false;
@@ -120,6 +123,9 @@ 
         return $this->resolveName($current, $nullable, $collection);
     }
 
+    /**
+     * @param integer $i
+     */
     protected function checkCollectionClose($value, $i)
     {
         if ($i + 1 === strlen($value))

Spacing +12 added lines, -17 removed lines

@@ -63,8 +63,7 @@ 
                     $nullable = true;
                     break;
                 case '<':
-                    $stack->push($this->resolveGenericName
-                    (
+                    $stack->push($this->resolveGenericName(
                         $current,
                         $nullable,
                         $collection
@@ -72,8 +71,7 @@ 
                     break;
                 case ',':
                     $stack->top()->generics[] =
-                        $this->resolveName
-                        (
+                        $this->resolveName(
                             $current,
                             $nullable,
                             $collection
@@ -89,8 +87,7 @@ 
                 case '>':
                     $item = $stack->pop();
                     $item->generics[] =
-                        $this->resolveName
-                        (
+                        $this->resolveName(
                             $current,
                             $nullable,
                             $collection
@@ -132,18 +129,17 @@ 
         }
         elseif ($i + 2 !== strlen($value))
         {
-            if (!in_array($value{$i + 2}, ['>',',']))
+            if (!in_array($value{$i + 2}, ['>', ',']))
             {
                 throw new \Exception('Unexpected char after collection');
             }
         }
     }
 
-    protected function resolveGenericName
-    (
-        string &$value,
-        bool &$nullable,
-        bool &$collection
+    protected function resolveGenericName(
+        string & $value,
+        bool & $nullable,
+        bool & $collection
     )
     {
         $type = $this->resolveName($value, $nullable, $collection);
@@ -156,11 +152,10 @@ 
         return $type;
     }
 
-    protected function resolveName
-    (
-        string &$value,
-        bool &$nullable,
-        bool &$collection
+    protected function resolveName(
+        string & $value,
+        bool & $nullable,
+        bool & $collection
     )
     {
         switch ($value)

Braces +4 added lines, -8 removed lines

@@ -106,8 +106,7 @@ 
                     if ($stack->isEmpty())
                     {
                         return $item;
-                    }
-                    else
+                    } else
                     {
                         $stack->top()->types[] = $item;
                     }
@@ -125,12 +124,10 @@ 
         if ($i + 1 === strlen($value))
         {
             throw new \Exception('Unexpected EOF');
-        }
-        elseif ($value{$i + 1} !== ']')
+        } elseif ($value{$i + 1} !== ']')
         {
             throw new \Exception('[ must be followed by ]');
-        }
-        elseif ($i + 2 !== strlen($value))
+        } elseif ($i + 2 !== strlen($value))
         {
             if (!in_array($value{$i + 2}, ['>',',']))
             {
@@ -189,8 +186,7 @@ 
                     if ($useStatements->containsKey($value))
                     {
                         $value = $useStatements[$value]->classname;
-                    }
-                    else
+                    } else
                     {
                         $value = $this->context->namespace->namespace
                             . '\\' . $value;

src/Factory/Reflection/ReflectorFactory.php

Spacing +3 added lines, -5 removed lines

@@ -63,8 +63,7 @@ 
      */
     protected function parseDocComment(array $acceptedParams)
     {
-        preg_match_all
-        (
+        preg_match_all(
               '/^'
             .     '[ \t]*\*[ \t]*'
             .     '@([a-zA-Z]+)'
@@ -81,8 +80,7 @@ 
 
             if (isset($acceptedParams[$name]))
             {
-                call_user_func
-                (
+                call_user_func(
                     array($this, $acceptedParams[$name]),
                     $name, $value
                 );
@@ -98,7 +96,7 @@ 
      */
     protected function setBool($name, $value)
     {
-        switch(strtolower($value))
+        switch (strtolower($value))
         {
             case '':
             case 'true':