Issues in char.php (master) - Issues in master - sovereignbot/citadel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (81)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Plugins/onMessage/char.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Sovereign\Plugins\onMessage;

use Discord\Discord;
use Discord\Parts\Channel\Message;
use Monolog\Logger;
use Sovereign\Lib\Config;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Sovereign\Lib\cURL;
use Sovereign\Lib\Db;
use Sovereign\Lib\Permissions;
use Sovereign\Lib\ServerConfig;
use Sovereign\Lib\Settings;
use Sovereign\Lib\Users;

class char extends \Threaded implements \Collectable
{
    /**
     * @var Message
     */
    private $message;
    /**
     * @var Discord
     */
    private $discord;
    /**
     * @var Logger
     */
    private $log;
    /**
     * @var array
     */
    private $channelConfig;
    /**
     * @var Config
     */
    private $config;
    /**
     * @var Db
     */
    private $db;
    /**
     * @var cURL
     */
    private $curl;
    /**
     * @var Settings
     */
    private $settings;
    /**
     * @var Permissions
     */
    private $permissions;
    /**
     * @var ServerConfig
     */
    private $serverConfig;
    /**
     * @var Users
     */
    private $users;
    /**
     * @var array
     */
    private $extras;

    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)

    {
        $this->message = $message;
        $this->discord = $discord;
        $this->channelConfig = $channelConfig;
        $this->log = $log;
        $this->config = $config;
        $this->db = $db;
        $this->curl = $curl;
        $this->settings = $settings;
        $this->permissions = $permissions;
        $this->serverConfig = $serverConfig;
        $this->users = $users;
        $this->extras = $extras;
    }

    public function run()
    {
        // Most EVE players on Discord use their ingame name, so lets support @highlights
        $explode = explode(" ", $this->message->content);
        unset($explode[0]);
        $name = implode(" ", $explode);
        $name = stristr($name, "@") ? str_replace("<@", "", str_replace(">", "", $name)) : $name;

        if (is_numeric($name)) {
            // The person used @highlighting, so now we got a discord id, lets map that to a name
            $name = $this->db->queryField("SELECT nickName FROM users WHERE discordID = :id", "nickName", array(":id" => $name));
        }

        $url = "https://evedata.xyz/api/search/character/" . urlencode($name) . "/";
        $data = @json_decode($this->curl->get($url), true)["character"];
        if (empty($data)) {
            return $this->message->reply("**Error:** no results was returned.");
        }

        $exists = false;
        if (count($data) > 1) {
            $results = array();
            foreach ($data as $char) {
                if (strtolower($char["characterName"]) == strtolower($name)) {
                    $data[0]["characterID"] = $char["characterID"];
                    $exists = true;
                }
                $results[] = $char["characterName"];
            }
            if ($exists == false) {

                return $this->message->reply("**Error:** more than one result was returned: " . implode(", ", $results));
            }
        }

        // Get stats
        $characterID = $data[0]["characterID"];
        $statsURL = "https://beta.eve-kill.net/api/charInfo/characterID/" . urlencode($characterID) . "/";
        $stats = json_decode($this->curl->get($statsURL), true);
        if (empty($stats)) {
            return $this->message->reply("**Error:** no data available");
        }

        $characterName = @$stats["characterName"];
        $corporationName = @$stats["corporationName"];
        $allianceName = isset($stats["allianceName"]) ? $stats["allianceName"] : "None";
        $factionName = isset($stats["factionName"]) ? $stats["factionName"] : "None";
        $securityStatus = @$stats["securityStatus"];
        $lastSeenSystem = @$stats["lastSeenSystem"];
        $lastSeenRegion = @$stats["lastSeenRegion"];
        $lastSeenShip = @$stats["lastSeenShip"];
        $lastSeenDate = @$stats["lastSeenDate"];
        $corporationActiveArea = @$stats["corporationActiveArea"];
        $allianceActiveArea = @$stats["allianceActiveArea"];
        $soloKills = @$stats["soloKills"];
        $blobKills = @$stats["blobKills"];
        $lifeTimeKills = @$stats["lifeTimeKills"];
        $lifeTimeLosses = @$stats["lifeTimeLosses"];
        $amountOfSoloPVPer = @$stats["percentageSoloPVPer"];
        $ePeenSize = @$stats["ePeenSize"];
        $facepalms = @$stats["facepalms"];
        $lastUpdated = @$stats["lastUpdatedOnBackend"];
        $url = "https://beta.eve-kill.net/character/" . $stats["characterID"] . "/";
        $msg = "```characterName: {$characterName}
corporationName: {$corporationName}
allianceName: {$allianceName}
factionName: {$factionName}
securityStatus: {$securityStatus}
lastSeenSystem: {$lastSeenSystem}
lastSeenRegion: {$lastSeenRegion}
lastSeenShip: {$lastSeenShip}
lastSeenDate: {$lastSeenDate}
corporationActiveArea: {$corporationActiveArea}
allianceActiveArea: {$allianceActiveArea}
soloKills: {$soloKills}
blobKills: {$blobKills}
lifeTimeKills: {$lifeTimeKills}
lifeTimeLosses: {$lifeTimeLosses}
percentageSoloPVPer: {$amountOfSoloPVPer}
ePeenSize: {$ePeenSize}
facepalms: {$facepalms}
lastUpdated: $lastUpdated```
For more info, visit: $url";
        $this->message->reply($msg);

        // Mark this as garbage
        $this->isGarbage();
    }
}

1		<?php
2
3		namespace Sovereign\Plugins\onMessage;
4
5		use Discord\Discord;
6		use Discord\Parts\Channel\Message;
7		use Monolog\Logger;
8		use Sovereign\Lib\Config;
		0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Sovereign\Plugins\onMessage\Config`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
9		use Sovereign\Lib\cURL;
10		use Sovereign\Lib\Db;
11		use Sovereign\Lib\Permissions;
12		use Sovereign\Lib\ServerConfig;
13		use Sovereign\Lib\Settings;
14		use Sovereign\Lib\Users;
15
16		class char extends \Threaded implements \Collectable
17		{
18		/**
19		* @var Message
20		*/
21		private $message;
22		/**
23		* @var Discord
24		*/
25		private $discord;
26		/**
27		* @var Logger
28		*/
29		private $log;
30		/**
31		* @var array
32		*/
33		private $channelConfig;
34		/**
35		* @var Config
36		*/
37		private $config;
38		/**
39		* @var Db
40		*/
41		private $db;
42		/**
43		* @var cURL
44		*/
45		private $curl;
46		/**
47		* @var Settings
48		*/
49		private $settings;
50		/**
51		* @var Permissions
52		*/
53		private $permissions;
54		/**
55		* @var ServerConfig
56		*/
57		private $serverConfig;
58		/**
59		* @var Users
60		*/
61		private $users;
62		/**
63		* @var array
64		*/
65		private $extras;
66
67	View Code Duplication	public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
		0 ignored issues – show Duplication introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		$this->message = $message;
70		$this->discord = $discord;
71		$this->channelConfig = $channelConfig;
72		$this->log = $log;
73		$this->config = $config;
74		$this->db = $db;
75		$this->curl = $curl;
76		$this->settings = $settings;
77		$this->permissions = $permissions;
78		$this->serverConfig = $serverConfig;
79		$this->users = $users;
80		$this->extras = $extras;
81		}
82
83		public function run()
84		{
85		// Most EVE players on Discord use their ingame name, so lets support @highlights
86		$explode = explode(" ", $this->message->content);
87		unset($explode[0]);
88		$name = implode(" ", $explode);
89		$name = stristr($name, "@") ? str_replace("<@", "", str_replace(">", "", $name)) : $name;
90
91		if (is_numeric($name)) {
92		// The person used @highlighting, so now we got a discord id, lets map that to a name
93		$name = $this->db->queryField("SELECT nickName FROM users WHERE discordID = :id", "nickName", array(":id" => $name));
94		}
95
96		$url = "https://evedata.xyz/api/search/character/" . urlencode($name) . "/";
97		$data = @json_decode($this->curl->get($url), true)["character"];
98		if (empty($data)) {
99		return $this->message->reply("Error: no results was returned.");
100		}
101
102		$exists = false;
103		if (count($data) > 1) {
104		$results = array();
105		foreach ($data as $char) {
106		if (strtolower($char["characterName"]) == strtolower($name)) {
107		$data[0]["characterID"] = $char["characterID"];
108		$exists = true;
109		}
110		$results[] = $char["characterName"];
111		}
112		if ($exists == false) {
		0 ignored issues – show Coding Style Best Practice introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
113		return $this->message->reply("Error: more than one result was returned: " . implode(", ", $results));
114		}
115		}
116
117		// Get stats
118		$characterID = $data[0]["characterID"];
119		$statsURL = "https://beta.eve-kill.net/api/charInfo/characterID/" . urlencode($characterID) . "/";
120		$stats = json_decode($this->curl->get($statsURL), true);
121		if (empty($stats)) {
122		return $this->message->reply("Error: no data available");
123		}
124
125		$characterName = @$stats["characterName"];
126		$corporationName = @$stats["corporationName"];
127		$allianceName = isset($stats["allianceName"]) ? $stats["allianceName"] : "None";
128		$factionName = isset($stats["factionName"]) ? $stats["factionName"] : "None";
129		$securityStatus = @$stats["securityStatus"];
130		$lastSeenSystem = @$stats["lastSeenSystem"];
131		$lastSeenRegion = @$stats["lastSeenRegion"];
132		$lastSeenShip = @$stats["lastSeenShip"];
133		$lastSeenDate = @$stats["lastSeenDate"];
134		$corporationActiveArea = @$stats["corporationActiveArea"];
135		$allianceActiveArea = @$stats["allianceActiveArea"];
136		$soloKills = @$stats["soloKills"];
137		$blobKills = @$stats["blobKills"];
138		$lifeTimeKills = @$stats["lifeTimeKills"];
139		$lifeTimeLosses = @$stats["lifeTimeLosses"];
140		$amountOfSoloPVPer = @$stats["percentageSoloPVPer"];
141		$ePeenSize = @$stats["ePeenSize"];
142		$facepalms = @$stats["facepalms"];
143		$lastUpdated = @$stats["lastUpdatedOnBackend"];
144		$url = "https://beta.eve-kill.net/character/" . $stats["characterID"] . "/";
145		$msg = "```characterName: {$characterName}
146		corporationName: {$corporationName}
147		allianceName: {$allianceName}
148		factionName: {$factionName}
149		securityStatus: {$securityStatus}
150		lastSeenSystem: {$lastSeenSystem}
151		lastSeenRegion: {$lastSeenRegion}
152		lastSeenShip: {$lastSeenShip}
153		lastSeenDate: {$lastSeenDate}
154		corporationActiveArea: {$corporationActiveArea}
155		allianceActiveArea: {$allianceActiveArea}
156		soloKills: {$soloKills}
157		blobKills: {$blobKills}
158		lifeTimeKills: {$lifeTimeKills}
159		lifeTimeLosses: {$lifeTimeLosses}
160		percentageSoloPVPer: {$amountOfSoloPVPer}
161		ePeenSize: {$ePeenSize}
162		facepalms: {$facepalms}
163		lastUpdated: $lastUpdated```
164		For more info, visit: $url";
165		$this->message->reply($msg);
166
167		// Mark this as garbage
168		$this->isGarbage();
169		}
170		}

sovereignbot / citadel

Issues (81)

Security Analysis no request data

src/Plugins/onMessage/char.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like