char::__construct()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 15
Code Lines 13

Duplication

Lines 15
Ratio 100 %

Importance

Changes 3
Bugs 1 Features 0
Metric Value
cc 1
eloc 13
c 3
b 1
f 0
nc 1
nop 12
dl 15
loc 15
rs 9.4285

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace Sovereign\Plugins\onMessage;
4
5
use Discord\Discord;
6
use Discord\Parts\Channel\Message;
7
use Monolog\Logger;
8
use Sovereign\Lib\Config;
0 ignored issues
show
Bug introduced by
This use statement conflicts with another class in this namespace, Sovereign\Plugins\onMessage\Config.

Let’s assume that you have a directory layout like this:

.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

and let’s assume the following content of Bar.php:

// Bar.php
namespace OtherDir;

use SomeDir\Foo; // This now conflicts the class OtherDir\Foo

If both files OtherDir/Foo.php and SomeDir/Foo.php are loaded in the same runtime, you will see a PHP error such as the following:

PHP Fatal error:  Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php

However, as OtherDir/Foo.php does not necessarily have to be loaded and the error is only triggered if it is loaded before OtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias:

// Bar.php
namespace OtherDir;

use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore.
Loading history...
9
use Sovereign\Lib\cURL;
10
use Sovereign\Lib\Db;
11
use Sovereign\Lib\Permissions;
12
use Sovereign\Lib\ServerConfig;
13
use Sovereign\Lib\Settings;
14
use Sovereign\Lib\Users;
15
16
class char extends \Threaded implements \Collectable
17
{
18
    /**
19
     * @var Message
20
     */
21
    private $message;
22
    /**
23
     * @var Discord
24
     */
25
    private $discord;
26
    /**
27
     * @var Logger
28
     */
29
    private $log;
30
    /**
31
     * @var array
32
     */
33
    private $channelConfig;
34
    /**
35
     * @var Config
36
     */
37
    private $config;
38
    /**
39
     * @var Db
40
     */
41
    private $db;
42
    /**
43
     * @var cURL
44
     */
45
    private $curl;
46
    /**
47
     * @var Settings
48
     */
49
    private $settings;
50
    /**
51
     * @var Permissions
52
     */
53
    private $permissions;
54
    /**
55
     * @var ServerConfig
56
     */
57
    private $serverConfig;
58
    /**
59
     * @var Users
60
     */
61
    private $users;
62
    /**
63
     * @var array
64
     */
65
    private $extras;
66
67 View Code Duplication
    public function __construct($message, $discord, $channelConfig, $log, $config, $db, $curl, $settings, $permissions, $serverConfig, $users, $extras)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
68
    {
69
        $this->message = $message;
70
        $this->discord = $discord;
71
        $this->channelConfig = $channelConfig;
72
        $this->log = $log;
73
        $this->config = $config;
74
        $this->db = $db;
75
        $this->curl = $curl;
76
        $this->settings = $settings;
77
        $this->permissions = $permissions;
78
        $this->serverConfig = $serverConfig;
79
        $this->users = $users;
80
        $this->extras = $extras;
81
    }
82
83
    public function run()
84
    {
85
        // Most EVE players on Discord use their ingame name, so lets support @highlights
86
        $explode = explode(" ", $this->message->content);
87
        unset($explode[0]);
88
        $name = implode(" ", $explode);
89
        $name = stristr($name, "@") ? str_replace("<@", "", str_replace(">", "", $name)) : $name;
90
91
        if (is_numeric($name)) {
92
            // The person used @highlighting, so now we got a discord id, lets map that to a name
93
            $name = $this->db->queryField("SELECT nickName FROM users WHERE discordID = :id", "nickName", array(":id" => $name));
94
        }
95
96
        $url = "https://evedata.xyz/api/search/character/" . urlencode($name) . "/";
97
        $data = @json_decode($this->curl->get($url), true)["character"];
98
        if (empty($data)) {
99
            return $this->message->reply("**Error:** no results was returned.");
100
        }
101
102
        $exists = false;
103
        if (count($data) > 1) {
104
            $results = array();
105
            foreach ($data as $char) {
106
                if (strtolower($char["characterName"]) == strtolower($name)) {
107
                    $data[0]["characterID"] = $char["characterID"];
108
                    $exists = true;
109
                }
110
                $results[] = $char["characterName"];
111
            }
112
            if ($exists == false) {
0 ignored issues
show
Coding Style Best Practice introduced by
It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

When comparing two booleans, it is generally considered safer to use the strict comparison operator.

Loading history...
113
                return $this->message->reply("**Error:** more than one result was returned: " . implode(", ", $results));
114
            }
115
        }
116
117
        // Get stats
118
        $characterID = $data[0]["characterID"];
119
        $statsURL = "https://beta.eve-kill.net/api/charInfo/characterID/" . urlencode($characterID) . "/";
120
        $stats = json_decode($this->curl->get($statsURL), true);
121
        if (empty($stats)) {
122
            return $this->message->reply("**Error:** no data available");
123
        }
124
125
        $characterName = @$stats["characterName"];
126
        $corporationName = @$stats["corporationName"];
127
        $allianceName = isset($stats["allianceName"]) ? $stats["allianceName"] : "None";
128
        $factionName = isset($stats["factionName"]) ? $stats["factionName"] : "None";
129
        $securityStatus = @$stats["securityStatus"];
130
        $lastSeenSystem = @$stats["lastSeenSystem"];
131
        $lastSeenRegion = @$stats["lastSeenRegion"];
132
        $lastSeenShip = @$stats["lastSeenShip"];
133
        $lastSeenDate = @$stats["lastSeenDate"];
134
        $corporationActiveArea = @$stats["corporationActiveArea"];
135
        $allianceActiveArea = @$stats["allianceActiveArea"];
136
        $soloKills = @$stats["soloKills"];
137
        $blobKills = @$stats["blobKills"];
138
        $lifeTimeKills = @$stats["lifeTimeKills"];
139
        $lifeTimeLosses = @$stats["lifeTimeLosses"];
140
        $amountOfSoloPVPer = @$stats["percentageSoloPVPer"];
141
        $ePeenSize = @$stats["ePeenSize"];
142
        $facepalms = @$stats["facepalms"];
143
        $lastUpdated = @$stats["lastUpdatedOnBackend"];
144
        $url = "https://beta.eve-kill.net/character/" . $stats["characterID"] . "/";
145
        $msg = "```characterName: {$characterName}
146
corporationName: {$corporationName}
147
allianceName: {$allianceName}
148
factionName: {$factionName}
149
securityStatus: {$securityStatus}
150
lastSeenSystem: {$lastSeenSystem}
151
lastSeenRegion: {$lastSeenRegion}
152
lastSeenShip: {$lastSeenShip}
153
lastSeenDate: {$lastSeenDate}
154
corporationActiveArea: {$corporationActiveArea}
155
allianceActiveArea: {$allianceActiveArea}
156
soloKills: {$soloKills}
157
blobKills: {$blobKills}
158
lifeTimeKills: {$lifeTimeKills}
159
lifeTimeLosses: {$lifeTimeLosses}
160
percentageSoloPVPer: {$amountOfSoloPVPer}
161
ePeenSize: {$ePeenSize}
162
facepalms: {$facepalms}
163
lastUpdated: $lastUpdated```
164
For more info, visit: $url";
165
        $this->message->reply($msg);
166
167
        // Mark this as garbage
168
        $this->isGarbage();
169
    }
170
}