Permissions::get() - Code Metrics - sovereignbot/citadel - Measure and Improve Code Quality continuously with Scrutinizer

Permissions::get() A
last analyzed 2016-06-02 11:44 UTC

↳ Parent: Permissions

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	7
Bugs	4	Features	0

Metric	Value
cc	3
eloc	5
c	7
b	4
f	0
nc	3
nop	2
dl	0
loc	10
rs	9.4285

<?php

namespace Sovereign\Lib;


/**
 * Class Permissions
 * @package Sovereign\Lib
 */
class Permissions
{
    /**
     * @var Db
     */
    protected $db;
    /**
     * @var Config
     */
    protected $config;

    /**
     * Permissions constructor.
     * @param Db $db
     * @param Config $config
     */
    public function __construct(Db $db, Config $config)
    {
        $this->db = $db;
        $this->config = $config;
    }

    /**
     * @param $userID
     * @param $serverID
     * @return int|string
     */
    public function get($userID, $serverID)
    {
        foreach ($this->config->get("admins", "permissions") as $adminID) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if ($adminID == $userID) {
                return 2;
            }
        }

        return $this->db->queryField("SELECT permission FROM permissions WHERE userID = :userID AND serverID = :serverID", "permission", [":userID" => $userID, ":serverID" => $serverID]);
    }

    /**
     * @param $userID
     * @param $serverID
     * @param $permission
     */
    public function set($userID, $serverID, $permission)
    {
        $this->db->execute("INSERT INTO permissions (serverID, userID, permission) VALUE (:serverID, :userID, :permission) ON DUPLICATE KEY UPDATE permission = :permission", [":serverID" => $serverID, ":userID" => $userID, ":permission" => $permission]);
    }

}

1			<?php
2
3			namespace Sovereign\Lib;
4
5
6			/**
7			* Class Permissions
8			* @package Sovereign\Lib
9			*/
10			class Permissions
11			{
12			/**
13			* @var Db
14			*/
15			protected $db;
16			/**
17			* @var Config
18			*/
19			protected $config;
20
21			/**
22			* Permissions constructor.
23			* @param Db $db
24			* @param Config $config
25			*/
26			public function __construct(Db $db, Config $config)
27			{
28			$this->db = $db;
29			$this->config = $config;
30			}
31
32			/**
33			* @param $userID
34			* @param $serverID
35			* @return int\|string
36			*/
37			public function get($userID, $serverID)
38			{
39			foreach ($this->config->get("admins", "permissions") as $adminID) {
			0 ignored issues – show Bug introduced 2016-06-01 21:10 UTC by Report Bug Copy Issue Report The expression `$this->config->get('admins', 'permissions')` of type `null\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
40			if ($adminID == $userID) {
41			return 2;
42			}
43			}
44
45			return $this->db->queryField("SELECT permission FROM permissions WHERE userID = :userID AND serverID = :serverID", "permission", [":userID" => $userID, ":serverID" => $serverID]);
46			}
47
48			/**
49			* @param $userID
50			* @param $serverID
51			* @param $permission
52			*/
53			public function set($userID, $serverID, $permission)
54			{
55			$this->db->execute("INSERT INTO permissions (serverID, userID, permission) VALUE (:serverID, :userID, :permission) ON DUPLICATE KEY UPDATE permission = :permission", [":serverID" => $serverID, ":userID" => $userID, ":permission" => $permission]);
56			}
57
58			}

sovereignbot / citadel

Permissions::get() A last analyzed 2016-06-02 11:44 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Permissions::get() A
last analyzed 2016-06-02 11:44 UTC