Sovereign\Lib\Permissions

Complexity

Total Complexity

5

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	8
Bugs	4	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	get()	0	10	3
A	set()	0	4	1

<?php

namespace Sovereign\Lib;


/**
 * Class Permissions
 * @package Sovereign\Lib
 */
class Permissions
{
    /**
     * @var Db
     */
    protected $db;
    /**
     * @var Config
     */
    protected $config;

    /**
     * Permissions constructor.
     * @param Db $db
     * @param Config $config
     */
    public function __construct(Db $db, Config $config)
    {
        $this->db = $db;
        $this->config = $config;
    }

    /**
     * @param $userID
     * @param $serverID
     * @return int|string
     */
    public function get($userID, $serverID)
    {
        foreach ($this->config->get("admins", "permissions") as $adminID) {

The expression $this->config->get('admins', 'permissions') of type null|string is not guaranteed to be traversable. How about adding an additional type check?

            if ($adminID == $userID) {
                return 2;
            }
        }

        return $this->db->queryField("SELECT permission FROM permissions WHERE userID = :userID AND serverID = :serverID", "permission", [":userID" => $userID, ":serverID" => $serverID]);
    }

    /**
     * @param $userID
     * @param $serverID
     * @param $permission
     */
    public function set($userID, $serverID, $permission)
    {
        $this->db->execute("INSERT INTO permissions (serverID, userID, permission) VALUE (:serverID, :userID, :permission) ON DUPLICATE KEY UPDATE permission = :permission", [":serverID" => $serverID, ":userID" => $userID, ":permission" => $permission]);
    }

}