Sop\X509\GeneralName\IPv4Address

Complexity

Total Complexity

5

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	_octets()	0	8	2
A	fromOctets()	0	16	3

<?php

declare(strict_types = 1);

namespace Sop\X509\GeneralName;

class IPv4Address extends IPAddress
{
    /**
     * Initialize from octets.
     *
     * @param string $octets
     *
     * @throws \InvalidArgumentException
     *
     * @return self
     */
    public static function fromOctets(string $octets): self
    {
        $mask = null;
        $bytes = unpack('C*', $octets);
        switch (count($bytes)) {

It seems like $bytes can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            case 4:
                $ip = implode('.', $bytes);

It seems like $bytes can also be of type false; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

                break;
            case 8:
                $ip = implode('.', array_slice($bytes, 0, 4));

It seems like $bytes can also be of type false; however, parameter $array of array_slice() does only seem to accept array, maybe add an additional type check?

                $mask = implode('.', array_slice($bytes, 4, 4));
                break;
            default:
                throw new \UnexpectedValueException('Invalid IPv4 octet length.');
        }
        return new self($ip, $mask);
    }

    /**
     * {@inheritdoc}
     */
    protected function _octets(): string
    {
        $bytes = array_map('intval', explode('.', $this->_ip));
        if (isset($this->_mask)) {
            $bytes = array_merge($bytes,
                array_map('intval', explode('.', $this->_mask)));
        }
        return pack('C*', ...$bytes);
    }
}