Sop\X509\GeneralName\IPv4Address::fromOctets()

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	3

Importance

Changes

0

<?php
    public static function fromOctets(string $octets): self
    {
        $mask = null;
        $bytes = unpack('C*', $octets);
        switch (count($bytes)) {

It seems like $bytes can also be of type false; however, parameter $var of count() does only seem to accept Countable|array, maybe add an additional type check?

            case 4:
                $ip = implode('.', $bytes);

It seems like $bytes can also be of type false; however, parameter $pieces of implode() does only seem to accept array, maybe add an additional type check?

                break;
            case 8:
                $ip = implode('.', array_slice($bytes, 0, 4));

It seems like $bytes can also be of type false; however, parameter $array of array_slice() does only seem to accept array, maybe add an additional type check?

                $mask = implode('.', array_slice($bytes, 4, 4));
                break;
            default:
                throw new \UnexpectedValueException('Invalid IPv4 octet length.');
        }
        return new self($ip, $mask);
    }