sop / x509

lib/X509/AttributeCertificate/Attribute/IetfAttrSyntax.php

Doc Comments +1 added lines

@@ -37,6 +37,7 @@
 	 * Constructor
 	 *
 	 * @param IetfAttrValue ...$values
+	 * @param IetfAttrValue[] $values
 	 */
 	public function __construct(IetfAttrValue ...$values) {
 		$this->_policyAuthority = null;

Spacing +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
 			++$idx;
 		}
 		$values = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return IetfAttrValue::fromASN1($el);
 			}, $seq->at($idx)
 				->asSequence()
@@ -134,7 +134,7 @@ 
 				$this->_policyAuthority->toASN1());
 		}
 		$values = array_map(
-			function (IetfAttrValue $val) {
+			function(IetfAttrValue $val) {
 				return $val->toASN1();
 			}, $this->_values);
 		$elements[] = new Sequence(...$values);

lib/X509/Certificate/Extension/CertificatePolicy/DisplayText.php

Doc Comments +4 added lines, -1 removed lines

@@ -79,7 +79,7 @@ 
 	 * Generate ASN.1 element.
 	 *
 	 * @throws \UnexpectedValueException
-	 * @return StringType
+	 * @return Element[]
 	 */
 	public function toASN1() {
 		switch ($this->_tag) {
@@ -97,6 +97,9 @@ 
 		}
 	}
 	
+	/**
+	 * @param string $str
+	 */
 	protected static function _determineType($str) {
 		// @todo Support other types
 		return Element::TYPE_UTF8_STRING;

lib/X509/Certificate/Extension/PolicyMappingsExtension.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	 *
 	 * @param string $critical
 	 * @param PolicyMapping ...$mappings One or more PolicyMapping objects
+	 * @param PolicyMapping[] $mappings
 	 */
 	public function __construct($critical, PolicyMapping ...$mappings) {
 		parent::__construct(self::OID_POLICY_MAPPINGS, $critical);

Spacing +2 added lines, -2 removed lines

@@ -36,7 +36,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$mappings = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return PolicyMapping::fromASN1($el->asSequence());
 			}, Sequence::fromDER($data)->elements());
 		if (!count($mappings)) {
@@ -51,7 +51,7 @@ 
 			throw new \LogicException("No mappings.");
 		}
 		$elements = array_map(
-			function (PolicyMapping $mapping) {
+			function(PolicyMapping $mapping) {
 				return $mapping->toASN1();
 			}, $this->_mappings);
 		return new Sequence(...$elements);

lib/X509/Certificate/TBSCertificate.php

Doc Comments +2 added lines, -1 removed lines

@@ -356,6 +356,7 @@ 
 	 * Get self with extensions added.
 	 *
 	 * @param Extension ...$exts One or more Extension objects
+	 * @param Extension[] $exts
 	 * @return self
 	 */
 	public function withAdditionalExtensions(Extension ...$exts) {
@@ -397,7 +398,7 @@ 
 	/**
 	 * Get serial number.
 	 *
-	 * @return int|string Base 10 integer
+	 * @return integer Base 10 integer
 	 */
 	public function serialNumber() {
 		if (!$this->hasSerialNumber()) {

lib/X509/CertificationPath/PathValidation/PathValidator.php

Doc Comments +1 added lines

@@ -50,6 +50,7 @@
 	 * @param Crypto $crypto
 	 * @param PathValidationConfig $config
 	 * @param Certificate ...$certificates
+	 * @param Certificate[] $certificates
 	 */
 	public function __construct(Crypto $crypto, PathValidationConfig $config, 
 			Certificate ...$certificates) {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use CryptoUtil\Crypto\Crypto;
 use X509\Certificate\Certificate;
-use X509\Certificate\Extension\Extension;
 use X509\Certificate\TBSCertificate;
 use X509\CertificationPath\Exception\PathValidationException;
 

lib/X509/CertificationRequest/CertificationRequestInfo.php

Doc Comments -1 removed lines

@@ -197,7 +197,6 @@
 	 *
 	 * @param Crypto $crypto Crypto engine
 	 * @param SignatureAlgorithmIdentifier $algo Algorithm used for signing
-	 * @param PrivateKey $private_key Private key used for signing
 	 * @return CertificationRequest
 	 */
 	public function sign(Crypto $crypto, SignatureAlgorithmIdentifier $algo, 

lib/X509/GeneralName/GeneralNames.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	 * Constructor
 	 *
 	 * @param GeneralName ...$names One or more GeneralName objects
+	 * @param GeneralName[] $names
 	 */
 	public function __construct(GeneralName ...$names) {
 		$this->_names = $names;

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$names = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return GeneralName::fromASN1($el->asTagged());
 			}, $seq->elements());
 		return new self(...$names);
@@ -100,7 +100,7 @@ 
 	 */
 	public function allOf($tag) {
 		$names = array_filter($this->_names, 
-			function (GeneralName $name) use ($tag) {
+			function(GeneralName $name) use ($tag) {
 				return $name->tag() == $tag;
 			});
 		return array_values($names);
@@ -144,7 +144,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$elements = array_map(
-			function (GeneralName $name) {
+			function(GeneralName $name) {
 				return $name->toASN1();
 			}, $this->_names);
 		return new Sequence(...$elements);

lib/X509/GeneralName/IPv6Address.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	
 	protected static function _wordsToIPv6String(array $words) {
 		$groups = array_map(
-			function ($word) {
+			function($word) {
 				return sprintf("%04x", $word);
 			}, $words);
 		return implode(":", $groups);

lib/X509/Certificate/CertificateBundle.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 	 */
 	public static function fromPEMs(PEM ...$pems) {
 		$certs = array_map(
-			function ($pem) {
+			function($pem) {
 				return Certificate::fromPEM($pem);
 			}, $pems);
 		return new self(...$certs);