sop / x509

lib/X509/CertificationPath/PathValidation/PathValidator.php

Doc Comments +1 added lines

@@ -50,6 +50,7 @@
 	 * @param Crypto $crypto
 	 * @param PathValidationConfig $config
 	 * @param Certificate ...$certificates
+	 * @param Certificate[] $certificates
 	 */
 	public function __construct(Crypto $crypto, PathValidationConfig $config, 
 			Certificate ...$certificates) {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use CryptoUtil\Crypto\Crypto;
 use X509\Certificate\Certificate;
-use X509\Certificate\Extension\Extension;
 use X509\Certificate\TBSCertificate;
 use X509\CertificationPath\Exception\PathValidationException;
 

lib/X509/CertificationRequest/CertificationRequestInfo.php

Doc Comments -1 removed lines

@@ -197,7 +197,6 @@
 	 *
 	 * @param Crypto $crypto Crypto engine
 	 * @param SignatureAlgorithmIdentifier $algo Algorithm used for signing
-	 * @param PrivateKey $private_key Private key used for signing
 	 * @return CertificationRequest
 	 */
 	public function sign(Crypto $crypto, SignatureAlgorithmIdentifier $algo, 

lib/X509/GeneralName/GeneralNames.php

Doc Comments +1 added lines

@@ -28,6 +28,7 @@
 	 * Constructor
 	 *
 	 * @param GeneralName ...$names One or more GeneralName objects
+	 * @param GeneralName[] $names
 	 */
 	public function __construct(GeneralName ...$names) {
 		$this->_names = $names;

Spacing +3 added lines, -3 removed lines

@@ -46,7 +46,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$names = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return GeneralName::fromASN1($el->asTagged());
 			}, $seq->elements());
 		return new self(...$names);
@@ -100,7 +100,7 @@ 
 	 */
 	public function allOf($tag) {
 		$names = array_filter($this->_names, 
-			function (GeneralName $name) use ($tag) {
+			function(GeneralName $name) use ($tag) {
 				return $name->tag() == $tag;
 			});
 		return array_values($names);
@@ -144,7 +144,7 @@ 
 				"GeneralNames must have at least one GeneralName.");
 		}
 		$elements = array_map(
-			function (GeneralName $name) {
+			function(GeneralName $name) {
 				return $name->toASN1();
 			}, $this->_names);
 		return new Sequence(...$elements);

lib/X509/GeneralName/IPv6Address.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 	
 	protected static function _wordsToIPv6String(array $words) {
 		$groups = array_map(
-			function ($word) {
+			function($word) {
 				return sprintf("%04x", $word);
 			}, $words);
 		return implode(":", $groups);

lib/X509/Certificate/CertificateBundle.php

Spacing +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
 	 */
 	public static function fromPEMs(PEM ...$pems) {
 		$certs = array_map(
-			function ($pem) {
+			function($pem) {
 				return Certificate::fromPEM($pem);
 			}, $pems);
 		return new self(...$certs);

lib/X509/Feature/AttributeContainer.php

Spacing +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
 	public function allOf($name) {
 		$oid = AttributeType::attrNameToOID($name);
 		$attrs = array_filter($this->_attributes, 
-			function (Attribute $attr) use ($oid) {
+			function(Attribute $attr) use ($oid) {
 				return $attr->oid() == $oid;
 			});
 		return array_values($attrs);
@@ -110,7 +110,7 @@ 
 	public function withUnique(Attribute $attr) {
 		$obj = clone $this;
 		$obj->_attributes = array_filter($obj->_attributes, 
-			function (Attribute $a) use ($attr) {
+			function(Attribute $a) use ($attr) {
 				return $a->oid() != $attr->oid();
 			});
 		$obj->_attributes[] = $attr;

lib/X509/CertificationPath/PathBuilding/CertificationPathBuilder.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
 		$paths = $this->_resolvePathsToTarget($target, $intermediate);
 		// map paths to CertificationPath objects
 		return array_map(
-			function ($certs) {
+			function($certs) {
 				return new CertificationPath(...$certs);
 			}, $paths);
 	}
@@ -108,7 +108,7 @@ 
 			throw new PathBuildingException("No certification paths.");
 		}
 		usort($paths, 
-			function ($a, $b) {
+			function($a, $b) {
 				return count($a) < count($b) ? -1 : 1;
 			});
 		return reset($paths);

lib/X509/Certificate/Extension/SubjectDirectoryAttributesExtension.php

Spacing +2 added lines, -2 removed lines

@@ -31,7 +31,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$attribs = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return Attribute::fromASN1($el->asSequence());
 			}, Sequence::fromDER($data)->elements());
 		if (!count($attribs)) {
@@ -46,7 +46,7 @@ 
 			throw new \LogicException("No attributes");
 		}
 		$elements = array_map(
-			function (Attribute $attr) {
+			function(Attribute $attr) {
 				return $attr->toASN1();
 			}, array_values($this->_attributes));
 		return new Sequence(...$elements);

lib/X509/Certificate/Extension/TargetInformationExtension.php

Spacing +4 added lines, -4 removed lines

@@ -48,7 +48,7 @@ 
 	
 	protected static function _fromDER($data, $critical) {
 		$targets = array_map(
-			function (UnspecifiedType $el) {
+			function(UnspecifiedType $el) {
 				return Targets::fromASN1($el->asSequence());
 			}, Sequence::fromDER($data)->elements());
 		return new self($critical, ...$targets);
@@ -77,7 +77,7 @@ 
 	 */
 	public function names() {
 		$targets = array_filter($this->targets(), 
-			function (Target $target) {
+			function(Target $target) {
 				return $target->type() == Target::TYPE_NAME;
 			});
 		return array_values($targets);
@@ -90,7 +90,7 @@ 
 	 */
 	public function groups() {
 		$targets = array_filter($this->targets(), 
-			function (Target $target) {
+			function(Target $target) {
 				return $target->type() == Target::TYPE_GROUP;
 			});
 		return array_values($targets);
@@ -98,7 +98,7 @@ 
 	
 	protected function _valueASN1() {
 		$elements = array_map(
-			function (Targets $targets) {
+			function(Targets $targets) {
 				return $targets->toASN1();
 			}, $this->_targets);
 		return new Sequence(...$elements);