sop / x501

lib/X501/ASN1/Attribute.php

Doc Comments +2 added lines

@@ -31,6 +31,7 @@ 
 	 *
 	 * @param AttributeType $type Attribute type
 	 * @param AttributeValue ...$values Attribute values
+	 * @param AttributeValue[] $values
 	 */
 	public function __construct(AttributeType $type, AttributeValue ...$values) {
 		// check that attribute values have correct oid
@@ -64,6 +65,7 @@ 
 	 * Convenience method to initialize from attribute values.
 	 *
 	 * @param AttributeValue ...$values One or more values
+	 * @param AttributeValue[] $values
 	 * @throws \LogicException
 	 * @return self
 	 */

Spacing +4 added lines, -4 removed lines

@@ -35,7 +35,7 @@ 
 	public function __construct(AttributeType $type, AttributeValue ...$values) {
 		// check that attribute values have correct oid
 		array_walk($values, 
-			function (AttributeValue $value) use ($type) {
+			function(AttributeValue $value) use ($type) {
 				if ($value->oid() != $type->oid()) {
 					throw new \LogicException("Attribute OID mismatch.");
 				}
@@ -54,7 +54,7 @@ 
 		$type = AttributeType::fromASN1(
 			$seq->at(0, Element::TYPE_OBJECT_IDENTIFIER));
 		$values = array_map(
-			function (Element $el) use ($type) {
+			function(Element $el) use ($type) {
 				return AttributeValue::fromASN1ByOID($type->oid(), $el);
 			}, $seq->at(1, Element::TYPE_SET)->elements());
 		return new self($type, ...$values);
@@ -105,7 +105,7 @@ 
 	 */
 	public function toASN1() {
 		$values = array_map(
-			function (AttributeValue $value) {
+			function(AttributeValue $value) {
 				return $value->toASN1();
 			}, $this->_values);
 		$valueset = new Set(...$values);
@@ -133,7 +133,7 @@ 
 		}
 		$oid = $this->oid();
 		$values = array_map(
-			function (AttributeValue $value) use ($cls, $oid) {
+			function(AttributeValue $value) use ($cls, $oid) {
 				$value = $cls::fromSelf($value);
 				if ($value->oid() != $oid) {
 					throw new \LogicException("Attribute OID mismatch.");

lib/X501/ASN1/Name.php

Doc Comments +1 added lines

@@ -30,6 +30,7 @@
 	 * Constructor
 	 *
 	 * @param RDN ...$rdns RDN components
+	 * @param RDN[] $rdns
 	 */
 	public function __construct(RDN ...$rdns) {
 		$this->_rdns = $rdns;

Spacing +3 added lines, -3 removed lines

@@ -43,7 +43,7 @@ 
 	 */
 	public static function fromASN1(Sequence $seq) {
 		$rdns = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return RDN::fromASN1($el->expectType(Element::TYPE_SET));
 			}, $seq->elements());
 		return new self(...$rdns);
@@ -83,7 +83,7 @@ 
 	 */
 	public function toASN1() {
 		$elements = array_map(
-			function (RDN $rdn) {
+			function(RDN $rdn) {
 				return $rdn->toASN1();
 			}, $this->_rdns);
 		return new Sequence(...$elements);
@@ -97,7 +97,7 @@ 
 	 */
 	public function toString() {
 		$parts = array_map(
-			function (RDN $rdn) {
+			function(RDN $rdn) {
 				return $rdn->toString();
 			}, array_reverse($this->_rdns));
 		return implode(",", $parts);

lib/X501/ASN1/RDN.php

Doc Comments +2 added lines

@@ -26,6 +26,7 @@ 
 	 * Constructor
 	 *
 	 * @param AttributeTypeAndValue ...$attribs One or more attributes
+	 * @param AttributeTypeAndValue[] $attribs
 	 */
 	public function __construct(AttributeTypeAndValue ...$attribs) {
 		if (!count($attribs)) {
@@ -39,6 +40,7 @@ 
 	 * Convenience method to initialize RDN from AttributeValue objects.
 	 *
 	 * @param AttributeValue ...$values One or more attributes
+	 * @param AttributeValue[] $values
 	 * @return self
 	 */
 	public static function fromAttributeValues(AttributeValue ...$values) {

Spacing +4 added lines, -4 removed lines

@@ -43,7 +43,7 @@ 
 	 */
 	public static function fromAttributeValues(AttributeValue ...$values) {
 		$attribs = array_map(
-			function (AttributeValue $value) {
+			function(AttributeValue $value) {
 				return new AttributeTypeAndValue(
 					new AttributeType($value->oid()), $value);
 			}, $values);
@@ -58,7 +58,7 @@ 
 	 */
 	public static function fromASN1(Set $set) {
 		$attribs = array_map(
-			function (Element $el) {
+			function(Element $el) {
 				return AttributeTypeAndValue::fromASN1(
 					$el->expectType(Element::TYPE_SEQUENCE));
 			}, $set->elements());
@@ -72,7 +72,7 @@ 
 	 */
 	public function toASN1() {
 		$elements = array_map(
-			function (AttributeTypeAndValue $tv) {
+			function(AttributeTypeAndValue $tv) {
 				return $tv->toASN1();
 			}, $this->_attribs);
 		$set = new Set(...$elements);
@@ -87,7 +87,7 @@ 
 	 */
 	public function toString() {
 		$parts = array_map(
-			function (AttributeTypeAndValue $tv) {
+			function(AttributeTypeAndValue $tv) {
 				return $tv->toString();
 			}, $this->_attribs);
 		return implode("+", $parts);

lib/X501/DN/DNParser.php

Doc Comments +1 added lines, -1 removed lines

@@ -327,7 +327,7 @@
 	 *
 	 * @param string $pattern
 	 * @param int $offset
-	 * @return string|null Null if pattern doesn't match
+	 * @return string Null if pattern doesn't match
 	 */
 	private function _regexMatch($pattern, &$offset) {
 		$idx = $offset;

Spacing +2 added lines, -2 removed lines

@@ -62,11 +62,11 @@
 		$str = preg_replace('/^([ #])/u', '\\\\$1', $str);
 		// implementation specific special characters
 		$str = preg_replace_callback('/([\pC])/u', 
-			function ($m) {
+			function($m) {
 				$octets = str_split(bin2hex($m[1]), 2);
 				return implode("", 
 					array_map(
-						function ($octet) {
+						function($octet) {
 							return '\\' . strtoupper($octet);
 						}, $octets));
 			}, $str);