Completed
Pull Request — master (#1073)
by Vincent
01:33
created
tests/Filter/QueryBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
     }
125 125
 
126 126
     /**
127
-     * @return array
127
+     * @return string[]
128 128
      */
129 129
     public function getAllAliases()
130 130
     {
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     }
133 133
 
134 134
     /**
135
-     * @return array
135
+     * @return string[]
136 136
      */
137 137
     public function getRootAliases()
138 138
     {
Please login to merge, or discard this patch.
src/Filter/Filter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
     }
57 57
 
58 58
     /**
59
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
59
+     * @param ProxyQueryInterface $queryBuilder
60 60
      * @param mixed                            $parameter
61 61
      */
62 62
     protected function applyWhere(ProxyQueryInterface $queryBuilder, $parameter): void
Please login to merge, or discard this patch.
src/Builder/ListBuilder.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -63,6 +63,9 @@
 block discarded – undo
63 63
         $this->fixFieldDescription($admin, $fieldDescription);
64 64
     }
65 65
 
66
+    /**
67
+     * @param string|null $type
68
+     */
66 69
     public function addField(FieldDescriptionCollection $list, ?string $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin): void
67 70
     {
68 71
         $this->buildField($type, $fieldDescription, $admin);
Please login to merge, or discard this patch.
src/Builder/ShowBuilder.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@
 block discarded – undo
47 47
         return new FieldDescriptionCollection();
48 48
     }
49 49
 
50
+    /**
51
+     * @param null|string $type
52
+     */
50 53
     public function addField(FieldDescriptionCollection $list, ?string $type, FieldDescriptionInterface $fieldDescription, AdminInterface $admin): void
51 54
     {
52 55
         if (null === $type) {
Please login to merge, or discard this patch.
src/Model/ModelManager.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,6 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
     /**
62 62
      * NEXT_MAJOR: Make $propertyAccessor mandatory.
63
+     * @param \Symfony\Component\PropertyAccess\PropertyAccessor $propertyAccessor
63 64
      */
64 65
     public function __construct(ManagerRegistry $registry, ?PropertyAccessorInterface $propertyAccessor = null)
65 66
     {
@@ -661,7 +662,7 @@  discard block
 block discarded – undo
661 662
      *
662 663
      * @param string $property
663 664
      *
664
-     * @return mixed
665
+     * @return string
665 666
      */
666 667
     protected function camelize($property)
667 668
     {
Please login to merge, or discard this patch.
tests/Model/ModelManagerTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -944,6 +944,9 @@
 block discarded – undo
944 944
         $this->assertNull($this->modelManager->getNormalizedIdentifier(null));
945 945
     }
946 946
 
947
+    /**
948
+     * @param string $class
949
+     */
947 950
     private function getMetadata($class, $isVersioned)
948 951
     {
949 952
         $metadata = new ClassMetadata($class);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,6 @@
 block discarded – undo
33 33
 use PHPUnit\Framework\MockObject\MockObject;
34 34
 use PHPUnit\Framework\TestCase;
35 35
 use Sonata\AdminBundle\Admin\FieldDescriptionInterface;
36
-use Sonata\AdminBundle\Datagrid\Datagrid;
37 36
 use Sonata\AdminBundle\Datagrid\DatagridInterface;
38 37
 use Sonata\AdminBundle\Exception\LockException;
39 38
 use Sonata\AdminBundle\Exception\ModelManagerException;
Please login to merge, or discard this patch.
src/Filter/ModelAutocompleteFilter.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      * For the record, the $alias value is provided by the association method (and the entity join method)
66 66
      *  so the field value is not used here.
67 67
      *
68
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
68
+     * @param ProxyQueryInterface $queryBuilder
69 69
      * @param string                           $alias
70 70
      * @param mixed                            $data
71 71
      */
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
     }
88 88
 
89 89
     /**
90
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
90
+     * @param ProxyQueryInterface $queryBuilder
91 91
      * @param string                           $alias
92 92
      * @param mixed                            $data
93 93
      */
Please login to merge, or discard this patch.