Completed
Pull Request — master (#783)
by Grégoire
02:49
created
tests/Filter/QueryBuilder.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
     }
125 125
 
126 126
     /**
127
-     * @return array
127
+     * @return string[]
128 128
      */
129 129
     public function getAllAliases()
130 130
     {
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
     }
133 133
 
134 134
     /**
135
-     * @return array
135
+     * @return string[]
136 136
      */
137 137
     public function getRootAliases()
138 138
     {
Please login to merge, or discard this patch.
src/Filter/ModelAutocompleteFilter.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
      * For the record, the $alias value is provided by the association method (and the entity join method)
80 80
      *  so the field value is not used here.
81 81
      *
82
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
82
+     * @param ProxyQueryInterface $queryBuilder
83 83
      * @param string                           $alias
84 84
      * @param mixed                            $data
85 85
      *
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     }
104 104
 
105 105
     /**
106
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
106
+     * @param ProxyQueryInterface $queryBuilder
107 107
      * @param string                           $alias
108 108
      * @param mixed                            $data
109 109
      *
Please login to merge, or discard this patch.
src/Filter/Filter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
     }
57 57
 
58 58
     /**
59
-     * @param ProxyQueryInterface|QueryBuilder $queryBuilder
59
+     * @param ProxyQueryInterface $queryBuilder
60 60
      * @param mixed                            $parameter
61 61
      */
62 62
     protected function applyWhere(ProxyQueryInterface $queryBuilder, $parameter): void
Please login to merge, or discard this patch.
tests/Model/ModelManagerTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -736,6 +736,9 @@
 block discarded – undo
736 736
         $this->assertNull($model->getNormalizedIdentifier(null));
737 737
     }
738 738
 
739
+    /**
740
+     * @param string $class
741
+     */
739 742
     private function getMetadata($class, $isVersioned)
740 743
     {
741 744
         $metadata = new ClassMetadata($class);
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,6 @@
 block discarded – undo
26 26
 use Doctrine\ORM\OptimisticLockException;
27 27
 use Doctrine\ORM\Query;
28 28
 use Doctrine\ORM\QueryBuilder;
29
-use Doctrine\ORM\Version;
30 29
 use PHPUnit\Framework\TestCase;
31 30
 use Sonata\AdminBundle\Datagrid\Datagrid;
32 31
 use Sonata\AdminBundle\Datagrid\DatagridInterface;
Please login to merge, or discard this patch.
src/Model/ModelManager.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -296,7 +296,6 @@  discard block
 block discarded – undo
296 296
     }
297 297
 
298 298
     /**
299
-     * @param QueryBuilder|Query $class
300 299
      */
301 300
     public function executeQuery($query)
302 301
     {
@@ -620,7 +619,7 @@  discard block
 block discarded – undo
620 619
      *
621 620
      * @param string $property
622 621
      *
623
-     * @return mixed
622
+     * @return string
624 623
      */
625 624
     protected function camelize($property)
626 625
     {
Please login to merge, or discard this patch.