sonata-project / SonataAdminBundle

src/Admin/AbstractAdmin.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 
 use Doctrine\Common\Util\ClassUtils;
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
-use Knp\Menu\ItemInterface;
 use Knp\Menu\ItemInterface as MenuItemInterface;
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
 use Sonata\AdminBundle\Builder\FormContractorInterface;

Doc Comments +7 added lines, -1 removed lines

@@ -949,6 +949,7 @@ 
 
     /**
      * NEXT_MAJOR: remove this method.
+     * @param string $subClass
      */
     public function addSubClass($subClass): void
     {
@@ -1104,6 +1105,9 @@ 
         return $this->routeGenerator->hasAdminRoute($this, $name);
     }
 
+    /**
+     * @param string $adminCode
+     */
     public function isCurrentRoute(string $name, ?string $adminCode = null): bool
     {
         if (!$this->hasRequest()) {
@@ -2127,7 +2131,7 @@ 
      *
      * @param string $context
      *
-     * @return array
+     * @return string[]
      */
     public function getPermissionsShow($context)
     {
@@ -2532,6 +2536,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param boolean $isShown
      */
     final public function showMosaicButton($isShown): void
     {
@@ -2663,6 +2668,7 @@ 
      * NEXT_MAJOR: remove this method.
      *
      * @deprecated Use configureTabMenu instead
+     * @param string $action
      */
     protected function configureSideMenu(MenuItemInterface $menu, $action, AdminInterface $childAdmin = null)
     {

src/Admin/FieldDescriptionCollection.php

Doc Comments +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
     }
 
     /**
-     * @return array
+     * @return FieldDescriptionInterface[]
      */
     public function getElements()
     {

src/Controller/CRUDController.php

Doc Comments +5 added lines, -5 removed lines

@@ -208,7 +208,7 @@ 
     /**
      * Delete action.
      *
-     * @param int|string|null $id
+     * @param integer|null $id
      *
      * @throws NotFoundHttpException If the object does not exist
      * @throws AccessDeniedException If access is not granted
@@ -726,7 +726,7 @@ 
     /**
      * View history revision of object.
      *
-     * @param int|string|null $id
+     * @param null|integer $id
      * @param string|null     $revision
      *
      * @throws AccessDeniedException If access is not granted
@@ -786,9 +786,9 @@ 
     /**
      * Compare history revisions of object.
      *
-     * @param int|string|null $id
-     * @param int|string|null $base_revision
-     * @param int|string|null $compare_revision
+     * @param null|integer $id
+     * @param null|integer $base_revision
+     * @param null|integer $compare_revision
      *
      * @throws AccessDeniedException If access is not granted
      * @throws NotFoundHttpException If the object or revision does not exist or the audit reader is not available

src/Datagrid/Pager.php

Doc Comments +2 added lines, -2 removed lines

@@ -434,7 +434,7 @@ 
      * Returns a parameter.
      *
      * @param string $name
-     * @param mixed  $default
+     * @param null|string  $default
      *
      * @return mixed
      */
@@ -459,7 +459,7 @@ 
      * Sets a parameter.
      *
      * @param string $name
-     * @param mixed  $value
+     * @param string  $value
      */
     public function setParameter($name, $value): void
     {

src/Admin/Pool.php

Doc Comments +1 added lines, -1 removed lines

@@ -295,7 +295,7 @@
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getAdminServiceIds()
     {

src/Twig/Extension/SonataAdminExtension.php

Unused Use Statements -1 removed lines

@@ -22,7 +22,6 @@
 use Symfony\Component\Translation\TranslatorInterface;
 use Twig\Environment;
 use Twig\Extension\AbstractExtension;
-use Twig\Template;
 use Twig\TemplateWrapper;
 use Twig\TwigFilter;
 use Twig\TwigFunction;

Doc Comments +4 added lines, -4 removed lines

@@ -164,7 +164,7 @@ 
     /**
      * render a list element from the FieldDescription.
      *
-     * @param object $object
+     * @param \stdClass $object
      * @param array  $params
      *
      * @return string
@@ -245,7 +245,7 @@ 
     /**
      * render a view element.
      *
-     * @param object $object
+     * @param \stdClass $object
      *
      * @return string
      */
@@ -382,7 +382,7 @@ 
     /**
      * Get the identifiers as a string that is safe to use in a url.
      *
-     * @param object $model
+     * @param \stdClass $model
      *
      * @return string string representation of the id that is safe to use in a url
      */
@@ -404,7 +404,7 @@ 
     }
 
     /**
-     * @return string|bool
+     * @return string|false
      */
     public function getXEditableType($type)
     {

src/Maker/AdminMaker.php

Doc Comments +3 added lines

@@ -68,6 +68,9 @@
      */
     private $modelManager;
 
+    /**
+     * @param string $projectDirectory
+     */
     public function __construct($projectDirectory, array $modelManagers = [])
     {
         $this->projectDirectory = $projectDirectory;

src/Object/MetadataInterface.php

Doc Comments +9 added lines

@@ -20,10 +20,19 @@
 {
     public function getTitle(): string;
 
+    /**
+     * @return string|null
+     */
     public function getDescription(): ?string;
 
+    /**
+     * @return string|null
+     */
     public function getImage(): ?string;
 
+    /**
+     * @return string|null
+     */
     public function getDomain(): ?string;
 
     /**

tests/Fixtures/Admin/PostAdmin.php

Doc Comments +3 added lines

@@ -19,6 +19,9 @@
 {
     protected $metadataClass = null;
 
+    /**
+     * @param string $associationMapping
+     */
     public function setParentAssociationMapping($associationMapping): void
     {
         $this->parentAssociationMapping = $associationMapping;