Completed
Pull Request — 3.x (#5199)
by Marko
04:27
created
src/Admin/AbstractAdmin.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,6 @@
 block discarded – undo
13 13
 
14 14
 use Doctrine\Common\Util\ClassUtils;
15 15
 use Knp\Menu\FactoryInterface as MenuFactoryInterface;
16
-use Knp\Menu\ItemInterface;
17 16
 use Knp\Menu\ItemInterface as MenuItemInterface;
18 17
 use Sonata\AdminBundle\Builder\DatagridBuilderInterface;
19 18
 use Sonata\AdminBundle\Builder\FormContractorInterface;
Please login to merge, or discard this patch.
Doc Comments   +11 added lines, -2 removed lines patch added patch discarded remove patch
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
     }
602 602
 
603 603
     /**
604
-     * @return array
604
+     * @return string[]
605 605
      */
606 606
     public function getExportFields()
607 607
     {
@@ -1052,6 +1052,7 @@  discard block
 block discarded – undo
1052 1052
 
1053 1053
     /**
1054 1054
      * NEXT_MAJOR: remove this method.
1055
+     * @param string $subClass
1055 1056
      */
1056 1057
     public function addSubClass($subClass)
1057 1058
     {
@@ -1180,6 +1181,10 @@  discard block
 block discarded – undo
1180 1181
         return $this->routeGenerator->hasAdminRoute($this, $name);
1181 1182
     }
1182 1183
 
1184
+    /**
1185
+     * @param string $name
1186
+     * @param string $adminCode
1187
+     */
1183 1188
     public function isCurrentRoute($name, $adminCode = null)
1184 1189
     {
1185 1190
         if (!$this->hasRequest()) {
@@ -2344,7 +2349,7 @@  discard block
 block discarded – undo
2344 2349
      *
2345 2350
      * @param string $context
2346 2351
      *
2347
-     * @return array
2352
+     * @return string[]
2348 2353
      */
2349 2354
     public function getPermissionsShow($context)
2350 2355
     {
@@ -2663,6 +2668,9 @@  discard block
 block discarded – undo
2663 2668
         return true;
2664 2669
     }
2665 2670
 
2671
+    /**
2672
+     * @param string $action
2673
+     */
2666 2674
     public function configureActionButtons($action, $object = null)
2667 2675
     {
2668 2676
         $list = [];
@@ -2920,6 +2928,7 @@  discard block
 block discarded – undo
2920 2928
     /**
2921 2929
      * NEXT_MAJOR: remove this method.
2922 2930
      *
2931
+     * @param string $action
2923 2932
      * @return mixed
2924 2933
      *
2925 2934
      * @deprecated Use configureTabMenu instead
Please login to merge, or discard this patch.
src/Admin/FieldDescriptionCollection.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
     }
31 31
 
32 32
     /**
33
-     * @return array
33
+     * @return FieldDescriptionInterface[]
34 34
      */
35 35
     public function getElements()
36 36
     {
Please login to merge, or discard this patch.
src/Generator/ControllerGenerator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
     private $file;
32 32
 
33 33
     /**
34
-     * @param array|string $skeletonDirectory
34
+     * @param string $skeletonDirectory
35 35
      */
36 36
     public function __construct($skeletonDirectory)
37 37
     {
Please login to merge, or discard this patch.
tests/Admin/Extension/LockExtensionTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -195,6 +195,10 @@
 block discarded – undo
195 195
         return new FormMapper($contractor->reveal(), $formBuilder, $this->admin->reveal());
196 196
     }
197 197
 
198
+    /**
199
+     * @param string $uniqid
200
+     * @param Request $request
201
+     */
198 202
     private function configureAdmin($uniqid = null, $request = null, $modelManager = null)
199 203
     {
200 204
         $this->admin->getUniqid()->willReturn($uniqid);
Please login to merge, or discard this patch.
tests/Controller/CRUDControllerTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -3759,6 +3759,9 @@  discard block
 block discarded – undo
3759 3759
         ];
3760 3760
     }
3761 3761
 
3762
+    /**
3763
+     * @param string $method
3764
+     */
3762 3765
     private function assertLoggerLogsModelManagerException($subject, $method)
3763 3766
     {
3764 3767
         $exception = new ModelManagerException(
@@ -3781,6 +3784,10 @@  discard block
 block discarded – undo
3781 3784
             ]);
3782 3785
     }
3783 3786
 
3787
+    /**
3788
+     * @param string $id
3789
+     * @param string $domain
3790
+     */
3784 3791
     private function expectTranslate($id, array $parameters = [], $domain = null, $locale = null)
3785 3792
     {
3786 3793
         $this->translator->expects($this->once())
Please login to merge, or discard this patch.
tests/Fixtures/Admin/PostAdmin.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -8,6 +8,9 @@
 block discarded – undo
8 8
 {
9 9
     protected $metadataClass = null;
10 10
 
11
+    /**
12
+     * @param string $associationMapping
13
+     */
11 14
     public function setParentAssociationMapping($associationMapping)
12 15
     {
13 16
         $this->parentAssociationMapping = $associationMapping;
Please login to merge, or discard this patch.
src/Controller/PolyfillControllerTrait.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -25,6 +25,9 @@
 block discarded – undo
25 25
  */
26 26
 trait PolyfillControllerTrait
27 27
 {
28
+    /**
29
+     * @param string $methodName
30
+     */
28 31
     public function __call($methodName, $arguments)
29 32
     {
30 33
         $this->proxyToController($methodName, $arguments);
Please login to merge, or discard this patch.
tests/Menu/Matcher/Voter/AdminVoterTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -70,6 +70,7 @@  discard block
 block discarded – undo
70 70
 
71 71
     /**
72 72
      * {@inheritdoc}
73
+     * @param string $code
73 74
      */
74 75
     private function getAdmin($code, $list = false, $granted = false)
75 76
     {
@@ -102,6 +103,8 @@  discard block
 block discarded – undo
102 103
 
103 104
     /**
104 105
      * {@inheritdoc}
106
+     * @param string $parentCode
107
+     * @param string $childCode
105 108
      */
106 109
     private function getChildAdmin($parentCode, $childCode, $list = false, $granted = false)
107 110
     {
Please login to merge, or discard this patch.
tests/Datagrid/DatagridMapperTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -266,6 +266,12 @@
 block discarded – undo
266 266
         ], array_keys($this->datagrid->getFilters()));
267 267
     }
268 268
 
269
+    /**
270
+     * @param string $name
271
+     * @param string $label
272
+     *
273
+     * @return string
274
+     */
269 275
     private function getFieldDescriptionMock($name = null, $label = null)
270 276
     {
271 277
         $fieldDescription = $this->getMockForAbstractClass(BaseFieldDescription::class);
Please login to merge, or discard this patch.